From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00054C4727D for ; Sat, 3 Oct 2020 07:51:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A4E9206CA for ; Sat, 3 Oct 2020 07:51:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="aXqNSfWi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725819AbgJCHvI (ORCPT ); Sat, 3 Oct 2020 03:51:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725648AbgJCHvF (ORCPT ); Sat, 3 Oct 2020 03:51:05 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2BEDC0613D0 for ; Sat, 3 Oct 2020 00:51:02 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id j2so4187665wrx.7 for ; Sat, 03 Oct 2020 00:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=k2ZUOGVbagWt3EpJ+oMKDCHsZP+OazieIj8l7AmZJ0o=; b=aXqNSfWiHGjdLU5AaDEHEnYaGYd29JMQZBGj4SAc3fivAPJhvOQ1hlBv9nsFlCsE4S lNRg2sUIqzH2OK8cuErFg9zmzFo/nVEUmMn59Mwo8pkCkffJLfQEzcc4Wk08p16+Rrew T8VK+7W1zwKNUivTBp8VvU2FW4ZSB/IhLTp0QNw/o119wqUWRrhRDahYonDP5LqUUgjD Fy2Z/cQnmmRaDWg5wjdCUlLyHieo3GgcjZ5Zvzk6j55261psIQKf6bqxFx1zZ1woJccE hbbG9MhIx3WBEzpfWdza/0PX0I/0uklTCDXFl3JW5htWa4zdZb4Cla9SDlNSsLYRD6oH W36Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=k2ZUOGVbagWt3EpJ+oMKDCHsZP+OazieIj8l7AmZJ0o=; b=D6O+WoTXlgozSFO08qVTm4BGk01aunnyvTVEPRJWBeiyyKR2JMqJ9gXO/9A8S9efc4 Hd2afDEd+6SIiBhPODzZux6i0x+aR/l+yK8jq0jQSJsHLr6DDWUEPn2lf2G12qaprvUQ iQwAPkJWM9UrMo8B2vsWA8Jc4s4mvH42WGEQNQrp6eZMOSGgEIFSqz9SwrzUecCUxaIg mqDiiSrPmnWBcuz0Nt6tKtf0mIudJ+nJtVUY8/NI2BoNQxbE1hlXsO9Kqtvy9Jk9yM6/ uoja8t3YVmXSQ3qqkKm+IuiGitpk6v96tTN4tNSu8e5ssjB7ExviDYuw8POJ8XwBvIhc rC3g== X-Gm-Message-State: AOAM533/84wnH1bgHP3Wj8au6dnJYa3pZBf9fJz5vLlrxkR/V0fJYfQX ygpC/L4COr3HaOX9WsBJwsvW2g== X-Google-Smtp-Source: ABdhPJxqRdPBhZAazHT0CqKubKS6w7Wua5O77b+z73+GAnYSU8NRh0JXhEPyMM5koPK2G9pe7W5IYA== X-Received: by 2002:adf:f504:: with SMTP id q4mr6938574wro.353.1601711461444; Sat, 03 Oct 2020 00:51:01 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id i14sm4780622wro.96.2020.10.03.00.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Oct 2020 00:51:00 -0700 (PDT) Date: Sat, 3 Oct 2020 09:51:00 +0200 From: Jiri Pirko To: Moshe Shemesh Cc: "David S. Miller" , Jakub Kicinski , Jiri Pirko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option Message-ID: <20201003075100.GC3159@nanopsycho.orion> References: <1601560759-11030-1-git-send-email-moshe@mellanox.com> <1601560759-11030-4-git-send-email-moshe@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1601560759-11030-4-git-send-email-moshe@mellanox.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thu, Oct 01, 2020 at 03:59:06PM CEST, moshe@mellanox.com wrote: [...] > enum devlink_attr { > /* don't change the order or add anything between, this is ABI! */ > DEVLINK_ATTR_UNSPEC, >@@ -507,6 +524,7 @@ enum devlink_attr { > > DEVLINK_ATTR_RELOAD_ACTION, /* u8 */ > DEVLINK_ATTR_RELOAD_ACTIONS_PERFORMED, /* u64 */ >+ DEVLINK_ATTR_RELOAD_LIMIT, /* u8 */ Hmm, why there could be specified only single "limit"? I believe this should be a bitfield. Same for the internal api to the driver. [...]