CC: kbuild-all(a)lists.01.org In-Reply-To: <20201003040257.62768-8-john.stultz@linaro.org> References: <20201003040257.62768-8-john.stultz@linaro.org> TO: John Stultz TO: lkml CC: John Stultz CC: Sumit Semwal CC: Liam Mark CC: Laura Abbott CC: Brian Starkey CC: Hridya Valsaraju CC: Suren Baghdasaryan CC: Sandeep Patil CC: Daniel Mentz From: kernel test robot drivers/dma-buf/heaps/system_heap.c:495:5-11: inconsistent IS_ERR and PTR_ERR on line 496. PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call to IS_ERR that is wrong. Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: John Stultz Signed-off-by: kernel test robot --- url: https://github.com/0day-ci/linux/commits/John-Stultz/dma-buf-Performance-improvements-for-system-heap-a-system-uncached-implementation/20201003-120520 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bcf876870b95592b52519ed4aafcf9d95999bc9c :::::: branch date: 4 hours ago :::::: commit date: 4 hours ago Please take the patch only if it's a positive warning. Thanks! system_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/dma-buf/heaps/system_heap.c +++ b/drivers/dma-buf/heaps/system_heap.c @@ -493,7 +493,7 @@ static int system_heap_create(void) sys_uncached_heap = dma_heap_add(&exp_info); if (IS_ERR(sys_uncached_heap)) - return PTR_ERR(sys_heap); + return PTR_ERR(sys_uncached_heap); dma_coerce_mask_and_coherent(dma_heap_get_dev(sys_uncached_heap), DMA_BIT_MASK(64));