* [PATCH] rm_work: Allow pseudo directory to be in the excludes
@ 2020-10-03 16:34 Jan-Simon Möller
2020-10-04 22:45 ` [OE-core] " Richard Purdie
0 siblings, 1 reply; 2+ messages in thread
From: Jan-Simon Möller @ 2020-10-03 16:34 UTC (permalink / raw)
To: openembedded-core; +Cc: Jan-Simon Möller
From: Jan-Simon Möller <dl9pf@gmx.de>
While debugging the pseudo issues, rm_work was always removing the pseudo folder
even when it was in the RM_WORK_EXCLUDE_ITEMS variable.
This patch puts the pseudo case within the conditional.
Signed-off-by: Jan-Simon Möller <dl9pf@gmx.de>
---
meta/classes/rm_work.bbclass | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/meta/classes/rm_work.bbclass b/meta/classes/rm_work.bbclass
index 01c2ab1c78..0e52fb6ae6 100644
--- a/meta/classes/rm_work.bbclass
+++ b/meta/classes/rm_work.bbclass
@@ -99,10 +99,12 @@ do_rm_work () {
do
# Retain only logs and other files in temp, safely ignore
# failures of removing pseudo folers on NFS2/3 server.
- if [ $dir = 'pseudo' ]; then
- rm -rf $dir 2> /dev/null || true
- elif ! echo "$excludes" | grep -q -w "$dir"; then
- rm -rf $dir
+ if ! echo "$excludes" | grep -q -w "$dir"; then
+ if [ $dir = 'pseudo' ]; then
+ rm -rf $dir 2> /dev/null || true
+ else
+ rm -rf $dir
+ fi
fi
done
}
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [OE-core] [PATCH] rm_work: Allow pseudo directory to be in the excludes
2020-10-03 16:34 [PATCH] rm_work: Allow pseudo directory to be in the excludes Jan-Simon Möller
@ 2020-10-04 22:45 ` Richard Purdie
0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2020-10-04 22:45 UTC (permalink / raw)
To: Jan-Simon Möller, openembedded-core
On Sat, 2020-10-03 at 18:34 +0200, Jan-Simon Möller wrote:
> From: Jan-Simon Möller <dl9pf@gmx.de>
>
> While debugging the pseudo issues, rm_work was always removing the
> pseudo folder
> even when it was in the RM_WORK_EXCLUDE_ITEMS variable.
>
> This patch puts the pseudo case within the conditional.
I've mixed feelings on this. Given the things rm_work removes, it has
to remove the pseudo database as well or you will get path mismatch
errors. I suspect we intentionally don't let the user do this.
Have you had this running without issues?
Cheers,
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-04 22:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-03 16:34 [PATCH] rm_work: Allow pseudo directory to be in the excludes Jan-Simon Möller
2020-10-04 22:45 ` [OE-core] " Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.