From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 267BDC47095 for ; Sat, 3 Oct 2020 18:54:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD8E5206DB for ; Sat, 3 Oct 2020 18:54:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="cH+yk6WL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725856AbgJCSyS (ORCPT ); Sat, 3 Oct 2020 14:54:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725818AbgJCSyS (ORCPT ); Sat, 3 Oct 2020 14:54:18 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E88B6C0613D0; Sat, 3 Oct 2020 11:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ShausBGebfFRLyt2+59SVmhWPvWC+7ycryEAzaFpAdQ=; b=cH+yk6WLMuSPIN5kWWeSQTvlT l2Z0ZNAZ5OIrVkLPmTqd+R/nVPaHOZ1zzn+eHcZv4mBgx5a3B4FigpSSx2T8ME3/s73TUqP6QII2p EkbmmbQGbgt87G5dGTbf3Z73xH6V0I+P5RTFdFZrBSJQbBUf3RFIEaQzNWPP9rwTUBb53u7w4/v9C qsuCuqIFadfCEorxIt0qQyH+RDh4L3ltVUZdDmzLTPenYavGgRb8GqccCLFZRJd3pM/4hNRwKq+Su pTgScjww1idpdw0tvAhQYnltbEWmc60qfcXq74pOh55+EuZwn/VaEjzP3xCZ9hy43ttcCRq4KcvIK 8Vf9UmpdQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41526) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOmfW-0007o9-Nk; Sat, 03 Oct 2020 19:54:06 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kOmfU-0005MD-UA; Sat, 03 Oct 2020 19:54:04 +0100 Date: Sat, 3 Oct 2020 19:54:04 +0100 From: Russell King - ARM Linux admin To: Codrin Ciubotariu Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wsa@kernel.org, alpawi@amazon.com Subject: Re: [PATCH] i2c: pxa: move to generic GPIO recovery Message-ID: <20201003185404.GH1551@shell.armlinux.org.uk> References: <20201003162141.925518-1-codrin.ciubotariu@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201003162141.925518-1-codrin.ciubotariu@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 03, 2020 at 07:21:41PM +0300, Codrin Ciubotariu wrote: > Starting with > commit 75820314de26 ("i2c: core: add generic I2C GPIO recovery") > GPIO bus recovery is supported by the I2C core, so we can remove the > driver implementation and use that one instead. > > Signed-off-by: Codrin Ciubotariu > --- > > This patch is not tested. > The only different thing should be the fact that the pinctl state is > now switched back to the default state after the bus is enabled. > > drivers/i2c/busses/i2c-pxa.c | 75 +++--------------------------------- > 1 file changed, 6 insertions(+), 69 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c > index 35ca2c02c9b9..dd357b6e6c61 100644 > --- a/drivers/i2c/busses/i2c-pxa.c > +++ b/drivers/i2c/busses/i2c-pxa.c > @@ -264,9 +264,6 @@ struct pxa_i2c { > u32 hs_mask; > > struct i2c_bus_recovery_info recovery; > - struct pinctrl *pinctrl; > - struct pinctrl_state *pinctrl_default; > - struct pinctrl_state *pinctrl_recovery; > }; > > #define _IBMR(i2c) ((i2c)->reg_ibmr) > @@ -1305,8 +1302,6 @@ static void i2c_pxa_prepare_recovery(struct i2c_adapter *adap) > */ > gpiod_set_value(i2c->recovery.scl_gpiod, ibmr & IBMR_SCLS); > gpiod_set_value(i2c->recovery.sda_gpiod, ibmr & IBMR_SDAS); > - > - WARN_ON(pinctrl_select_state(i2c->pinctrl, i2c->pinctrl_recovery)); > } > > static void i2c_pxa_unprepare_recovery(struct i2c_adapter *adap) > @@ -1325,8 +1320,6 @@ static void i2c_pxa_unprepare_recovery(struct i2c_adapter *adap) > i2c_pxa_do_reset(i2c); > } > > - WARN_ON(pinctrl_select_state(i2c->pinctrl, i2c->pinctrl_default)); > - This won't fly. We need to put the pinctrl back into i2c mode _before_ we re-enable the I2C module, otherwise the I2C block will see logic 0 on both SCL and SDA which could confuse the block. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 113C6C4363C for ; Sun, 4 Oct 2020 04:51:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8ABF4206DD for ; Sun, 4 Oct 2020 04:51:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pD4P1hBQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FliDVEEn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="cH+yk6WL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8ABF4206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yQRlhwpjfv9FvsRAFpgO+XRvPztaV9w9G6sJV0G4MP8=; b=pD4P1hBQbFGy1ZFMKLblNhG93 Gr1At/+vpmSpmIxnz901Lhsz1lSEaVXxS5hc/J8hayEu2pFC9KU4GSgFhK2XCeTu1cC43cnO3d3O0 9+q1M4OzCkv0HgchEBr3mtTkJcM8Yu+Rlf0janZF/ycRs1QfcqmolswlWscWrRqwK0VYh5To7234C eK+FuE468TIX6u0PuFNJuaqR8O7+HRqOdOB3mlZAUOh9fsFuYKM2k/G/ZaWd5oZjF4fuX50vxup5H cardMTxGP6ptmkBFuh19rr02o14XwBAhhHXR8k10S6XtNcpfKaI1FernIQFi0ICmLgU2JTml9YMUL 5gMaUWx3g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOvyZ-0004PG-IB; Sun, 04 Oct 2020 04:50:23 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOvyX-0004Ox-Cp for linux-arm-kernel@merlin.infradead.org; Sun, 04 Oct 2020 04:50:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ShausBGebfFRLyt2+59SVmhWPvWC+7ycryEAzaFpAdQ=; b=FliDVEEnzXdQqpxUiqA0sWTEzM 6chFGqQ0kV6OxMIZSrf/RceFVTuWcw05HjewzzF74MQVyvZOkuItmPGMJSNZGx9pPHsvLQjE6x4f4 WV+sihD+P5HxxraEevVlSj2VJFYNP9okNo3wXYDd8HFCpakjkIYYWyt9WKh5Rjb3RZBdd77964ury o3P9s0fNgc5e/dMGfcn5xtd02aXtQsTNebjEuOfctGHhfTC1DNVGWYHBjZuHeNVwy8o70qajV1px4 zc7RP6bRhEt1Ms9/vcvVJCITEcvDPky4aipKQZZuxnLPFUepLchbNWaiL+PaDn3jB+XXHrLCpp7nE W5Iyd4mg==; Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOmik-0000Ky-SK for linux-arm-kernel@lists.infradead.org; Sat, 03 Oct 2020 18:57:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ShausBGebfFRLyt2+59SVmhWPvWC+7ycryEAzaFpAdQ=; b=cH+yk6WLMuSPIN5kWWeSQTvlT l2Z0ZNAZ5OIrVkLPmTqd+R/nVPaHOZ1zzn+eHcZv4mBgx5a3B4FigpSSx2T8ME3/s73TUqP6QII2p EkbmmbQGbgt87G5dGTbf3Z73xH6V0I+P5RTFdFZrBSJQbBUf3RFIEaQzNWPP9rwTUBb53u7w4/v9C qsuCuqIFadfCEorxIt0qQyH+RDh4L3ltVUZdDmzLTPenYavGgRb8GqccCLFZRJd3pM/4hNRwKq+Su pTgScjww1idpdw0tvAhQYnltbEWmc60qfcXq74pOh55+EuZwn/VaEjzP3xCZ9hy43ttcCRq4KcvIK 8Vf9UmpdQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41526) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kOmfW-0007o9-Nk; Sat, 03 Oct 2020 19:54:06 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kOmfU-0005MD-UA; Sat, 03 Oct 2020 19:54:04 +0100 Date: Sat, 3 Oct 2020 19:54:04 +0100 From: Russell King - ARM Linux admin To: Codrin Ciubotariu Subject: Re: [PATCH] i2c: pxa: move to generic GPIO recovery Message-ID: <20201003185404.GH1551@shell.armlinux.org.uk> References: <20201003162141.925518-1-codrin.ciubotariu@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201003162141.925518-1-codrin.ciubotariu@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201003_195727_157403_F39980C2 X-CRM114-Status: GOOD ( 21.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wsa@kernel.org, alpawi@amazon.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 03, 2020 at 07:21:41PM +0300, Codrin Ciubotariu wrote: > Starting with > commit 75820314de26 ("i2c: core: add generic I2C GPIO recovery") > GPIO bus recovery is supported by the I2C core, so we can remove the > driver implementation and use that one instead. > > Signed-off-by: Codrin Ciubotariu > --- > > This patch is not tested. > The only different thing should be the fact that the pinctl state is > now switched back to the default state after the bus is enabled. > > drivers/i2c/busses/i2c-pxa.c | 75 +++--------------------------------- > 1 file changed, 6 insertions(+), 69 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c > index 35ca2c02c9b9..dd357b6e6c61 100644 > --- a/drivers/i2c/busses/i2c-pxa.c > +++ b/drivers/i2c/busses/i2c-pxa.c > @@ -264,9 +264,6 @@ struct pxa_i2c { > u32 hs_mask; > > struct i2c_bus_recovery_info recovery; > - struct pinctrl *pinctrl; > - struct pinctrl_state *pinctrl_default; > - struct pinctrl_state *pinctrl_recovery; > }; > > #define _IBMR(i2c) ((i2c)->reg_ibmr) > @@ -1305,8 +1302,6 @@ static void i2c_pxa_prepare_recovery(struct i2c_adapter *adap) > */ > gpiod_set_value(i2c->recovery.scl_gpiod, ibmr & IBMR_SCLS); > gpiod_set_value(i2c->recovery.sda_gpiod, ibmr & IBMR_SDAS); > - > - WARN_ON(pinctrl_select_state(i2c->pinctrl, i2c->pinctrl_recovery)); > } > > static void i2c_pxa_unprepare_recovery(struct i2c_adapter *adap) > @@ -1325,8 +1320,6 @@ static void i2c_pxa_unprepare_recovery(struct i2c_adapter *adap) > i2c_pxa_do_reset(i2c); > } > > - WARN_ON(pinctrl_select_state(i2c->pinctrl, i2c->pinctrl_default)); > - This won't fly. We need to put the pinctrl back into i2c mode _before_ we re-enable the I2C module, otherwise the I2C block will see logic 0 on both SCL and SDA which could confuse the block. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel