All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/iommu/intel/irq_remapping.c:674 iommu_disable_irq_remapping() warn: this loop depends on readl() succeeding
@ 2020-10-03 21:00 kernel test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2020-10-03 21:00 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 5200 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Joerg Roedel <jroedel@suse.de>
CC: Jerry Snitselaar <jsnitsel@redhat.com>
CC: Lu Baolu <baolu.lu@linux.intel.com>

Hi Joerg,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   d3d45f8220d60a0b2aaaacf8fb2be4e6ffd9008e
commit: 672cf6df9b8a3a6d70a6a5c30397f76fa40d3178 iommu/vt-d: Move Intel IOMMU driver into subdirectory
date:   4 months ago
:::::: branch date: 23 hours ago
:::::: commit date: 4 months ago
config: x86_64-randconfig-m001-20201003 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/iommu/intel/irq_remapping.c:674 iommu_disable_irq_remapping() warn: this loop depends on readl() succeeding
drivers/iommu/intel/irq_remapping.c:674 iommu_disable_irq_remapping() warn: this loop depends on readl() succeeding

vim +674 drivers/iommu/intel/irq_remapping.c

2ae21010694e564 drivers/pci/intr_remapping.c         Suresh Siddha   2008-07-10  647  
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  648  /*
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  649   * Disable Interrupt Remapping.
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  650   */
95a02e976c39d63 drivers/iommu/intel_intr_remapping.c Suresh Siddha   2012-03-30  651  static void iommu_disable_irq_remapping(struct intel_iommu *iommu)
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  652  {
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  653  	unsigned long flags;
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  654  	u32 sts;
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  655  
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  656  	if (!ecap_ir_support(iommu->ecap))
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  657  		return;
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  658  
b24696bc55f66fe drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  659  	/*
b24696bc55f66fe drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  660  	 * global invalidation of interrupt entry cache before disabling
b24696bc55f66fe drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  661  	 * interrupt-remapping.
b24696bc55f66fe drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  662  	 */
b24696bc55f66fe drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  663  	qi_global_iec(iommu);
b24696bc55f66fe drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  664  
1f5b3c3fd2d73d6 drivers/iommu/intr_remapping.c       Thomas Gleixner 2011-07-19  665  	raw_spin_lock_irqsave(&iommu->register_lock, flags);
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  666  
fda3bec12d0979a drivers/iommu/intel_irq_remapping.c  CQ Tang         2016-01-13  667  	sts = readl(iommu->reg + DMAR_GSTS_REG);
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  668  	if (!(sts & DMA_GSTS_IRES))
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  669  		goto end;
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  670  
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  671  	iommu->gcmd &= ~DMA_GCMD_IRE;
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  672  	writel(iommu->gcmd, iommu->reg + DMAR_GCMD_REG);
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  673  
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16 @674  	IOMMU_WAIT_OP(iommu, DMAR_GSTS_REG,
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  675  		      readl, !(sts & DMA_GSTS_IRES), sts);
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  676  
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  677  end:
1f5b3c3fd2d73d6 drivers/iommu/intr_remapping.c       Thomas Gleixner 2011-07-19  678  	raw_spin_unlock_irqrestore(&iommu->register_lock, flags);
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  679  }
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  680  

:::::: The code at line 674 was first introduced by commit
:::::: eba67e5da6e971993b2899d2cdf459ce77d3dbc5 x86, dmar: routines for disabling queued invalidation and intr remapping

:::::: TO: Suresh Siddha <suresh.b.siddha@intel.com>
:::::: CC: H. Peter Anvin <hpa@linux.intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30373 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* drivers/iommu/intel/irq_remapping.c:674 iommu_disable_irq_remapping() warn: this loop depends on readl() succeeding
@ 2020-11-09 16:40 kernel test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2020-11-09 16:40 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 5200 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Joerg Roedel <jroedel@suse.de>
CC: Jerry Snitselaar <jsnitsel@redhat.com>
CC: Lu Baolu <baolu.lu@linux.intel.com>

Hi Joerg,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   f8394f232b1eab649ce2df5c5f15b0e528c92091
commit: 672cf6df9b8a3a6d70a6a5c30397f76fa40d3178 iommu/vt-d: Move Intel IOMMU driver into subdirectory
date:   5 months ago
:::::: branch date: 17 hours ago
:::::: commit date: 5 months ago
config: x86_64-randconfig-m001-20201109 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/iommu/intel/irq_remapping.c:674 iommu_disable_irq_remapping() warn: this loop depends on readl() succeeding
drivers/iommu/intel/irq_remapping.c:674 iommu_disable_irq_remapping() warn: this loop depends on readl() succeeding

vim +674 drivers/iommu/intel/irq_remapping.c

2ae21010694e564 drivers/pci/intr_remapping.c         Suresh Siddha   2008-07-10  647  
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  648  /*
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  649   * Disable Interrupt Remapping.
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  650   */
95a02e976c39d63 drivers/iommu/intel_intr_remapping.c Suresh Siddha   2012-03-30  651  static void iommu_disable_irq_remapping(struct intel_iommu *iommu)
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  652  {
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  653  	unsigned long flags;
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  654  	u32 sts;
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  655  
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  656  	if (!ecap_ir_support(iommu->ecap))
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  657  		return;
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  658  
b24696bc55f66fe drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  659  	/*
b24696bc55f66fe drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  660  	 * global invalidation of interrupt entry cache before disabling
b24696bc55f66fe drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  661  	 * interrupt-remapping.
b24696bc55f66fe drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  662  	 */
b24696bc55f66fe drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  663  	qi_global_iec(iommu);
b24696bc55f66fe drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  664  
1f5b3c3fd2d73d6 drivers/iommu/intr_remapping.c       Thomas Gleixner 2011-07-19  665  	raw_spin_lock_irqsave(&iommu->register_lock, flags);
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  666  
fda3bec12d0979a drivers/iommu/intel_irq_remapping.c  CQ Tang         2016-01-13  667  	sts = readl(iommu->reg + DMAR_GSTS_REG);
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  668  	if (!(sts & DMA_GSTS_IRES))
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  669  		goto end;
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  670  
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  671  	iommu->gcmd &= ~DMA_GCMD_IRE;
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  672  	writel(iommu->gcmd, iommu->reg + DMAR_GCMD_REG);
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  673  
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16 @674  	IOMMU_WAIT_OP(iommu, DMAR_GSTS_REG,
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  675  		      readl, !(sts & DMA_GSTS_IRES), sts);
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  676  
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  677  end:
1f5b3c3fd2d73d6 drivers/iommu/intr_remapping.c       Thomas Gleixner 2011-07-19  678  	raw_spin_unlock_irqrestore(&iommu->register_lock, flags);
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  679  }
eba67e5da6e9719 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  680  

:::::: The code at line 674 was first introduced by commit
:::::: eba67e5da6e971993b2899d2cdf459ce77d3dbc5 x86, dmar: routines for disabling queued invalidation and intr remapping

:::::: TO: Suresh Siddha <suresh.b.siddha@intel.com>
:::::: CC: H. Peter Anvin <hpa@linux.intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 45890 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* drivers/iommu/intel/irq_remapping.c:674 iommu_disable_irq_remapping() warn: this loop depends on readl() succeeding
@ 2020-07-12  8:53 kernel test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2020-07-12  8:53 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 5455 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Joerg Roedel <jroedel@suse.de>
CC: Jerry Snitselaar <jsnitsel@redhat.com>
CC: Lu Baolu <baolu.lu@linux.intel.com>

Hi Joerg,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   0aea6d5c5be33ce94c16f9ab2f64de1f481f424b
commit: 672cf6df9b8a3a6d70a6a5c30397f76fa40d3178 iommu/vt-d: Move Intel IOMMU driver into subdirectory
date:   5 weeks ago
:::::: branch date: 15 hours ago
:::::: commit date: 5 weeks ago
config: x86_64-randconfig-m001-20200712 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/iommu/intel/irq_remapping.c:674 iommu_disable_irq_remapping() warn: this loop depends on readl() succeeding
drivers/iommu/intel/irq_remapping.c:674 iommu_disable_irq_remapping() warn: this loop depends on readl() succeeding

# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=672cf6df9b8a3a6d70a6a5c30397f76fa40d3178
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 672cf6df9b8a3a6d70a6a5c30397f76fa40d3178
vim +674 drivers/iommu/intel/irq_remapping.c

2ae21010694e56 drivers/pci/intr_remapping.c         Suresh Siddha   2008-07-10  647  
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  648  /*
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  649   * Disable Interrupt Remapping.
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  650   */
95a02e976c39d6 drivers/iommu/intel_intr_remapping.c Suresh Siddha   2012-03-30  651  static void iommu_disable_irq_remapping(struct intel_iommu *iommu)
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  652  {
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  653  	unsigned long flags;
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  654  	u32 sts;
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  655  
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  656  	if (!ecap_ir_support(iommu->ecap))
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  657  		return;
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  658  
b24696bc55f66f drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  659  	/*
b24696bc55f66f drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  660  	 * global invalidation of interrupt entry cache before disabling
b24696bc55f66f drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  661  	 * interrupt-remapping.
b24696bc55f66f drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  662  	 */
b24696bc55f66f drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  663  	qi_global_iec(iommu);
b24696bc55f66f drivers/pci/intr_remapping.c         Fenghua Yu      2009-03-27  664  
1f5b3c3fd2d73d drivers/iommu/intr_remapping.c       Thomas Gleixner 2011-07-19  665  	raw_spin_lock_irqsave(&iommu->register_lock, flags);
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  666  
fda3bec12d0979 drivers/iommu/intel_irq_remapping.c  CQ Tang         2016-01-13  667  	sts = readl(iommu->reg + DMAR_GSTS_REG);
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  668  	if (!(sts & DMA_GSTS_IRES))
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  669  		goto end;
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  670  
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  671  	iommu->gcmd &= ~DMA_GCMD_IRE;
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  672  	writel(iommu->gcmd, iommu->reg + DMAR_GCMD_REG);
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  673  
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16 @674  	IOMMU_WAIT_OP(iommu, DMAR_GSTS_REG,
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  675  		      readl, !(sts & DMA_GSTS_IRES), sts);
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  676  
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  677  end:
1f5b3c3fd2d73d drivers/iommu/intr_remapping.c       Thomas Gleixner 2011-07-19  678  	raw_spin_unlock_irqrestore(&iommu->register_lock, flags);
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  679  }
eba67e5da6e971 drivers/pci/intr_remapping.c         Suresh Siddha   2009-03-16  680  

:::::: The code at line 674 was first introduced by commit
:::::: eba67e5da6e971993b2899d2cdf459ce77d3dbc5 x86, dmar: routines for disabling queued invalidation and intr remapping

:::::: TO: Suresh Siddha <suresh.b.siddha@intel.com>
:::::: CC: H. Peter Anvin <hpa@linux.intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30706 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-09 16:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-03 21:00 drivers/iommu/intel/irq_remapping.c:674 iommu_disable_irq_remapping() warn: this loop depends on readl() succeeding kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2020-11-09 16:40 kernel test robot
2020-07-12  8:53 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.