From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 146D8C4363D for ; Sun, 4 Oct 2020 05:14:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D566B2068E for ; Sun, 4 Oct 2020 05:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601788492; bh=AsKTRzAwkmddsVavqONAy1hHnQJpLDioOse3Fz5ZJEY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tRIMQlDSRAlUduTKuTK1bVWlWJVrJQ7DalfoN4wZetXN/tMk3eEDUyJz7gcwyDz2O LZSnkZdzNbU2bWWnLIDGESctGmnDgnN1BlcMnKVZB8GcAktbq8R9oZY6h5knOxnWU1 jJHuHP/+aaRIa1S22ZZqKC2k41GX2jnkjTkvMWQg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725865AbgJDFOv (ORCPT ); Sun, 4 Oct 2020 01:14:51 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:37264 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725849AbgJDFOu (ORCPT ); Sun, 4 Oct 2020 01:14:50 -0400 Received: by mail-pj1-f65.google.com with SMTP id kk9so3344193pjb.2; Sat, 03 Oct 2020 22:14:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d2zKZStKzcWmg98lvUeSyfN/9/+uQar1D5BGHJR0sMs=; b=gjuzUyLwvSD3mI/tKm8fbjY0d1z3jrg28sseZYMHEOzkCnk13Iy4wY17ctE5MeDlZy KjEKbtG5exD+J9084vzcRzDoe8d0Cez68UWvJCIctmY4Z7zJz6BpCs1k2LVeHrNEMDLS /mJ1hY53qT+5xbeXLJvaOVpFUfLmJiX9HzpYko5tWwKiQko+MLnn9h8/Cw5Mr+1Lpbti b0xpUR4KdBDR+haxKa9dB35XR9DO7vXkCKFXh9zZTts1MNX7epjOAtQ95LcigTte7pIG tt4yghl6/7VSIdIlzad6EY4m4Vi9cUO3xqgMqq760KOKuEsaxTlixCIHFhlkJvOtNqic E/dQ== X-Gm-Message-State: AOAM531Jx30NRKYj3zlGflx41eMuhdLSY4MTsKSfmSwZWEZdudk9iNr4 YLuhpjArBJYrH3FyLzq5zwh9kGGmL8w= X-Google-Smtp-Source: ABdhPJxRYQRBkbg0GgZNWMM1nKDMiId/ovDb91fIRnSMkHNx4u7R6Ja/V7HikZ8TKKvNf6zwxSf1Eg== X-Received: by 2002:a17:90a:e545:: with SMTP id ei5mr10050838pjb.45.1601788489550; Sat, 03 Oct 2020 22:14:49 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id i17sm7445294pfa.29.2020.10.03.22.14.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Oct 2020 22:14:49 -0700 (PDT) From: Moritz Fischer To: linux-fpga@vger.kernel.org Cc: trix@redhat.com, hao.wu@intel.com, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, russell.h.weight@intel.com, matthew.gerlach@intel.com, Moritz Fischer Subject: [PATCH 02/10] fpga: fpga-mgr: altera-ps-spi: Simplify registration Date: Sat, 3 Oct 2020 22:14:15 -0700 Message-Id: <20201004051423.75879-3-mdf@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201004051423.75879-1-mdf@kernel.org> References: <20201004051423.75879-1-mdf@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Simplify registration by using new devm_fpga_mgr_register() API. Signed-off-by: Moritz Fischer --- drivers/fpga/altera-ps-spi.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c index 0221dee8dd4c..23bfd4d1ad0f 100644 --- a/drivers/fpga/altera-ps-spi.c +++ b/drivers/fpga/altera-ps-spi.c @@ -307,18 +307,7 @@ static int altera_ps_probe(struct spi_device *spi) if (!mgr) return -ENOMEM; - spi_set_drvdata(spi, mgr); - - return fpga_mgr_register(mgr); -} - -static int altera_ps_remove(struct spi_device *spi) -{ - struct fpga_manager *mgr = spi_get_drvdata(spi); - - fpga_mgr_unregister(mgr); - - return 0; + return devm_fpga_mgr_register(&spi->dev, mgr); } static const struct spi_device_id altera_ps_spi_ids[] = { @@ -337,7 +326,6 @@ static struct spi_driver altera_ps_driver = { }, .id_table = altera_ps_spi_ids, .probe = altera_ps_probe, - .remove = altera_ps_remove, }; module_spi_driver(altera_ps_driver) -- 2.28.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95AE7C4727E for ; Sun, 4 Oct 2020 05:16:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B5672067C for ; Sun, 4 Oct 2020 05:16:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r94Aw6u6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B5672067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D0TLsLAxU9HwEeVJAtgqPpdAwJ4pzUaXy6ScZdl0zfc=; b=r94Aw6u6UzfM7TTchTb71JqDC ltdd2CGPCv2Qq3CxeWkVvJROxTKG+4GSBy/tKb44If9eUHfnihTwPpdjZ3pP+IcTuLuRhV1mYZeQy 2SiO67dGdQqZ5n3pyDTpnJo0CwKg1Gsj16wEuBnCSmgSvHlpAwcdAxwNTl3U0Mhb/GE5xTH+NW6Oy mpVII8yva2HOww20xdLsDNSc82HIHHy4ETaELNJIZ4gof9KI0xLDuySZeJ2WBmqrpjXGj3GiK1iTe jvt6efkW1v0JavXxW4H+8+bz/Piaaj46c72Tts8OAkk8IyzSdPp1naasv5UtfoI+wqM7XXRmJ2azZ TkoAbjT0A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOwMI-0007EL-QU; Sun, 04 Oct 2020 05:14:54 +0000 Received: from mail-pj1-f66.google.com ([209.85.216.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOwMF-0007Ce-Q0 for linux-arm-kernel@lists.infradead.org; Sun, 04 Oct 2020 05:14:52 +0000 Received: by mail-pj1-f66.google.com with SMTP id gm14so3572808pjb.2 for ; Sat, 03 Oct 2020 22:14:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d2zKZStKzcWmg98lvUeSyfN/9/+uQar1D5BGHJR0sMs=; b=qUl1a3OKVgs99p1zwzaJz3hZNHf73cCQbTmN6HevhWZ3h9ib88GrPmgRtD4TcGYNXp OmLIaTgRDw05MH9TRt1ewmTYWpKv4OtPXDwP4cAeJ8+VrevWfKVUFllqFmfnBTIAkoNK Dm7K+z/tmZ1FtS4UAYtBAxJurUGcz4YyuqIQfac9ZbU6efyPwYGqD7ER6X6JUArkgxVM Oug6Y26IBufyNBh5fFygH91Qk7/YM3584bRg6sbXXbJT3xRKzFAUX/9HA4lOIAbgHSuh zjdDocGh7Ti/qXKmuDD1bF3TcXRwx98Iwfsv/GlFTzDapnxvdgxhVJ2K+EoInqsvUwS1 G1Wg== X-Gm-Message-State: AOAM530C8tqrcjlik4UWtG63LegkHBGm3tuAAI9dTrRFH/eUNE49P++b mHGvHr6JS9avkVdjeK4eNJc= X-Google-Smtp-Source: ABdhPJxRYQRBkbg0GgZNWMM1nKDMiId/ovDb91fIRnSMkHNx4u7R6Ja/V7HikZ8TKKvNf6zwxSf1Eg== X-Received: by 2002:a17:90a:e545:: with SMTP id ei5mr10050838pjb.45.1601788489550; Sat, 03 Oct 2020 22:14:49 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id i17sm7445294pfa.29.2020.10.03.22.14.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Oct 2020 22:14:49 -0700 (PDT) From: Moritz Fischer To: linux-fpga@vger.kernel.org Subject: [PATCH 02/10] fpga: fpga-mgr: altera-ps-spi: Simplify registration Date: Sat, 3 Oct 2020 22:14:15 -0700 Message-Id: <20201004051423.75879-3-mdf@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201004051423.75879-1-mdf@kernel.org> References: <20201004051423.75879-1-mdf@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201004_011451_842349_17813EAB X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: russell.h.weight@intel.com, trix@redhat.com, michal.simek@xilinx.com, matthew.gerlach@intel.com, linux-kernel@vger.kernel.org, Moritz Fischer , linux-arm-kernel@lists.infradead.org, hao.wu@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Simplify registration by using new devm_fpga_mgr_register() API. Signed-off-by: Moritz Fischer --- drivers/fpga/altera-ps-spi.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c index 0221dee8dd4c..23bfd4d1ad0f 100644 --- a/drivers/fpga/altera-ps-spi.c +++ b/drivers/fpga/altera-ps-spi.c @@ -307,18 +307,7 @@ static int altera_ps_probe(struct spi_device *spi) if (!mgr) return -ENOMEM; - spi_set_drvdata(spi, mgr); - - return fpga_mgr_register(mgr); -} - -static int altera_ps_remove(struct spi_device *spi) -{ - struct fpga_manager *mgr = spi_get_drvdata(spi); - - fpga_mgr_unregister(mgr); - - return 0; + return devm_fpga_mgr_register(&spi->dev, mgr); } static const struct spi_device_id altera_ps_spi_ids[] = { @@ -337,7 +326,6 @@ static struct spi_driver altera_ps_driver = { }, .id_table = altera_ps_spi_ids, .probe = altera_ps_probe, - .remove = altera_ps_remove, }; module_spi_driver(altera_ps_driver) -- 2.28.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel