From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, jmondi@jmondi.org
Subject: Re: [PATCH 1/5] adv748x: Zero entire struct v4l2_fwnode_endpoint
Date: Sun, 4 Oct 2020 11:31:15 +0300 [thread overview]
Message-ID: <20201004083115.GB3938@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200930144811.16612-2-sakari.ailus@linux.intel.com>
Hi Sakari,
Thank you for the patch.
On Wed, Sep 30, 2020 at 05:48:07PM +0300, Sakari Ailus wrote:
> The v4l2_fwnode_parse_endpoint() function can make use of defaults in
> multiple bus types. To use this feature, all callers must zero the rest of
> the fields of this struct, too. All other drivers appear to do that
> already apart from this one.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/adv748x/adv748x-core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c
> index 1fe7f97c6d52..ae8b7ebf3830 100644
> --- a/drivers/media/i2c/adv748x/adv748x-core.c
> +++ b/drivers/media/i2c/adv748x/adv748x-core.c
> @@ -589,14 +589,13 @@ static int adv748x_parse_csi2_lanes(struct adv748x_state *state,
> unsigned int port,
> struct device_node *ep)
> {
> - struct v4l2_fwnode_endpoint vep;
> + struct v4l2_fwnode_endpoint vep = { .bus_type = V4L2_MBUS_CSI2_DPHY };
> unsigned int num_lanes;
> int ret;
>
> if (port != ADV748X_PORT_TXA && port != ADV748X_PORT_TXB)
> return 0;
>
> - vep.bus_type = V4L2_MBUS_CSI2_DPHY;
> ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(ep), &vep);
> if (ret)
> return ret;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-10-04 8:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 14:48 [PATCH 0/5] V4L2 fwnode fixes, improvements and cleanups Sakari Ailus
2020-09-30 14:48 ` [PATCH 1/5] adv748x: Zero entire struct v4l2_fwnode_endpoint Sakari Ailus
2020-10-02 15:48 ` Niklas Söderlund
2020-10-04 8:31 ` Laurent Pinchart [this message]
2020-09-30 14:48 ` [PATCH 2/5] v4l2-fwnode: v4l2_fwnode_endpoint_parse caller must init vep argument Sakari Ailus
2020-10-02 15:53 ` Niklas Söderlund
2020-10-02 21:01 ` Sakari Ailus
2020-10-04 8:35 ` Laurent Pinchart
2020-09-30 14:48 ` [PATCH 3/5] v4l2-fwnode: Don't zero parts of struct v4l2_fwnode_endpoint anymore Sakari Ailus
2020-10-02 17:42 ` Niklas Söderlund
2020-10-04 8:36 ` Laurent Pinchart
2020-09-30 14:48 ` [PATCH 4/5] v4l2-fwnode: Rework v4l2_fwnode_endpoint_parse documentation Sakari Ailus
2020-10-02 17:21 ` Niklas Söderlund
2020-10-04 8:40 ` Laurent Pinchart
2020-10-05 6:53 ` Sakari Ailus
2020-09-30 14:48 ` [PATCH 5/5] v4l2-fwnode: Say it's fine to use v4l2_fwnode_endpoint_parse Sakari Ailus
2020-10-02 17:22 ` Niklas Söderlund
2020-10-04 8:41 ` Laurent Pinchart
2020-10-05 6:55 ` Sakari Ailus
2020-10-05 7:46 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201004083115.GB3938@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=jmondi@jmondi.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.