All of lore.kernel.org
 help / color / mirror / Atom feed
* fs/overlayfs/util.c:479 ovl_path_open() error: uninitialized symbol 'acc_mode'.
@ 2020-10-04  2:59 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-10-04  2:59 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 3039 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Miklos Szeredi <mszeredi@redhat.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   22fbc037cd32e4e6771d2271b565806cfb8c134c
commit: 56230d956739b9cb1cbde439d76227d77979a04d ovl: verify permissions in ovl_path_open()
date:   4 months ago
:::::: branch date: 8 hours ago
:::::: commit date: 4 months ago
config: ia64-randconfig-m031-20201004 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
fs/overlayfs/util.c:479 ovl_path_open() error: uninitialized symbol 'acc_mode'.

vim +/acc_mode +479 fs/overlayfs/util.c

bbb1e54dd53cf8 Miklos Szeredi 2016-12-16  459  
bbb1e54dd53cf8 Miklos Szeredi 2016-12-16  460  struct file *ovl_path_open(struct path *path, int flags)
bbb1e54dd53cf8 Miklos Szeredi 2016-12-16  461  {
56230d956739b9 Miklos Szeredi 2020-06-02  462  	struct inode *inode = d_inode(path->dentry);
56230d956739b9 Miklos Szeredi 2020-06-02  463  	int err, acc_mode;
56230d956739b9 Miklos Szeredi 2020-06-02  464  
56230d956739b9 Miklos Szeredi 2020-06-02  465  	if (flags & ~(O_ACCMODE | O_LARGEFILE))
56230d956739b9 Miklos Szeredi 2020-06-02  466  		BUG();
56230d956739b9 Miklos Szeredi 2020-06-02  467  
56230d956739b9 Miklos Szeredi 2020-06-02  468  	switch (flags & O_ACCMODE) {
56230d956739b9 Miklos Szeredi 2020-06-02  469  	case O_RDONLY:
56230d956739b9 Miklos Szeredi 2020-06-02  470  		acc_mode = MAY_READ;
56230d956739b9 Miklos Szeredi 2020-06-02  471  		break;
56230d956739b9 Miklos Szeredi 2020-06-02  472  	case O_WRONLY:
56230d956739b9 Miklos Szeredi 2020-06-02  473  		acc_mode = MAY_WRITE;
56230d956739b9 Miklos Szeredi 2020-06-02  474  		break;
56230d956739b9 Miklos Szeredi 2020-06-02  475  	default:
56230d956739b9 Miklos Szeredi 2020-06-02  476  		BUG();
56230d956739b9 Miklos Szeredi 2020-06-02  477  	}
56230d956739b9 Miklos Szeredi 2020-06-02  478  
56230d956739b9 Miklos Szeredi 2020-06-02 @479  	err = inode_permission(inode, acc_mode | MAY_OPEN);
56230d956739b9 Miklos Szeredi 2020-06-02  480  	if (err)
56230d956739b9 Miklos Szeredi 2020-06-02  481  		return ERR_PTR(err);
56230d956739b9 Miklos Szeredi 2020-06-02  482  
56230d956739b9 Miklos Szeredi 2020-06-02  483  	/* O_NOATIME is an optimization, don't fail if not permitted */
56230d956739b9 Miklos Szeredi 2020-06-02  484  	if (inode_owner_or_capable(inode))
56230d956739b9 Miklos Szeredi 2020-06-02  485  		flags |= O_NOATIME;
56230d956739b9 Miklos Szeredi 2020-06-02  486  
56230d956739b9 Miklos Szeredi 2020-06-02  487  	return dentry_open(path, flags, current_cred());
bbb1e54dd53cf8 Miklos Szeredi 2016-12-16  488  }
39d3d60a54df05 Amir Goldstein 2017-01-17  489  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 23241 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
* fs/overlayfs/util.c:479 ovl_path_open() error: uninitialized symbol 'acc_mode'.
@ 2021-04-22 20:03 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-04-22 20:03 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 3042 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Miklos Szeredi <mszeredi@redhat.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   16fc44d6387e260f4932e9248b985837324705d8
commit: 56230d956739b9cb1cbde439d76227d77979a04d ovl: verify permissions in ovl_path_open()
date:   11 months ago
:::::: branch date: 27 hours ago
:::::: commit date: 11 months ago
config: ia64-randconfig-m031-20210422 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
fs/overlayfs/util.c:479 ovl_path_open() error: uninitialized symbol 'acc_mode'.

vim +/acc_mode +479 fs/overlayfs/util.c

bbb1e54dd53cf8 Miklos Szeredi 2016-12-16  459  
bbb1e54dd53cf8 Miklos Szeredi 2016-12-16  460  struct file *ovl_path_open(struct path *path, int flags)
bbb1e54dd53cf8 Miklos Szeredi 2016-12-16  461  {
56230d956739b9 Miklos Szeredi 2020-06-02  462  	struct inode *inode = d_inode(path->dentry);
56230d956739b9 Miklos Szeredi 2020-06-02  463  	int err, acc_mode;
56230d956739b9 Miklos Szeredi 2020-06-02  464  
56230d956739b9 Miklos Szeredi 2020-06-02  465  	if (flags & ~(O_ACCMODE | O_LARGEFILE))
56230d956739b9 Miklos Szeredi 2020-06-02  466  		BUG();
56230d956739b9 Miklos Szeredi 2020-06-02  467  
56230d956739b9 Miklos Szeredi 2020-06-02  468  	switch (flags & O_ACCMODE) {
56230d956739b9 Miklos Szeredi 2020-06-02  469  	case O_RDONLY:
56230d956739b9 Miklos Szeredi 2020-06-02  470  		acc_mode = MAY_READ;
56230d956739b9 Miklos Szeredi 2020-06-02  471  		break;
56230d956739b9 Miklos Szeredi 2020-06-02  472  	case O_WRONLY:
56230d956739b9 Miklos Szeredi 2020-06-02  473  		acc_mode = MAY_WRITE;
56230d956739b9 Miklos Szeredi 2020-06-02  474  		break;
56230d956739b9 Miklos Szeredi 2020-06-02  475  	default:
56230d956739b9 Miklos Szeredi 2020-06-02  476  		BUG();
56230d956739b9 Miklos Szeredi 2020-06-02  477  	}
56230d956739b9 Miklos Szeredi 2020-06-02  478  
56230d956739b9 Miklos Szeredi 2020-06-02 @479  	err = inode_permission(inode, acc_mode | MAY_OPEN);
56230d956739b9 Miklos Szeredi 2020-06-02  480  	if (err)
56230d956739b9 Miklos Szeredi 2020-06-02  481  		return ERR_PTR(err);
56230d956739b9 Miklos Szeredi 2020-06-02  482  
56230d956739b9 Miklos Szeredi 2020-06-02  483  	/* O_NOATIME is an optimization, don't fail if not permitted */
56230d956739b9 Miklos Szeredi 2020-06-02  484  	if (inode_owner_or_capable(inode))
56230d956739b9 Miklos Szeredi 2020-06-02  485  		flags |= O_NOATIME;
56230d956739b9 Miklos Szeredi 2020-06-02  486  
56230d956739b9 Miklos Szeredi 2020-06-02  487  	return dentry_open(path, flags, current_cred());
bbb1e54dd53cf8 Miklos Szeredi 2016-12-16  488  }
39d3d60a54df05 Amir Goldstein 2017-01-17  489  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26010 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-22 20:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-04  2:59 fs/overlayfs/util.c:479 ovl_path_open() error: uninitialized symbol 'acc_mode' kernel test robot
2021-04-22 20:03 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.