All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bastien Nocera <hadess@hadess.net>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Sathish Narsimman <sathish.narasimman@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-bluetooth <linux-bluetooth@vger.kernel.org>,
	"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"
Date: Sun, 4 Oct 2020 15:18:44 +0200	[thread overview]
Message-ID: <20201004131844.GA185109@kroah.com> (raw)
In-Reply-To: <04e0af8618f95a4483f5a72ba90d4f8b1d9094bd.camel@hadess.net>

On Sun, Oct 04, 2020 at 02:17:06PM +0200, Bastien Nocera wrote:
> On Sun, 2020-10-04 at 12:51 +0200, Greg Kroah-Hartman wrote:
> > On Sat, Oct 03, 2020 at 08:33:18PM +0200, Marcel Holtmann wrote:
> > > Hi Greg,
> > > 
> > > > > > This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2
> > > > > > as it
> > > > > > breaks all bluetooth connections on my machine.
> > > > > > 
> > > > > > Cc: Marcel Holtmann <marcel@holtmann.org>
> > > > > > Cc: Sathish Narsimman <sathish.narasimman@intel.com>
> > > > > > Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list when
> > > > > > updating whitelist")
> > > > > > Signed-off-by: Greg Kroah-Hartman
> > > > > > <gregkh@linuxfoundation.org>
> > > > > > ---
> > > > > > net/bluetooth/hci_request.c | 41 ++--------------------------
> > > > > > ---------
> > > > > > 1 file changed, 2 insertions(+), 39 deletions(-)
> > > > > > 
> > > > > > This has been bugging me for since 5.9-rc1, when all
> > > > > > bluetooth devices
> > > > > > stopped working on my desktop system.  I finally got the time
> > > > > > to do
> > > > > > bisection today, and it came down to this patch.  Reverting
> > > > > > it on top of
> > > > > > 5.9-rc7 restored bluetooth devices and now my input devices
> > > > > > properly
> > > > > > work.
> > > > > > 
> > > > > > As it's almost 5.9-final, any chance this can be merged now
> > > > > > to fix the
> > > > > > issue?
> > > > > 
> > > > > can you be specific what breaks since our guys and I also think
> > > > > the
> > > > > ChromeOS guys have been testing these series of patches
> > > > > heavily.
> > > > 
> > > > My bluetooth trackball does not connect at all.  With this
> > > > reverted, it
> > > > all "just works".
> > > > 
> > > > Same I think for a Bluetooth headset, can check that again if you
> > > > really
> > > > need me to, but the trackball is reliable here.
> > > > 
> > > > > When you run btmon does it indicate any errors?
> > > > 
> > > > How do I run it and where are the errors displayed?
> > > 
> > > you can do btmon -w trace.log and just let it run like tcdpump.
> > 
> > Ok, attached.
> > 
> > The device is not connecting, and then I open the gnome bluetooth
> > dialog
> > and it scans for devices in the area, but does not connect to my
> > existing devices at all.
> > 
> > Any ideas?
> 
> Use bluetoothctl instead, the Bluetooth Settings from GNOME also run a
> discovery the whole time the panel is opened, and this breaks a fair
> number of poor quality adapters. This is worked-around in the most
> recent version, but using bluetoothctl is a better debugging option in
> all cases.

Ok, but how do I use that tool?  How do I shut down the gnome bluetooth
stuff?

I need newbie steps here please for what to run and what to show you.

thanks,

greg k-h

  reply	other threads:[~2020-10-04 13:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-03 13:54 [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist" Greg Kroah-Hartman
2020-10-03 15:51 ` Marcel Holtmann
2020-10-03 16:07   ` Greg Kroah-Hartman
2020-10-03 18:33     ` Marcel Holtmann
2020-10-04 10:51       ` Greg Kroah-Hartman
2020-10-04 10:53         ` Greg Kroah-Hartman
2020-10-04 12:17         ` Bastien Nocera
2020-10-04 13:18           ` Greg Kroah-Hartman [this message]
2020-10-04 13:23             ` Bastien Nocera
2020-10-05  8:29               ` Greg Kroah-Hartman
2020-10-04 16:59         ` Marcel Holtmann
2020-10-05  8:36           ` Greg Kroah-Hartman
2020-10-05 12:19             ` Marcel Holtmann
2020-10-05 12:40               ` Greg Kroah-Hartman
2020-10-05 15:44                 ` Marcel Holtmann
2020-10-05 16:11                   ` Greg Kroah-Hartman
2020-10-05 17:14                     ` Marcel Holtmann
2020-10-05 17:38                       ` Greg Kroah-Hartman
2020-10-05 18:02                         ` Greg Kroah-Hartman
2020-10-05 18:58                           ` Marcel Holtmann
2020-10-07 13:23                             ` Greg Kroah-Hartman
2020-10-07 13:40                               ` Greg Kroah-Hartman
2020-10-07 13:43                                 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201004131844.GA185109@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=davem@davemloft.net \
    --cc=hadess@hadess.net \
    --cc=johan.hedberg@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    --cc=sathish.narasimman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.