From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24FA1C4363C for ; Sun, 4 Oct 2020 23:39:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E141E206B6 for ; Sun, 4 Oct 2020 23:39:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601854760; bh=IijJLgM3NfA8suWseazFfLxtQ2XXpLtHB9NLoSLIkLg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=dEF7DkRgZZYCc5hLKm/nlR9AGjboUW+YLvyfL8Dx89a7simf05sUwmWoZp5vxnvOc S9hcu8XOoeLNOAYG1LVA/wOBBs6B+EvhJ+lR0godmvQc2DhLbzJxh81zsTMk6sswq5 p9l+8rJncQauGqJxcv3m8iE9s+pnlNrQ3Y6MZz/M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725860AbgJDXjT (ORCPT ); Sun, 4 Oct 2020 19:39:19 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:46928 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbgJDXjS (ORCPT ); Sun, 4 Oct 2020 19:39:18 -0400 Received: by mail-pf1-f195.google.com with SMTP id y14so2224255pfp.13; Sun, 04 Oct 2020 16:39:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=i0z6tvnBKutMrc8NANVNxZ4vgDVqspXt5PjdV91Nld0=; b=cghaDKIoCmc+tCUrZw5Pd5l7U1JlJghddEikRKw3N9SXlhWBsUITbQTt7XubxVGYeD 2wcssyKBUpjGiy/gZb/TF4qKh+qx1CTrdzbUVBR44bU4abDMCnDImWee1d4VKSvAYDwB n+R7uiYecSvoNHl4KN5dLxAfYSeWTG8QP3sONiXpch68lO1fT19ZDg1bbsUIuJqT2COi gbKyZoqy6wDfrTLs8xvpyjSNK/+3I5YPA7ADCAg63isknKDcLAUGkdv6uKQXfornQ6L1 2qcceqvlCQ2zRqy7PNgPvGNcByw3cumHvWzDuHRoW4uW/54gzSPtI+q+CUXrCHlY4Xdb ncOw== X-Gm-Message-State: AOAM5302Zgx3TKrkJYFYQlRdu0VDlNnLjbU4NP0LPRp14WiWalIkUCPo qaISOOOOaUmgCTrmGUxlm0E= X-Google-Smtp-Source: ABdhPJwDxjYqwd4SsWoA/szwThk1/VQI0lALPbyUXTRS6XaJ9gGayf2gFHtJoOZM9WEaaCOvTkyQ4A== X-Received: by 2002:a63:f006:: with SMTP id k6mr11547499pgh.88.1601854756304; Sun, 04 Oct 2020 16:39:16 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id h12sm9786071pfo.68.2020.10.04.16.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Oct 2020 16:39:15 -0700 (PDT) Date: Sun, 4 Oct 2020 16:39:14 -0700 From: Moritz Fischer To: Tom Rix Cc: Moritz Fischer , linux-fpga@vger.kernel.org, hao.wu@intel.com, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, russell.h.weight@intel.com, matthew.gerlach@intel.com Subject: Re: [PATCH 10/10] fpga: fpga-mgr: altera-pr-ip: Simplify registration Message-ID: <20201004233914.GA111357@epycbox.lan> References: <20201004051423.75879-1-mdf@kernel.org> <20201004051423.75879-11-mdf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 04, 2020 at 11:47:26AM -0700, Tom Rix wrote: > > On 10/3/20 10:14 PM, Moritz Fischer wrote: > > Simplify registration using new devm_fpga_mgr_register() API. > > Remove the now obsolete altera_pr_unregister() function. > > > > Signed-off-by: Moritz Fischer > > --- > > > > We should take another look at this, IIRC correctly the point of > > splitting this up into a separate driver was to make it useable by a > > different (pci?) driver later on. > > > > It doesn't seem like this happened, and I think we should just make this > > a platform driver? > > > > --- > > drivers/fpga/altera-pr-ip-core-plat.c | 10 ---------- > > drivers/fpga/altera-pr-ip-core.c | 14 +------------- > > include/linux/fpga/altera-pr-ip-core.h | 1 - > > 3 files changed, 1 insertion(+), 24 deletions(-) > > > > diff --git a/drivers/fpga/altera-pr-ip-core-plat.c b/drivers/fpga/altera-pr-ip-core-plat.c > > index 99b9cc0e70f0..b008a6b8d2d3 100644 > > --- a/drivers/fpga/altera-pr-ip-core-plat.c > > +++ b/drivers/fpga/altera-pr-ip-core-plat.c > > @@ -28,15 +28,6 @@ static int alt_pr_platform_probe(struct platform_device *pdev) > > return alt_pr_register(dev, reg_base); > > } > > > > -static int alt_pr_platform_remove(struct platform_device *pdev) > > -{ > > - struct device *dev = &pdev->dev; > > - > > - alt_pr_unregister(dev); > > - > > - return 0; > > -} > > - > > static const struct of_device_id alt_pr_of_match[] = { > > { .compatible = "altr,a10-pr-ip", }, > > {}, > > @@ -46,7 +37,6 @@ MODULE_DEVICE_TABLE(of, alt_pr_of_match); > > > > static struct platform_driver alt_pr_platform_driver = { > > .probe = alt_pr_platform_probe, > > - .remove = alt_pr_platform_remove, > > .driver = { > > .name = "alt_a10_pr_ip", > > .of_match_table = alt_pr_of_match, > > diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c > > index 2cf25fd5e897..dfdf21ed34c4 100644 > > --- a/drivers/fpga/altera-pr-ip-core.c > > +++ b/drivers/fpga/altera-pr-ip-core.c > > @@ -195,22 +195,10 @@ int alt_pr_register(struct device *dev, void __iomem *reg_base) > > if (!mgr) > > return -ENOMEM; > > > > - dev_set_drvdata(dev, mgr); > > - > > - return fpga_mgr_register(mgr); > > + return devm_fpga_mgr_register(dev, mgr); > > } > > EXPORT_SYMBOL_GPL(alt_pr_register); > > > > -void alt_pr_unregister(struct device *dev) > > -{ > > - struct fpga_manager *mgr = dev_get_drvdata(dev); > > - > > - dev_dbg(dev, "%s\n", __func__); > > - > > - fpga_mgr_unregister(mgr); > > -} > > -EXPORT_SYMBOL_GPL(alt_pr_unregister); > > Similar to the others, except for removing this symbol. > > A patch should do one logical thing. I was on the fence with this. Tbh, this driver should be a platform driver. I'll create a separate series for that. > > I'd rather this be split out of the patchset. > > Tom > > > - > > MODULE_AUTHOR("Matthew Gerlach "); > > MODULE_DESCRIPTION("Altera Partial Reconfiguration IP Core"); > > MODULE_LICENSE("GPL v2"); > > diff --git a/include/linux/fpga/altera-pr-ip-core.h b/include/linux/fpga/altera-pr-ip-core.h > > index 0b08ac20ab16..a6b4c07858cc 100644 > > --- a/include/linux/fpga/altera-pr-ip-core.h > > +++ b/include/linux/fpga/altera-pr-ip-core.h > > @@ -13,6 +13,5 @@ > > #include > > > > int alt_pr_register(struct device *dev, void __iomem *reg_base); > > -void alt_pr_unregister(struct device *dev); > > > > #endif /* _ALT_PR_IP_CORE_H */ > Cheers, Moritz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACE3DC4363C for ; Sun, 4 Oct 2020 23:41:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E2B9206B6 for ; Sun, 4 Oct 2020 23:41:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tkcuG8Q4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E2B9206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ufKlz+PwHOdv1n5273gs2GtD/iVzBN8QTbEGwO89uFc=; b=tkcuG8Q4yDD1GGwAVIsWkGaq9 cuAJ0AGhZlMcux9sl1q8JKQi1HrX2VhVZtmwuMxbUQmiLxw1EAhrHmIjzz1vxGutWTeY1PkKhyfUR +to+rsXY4CeXuy59NSs1613TypwY1ID8L5mmMcOWYALckNM9cWnfHgd9uglQV/qI8RgSIDgm0AY99 SnarWAY2WBS4J09uzhLMxn8pTQxEG/4Ee0eDRAs7wMWYhMgP6Zm3P8g7r5BGBKq5lFc0m2P5rV9mw UbEi8tHKHQU2Jw0Ppasf/6RUoBt5LT6VTQZNq8YVGjyuyziKKDEpEu2L13gZSe6BGTBvnE3WJrurV zQpPMsU4w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPDb6-0007Wd-Oh; Sun, 04 Oct 2020 23:39:20 +0000 Received: from mail-pf1-f195.google.com ([209.85.210.195]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPDb3-0007WI-II for linux-arm-kernel@lists.infradead.org; Sun, 04 Oct 2020 23:39:18 +0000 Received: by mail-pf1-f195.google.com with SMTP id q123so5491593pfb.0 for ; Sun, 04 Oct 2020 16:39:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=i0z6tvnBKutMrc8NANVNxZ4vgDVqspXt5PjdV91Nld0=; b=L2C1i27yOjovh04lDTINyrrxh3X2svJvEyIOy5vzbmYRap5/sdndN7JFqne2zkLjte o3FhH9Jx0cBWCiyBJjW4M/qVcF6q7xJdEHFsvBGsvTf/wtSYNfE5w8uNATiulb+GFMls CTO95MEiM7W0Sup+yhesw7iMjwbQ2FFzU8mSKSapON68O35Vx6WtQDbxBQ87Un7wC3eF hlkKJrO3kb6QN5nlIIOupFk8OssiKYapFMna7sT4f1Rrt4GD3JnCN4aXfYfXfnOR0zsT qy6FGrVWzDNpXWDLCC5EkuXgI2iak1x3ZrFCbRXJ5J+kuaZ+T1l8IU23QxWfhrcMtbuQ mCpQ== X-Gm-Message-State: AOAM5308r798EJsE/JwUTJoSQT5zocj3YsCSIBBkxUH51nT/en1YSKgC UYUq6xgfk0KEWPsqBb1ndJk= X-Google-Smtp-Source: ABdhPJwDxjYqwd4SsWoA/szwThk1/VQI0lALPbyUXTRS6XaJ9gGayf2gFHtJoOZM9WEaaCOvTkyQ4A== X-Received: by 2002:a63:f006:: with SMTP id k6mr11547499pgh.88.1601854756304; Sun, 04 Oct 2020 16:39:16 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id h12sm9786071pfo.68.2020.10.04.16.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Oct 2020 16:39:15 -0700 (PDT) Date: Sun, 4 Oct 2020 16:39:14 -0700 From: Moritz Fischer To: Tom Rix Subject: Re: [PATCH 10/10] fpga: fpga-mgr: altera-pr-ip: Simplify registration Message-ID: <20201004233914.GA111357@epycbox.lan> References: <20201004051423.75879-1-mdf@kernel.org> <20201004051423.75879-11-mdf@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201004_193917_656473_CC771C3B X-CRM114-Status: GOOD ( 27.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: russell.h.weight@intel.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, matthew.gerlach@intel.com, michal.simek@xilinx.com, Moritz Fischer , linux-arm-kernel@lists.infradead.org, hao.wu@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Oct 04, 2020 at 11:47:26AM -0700, Tom Rix wrote: > > On 10/3/20 10:14 PM, Moritz Fischer wrote: > > Simplify registration using new devm_fpga_mgr_register() API. > > Remove the now obsolete altera_pr_unregister() function. > > > > Signed-off-by: Moritz Fischer > > --- > > > > We should take another look at this, IIRC correctly the point of > > splitting this up into a separate driver was to make it useable by a > > different (pci?) driver later on. > > > > It doesn't seem like this happened, and I think we should just make this > > a platform driver? > > > > --- > > drivers/fpga/altera-pr-ip-core-plat.c | 10 ---------- > > drivers/fpga/altera-pr-ip-core.c | 14 +------------- > > include/linux/fpga/altera-pr-ip-core.h | 1 - > > 3 files changed, 1 insertion(+), 24 deletions(-) > > > > diff --git a/drivers/fpga/altera-pr-ip-core-plat.c b/drivers/fpga/altera-pr-ip-core-plat.c > > index 99b9cc0e70f0..b008a6b8d2d3 100644 > > --- a/drivers/fpga/altera-pr-ip-core-plat.c > > +++ b/drivers/fpga/altera-pr-ip-core-plat.c > > @@ -28,15 +28,6 @@ static int alt_pr_platform_probe(struct platform_device *pdev) > > return alt_pr_register(dev, reg_base); > > } > > > > -static int alt_pr_platform_remove(struct platform_device *pdev) > > -{ > > - struct device *dev = &pdev->dev; > > - > > - alt_pr_unregister(dev); > > - > > - return 0; > > -} > > - > > static const struct of_device_id alt_pr_of_match[] = { > > { .compatible = "altr,a10-pr-ip", }, > > {}, > > @@ -46,7 +37,6 @@ MODULE_DEVICE_TABLE(of, alt_pr_of_match); > > > > static struct platform_driver alt_pr_platform_driver = { > > .probe = alt_pr_platform_probe, > > - .remove = alt_pr_platform_remove, > > .driver = { > > .name = "alt_a10_pr_ip", > > .of_match_table = alt_pr_of_match, > > diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c > > index 2cf25fd5e897..dfdf21ed34c4 100644 > > --- a/drivers/fpga/altera-pr-ip-core.c > > +++ b/drivers/fpga/altera-pr-ip-core.c > > @@ -195,22 +195,10 @@ int alt_pr_register(struct device *dev, void __iomem *reg_base) > > if (!mgr) > > return -ENOMEM; > > > > - dev_set_drvdata(dev, mgr); > > - > > - return fpga_mgr_register(mgr); > > + return devm_fpga_mgr_register(dev, mgr); > > } > > EXPORT_SYMBOL_GPL(alt_pr_register); > > > > -void alt_pr_unregister(struct device *dev) > > -{ > > - struct fpga_manager *mgr = dev_get_drvdata(dev); > > - > > - dev_dbg(dev, "%s\n", __func__); > > - > > - fpga_mgr_unregister(mgr); > > -} > > -EXPORT_SYMBOL_GPL(alt_pr_unregister); > > Similar to the others, except for removing this symbol. > > A patch should do one logical thing. I was on the fence with this. Tbh, this driver should be a platform driver. I'll create a separate series for that. > > I'd rather this be split out of the patchset. > > Tom > > > - > > MODULE_AUTHOR("Matthew Gerlach "); > > MODULE_DESCRIPTION("Altera Partial Reconfiguration IP Core"); > > MODULE_LICENSE("GPL v2"); > > diff --git a/include/linux/fpga/altera-pr-ip-core.h b/include/linux/fpga/altera-pr-ip-core.h > > index 0b08ac20ab16..a6b4c07858cc 100644 > > --- a/include/linux/fpga/altera-pr-ip-core.h > > +++ b/include/linux/fpga/altera-pr-ip-core.h > > @@ -13,6 +13,5 @@ > > #include > > > > int alt_pr_register(struct device *dev, void __iomem *reg_base); > > -void alt_pr_unregister(struct device *dev); > > > > #endif /* _ALT_PR_IP_CORE_H */ > Cheers, Moritz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel