From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1731FC4727D for ; Sun, 4 Oct 2020 23:40:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C65CE206B6 for ; Sun, 4 Oct 2020 23:40:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601854811; bh=spBak83gFftgm+yi3RhrYvzm6iNkft5xvwLmO6ZkIeg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Wfo5mtp6fhMjQfcGoK1iofijF58iTn6c1H9PKLPhGZsCmi6pAWd5d64nzLUooNLiW 1qLowOThLRT7GVWe1PeyEWmE6SgTwroLWF3GJ4f+OyxaIB4iLouAI7IO6qiT1iMvJ8 dGHHKnbR8oNFWtAzNVsceC9vFGPNUaGTt6QnCtr8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725875AbgJDXkK (ORCPT ); Sun, 4 Oct 2020 19:40:10 -0400 Received: from mail-pj1-f66.google.com ([209.85.216.66]:36736 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbgJDXkK (ORCPT ); Sun, 4 Oct 2020 19:40:10 -0400 Received: by mail-pj1-f66.google.com with SMTP id b17so4305400pji.1; Sun, 04 Oct 2020 16:40:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5RmC8lajvDc8JqqhpPvdF9cVFad8GQY7C5ZedFzF2D4=; b=JmxdNQntLN03I9Vcw9bZquYFA74wnb16vYw/UpL7TNZsZjFLB5d0GJ21B9WtGYG0Yv ZzARxCk6RqDIzFHfWooVWsBQezDB6RDexwbzBkWx0n8iFllsOnwIagtvL5qV8t/M40Qc roPflBYqYR/+MGaVKjYrJm0Izn8n7/LMgiXKeyQH5ZkkXlqnFwBx08ouSr2a/EB4NWBa OcUwpjdedVhnW7T6q2gJiRRm9VNf73/LGAWhKGV/T9pZ7mN1jSA4tDOQ+B/MNOV9JDHC r1eg5jrzthUuWyjYyFrch4flqsNpWLsR/eIPoyVoVQgXZ+jfnAbuOY4T7pogfMmBKKiu t/Fw== X-Gm-Message-State: AOAM531OMo5tDAEMsMBE9gox9hcjNFqz7lAqqRXX3e0Qs+zN54MfKra8 pmZfB4vt8qYwudOGGurtMNI= X-Google-Smtp-Source: ABdhPJwzpONdJUJJVy488Qvmo0+TrrapgrC7zUxvxXWZByizaGqJE/ZtWk2CB+oYu7/wLlyCfnG5JA== X-Received: by 2002:a17:90a:aa05:: with SMTP id k5mr13402380pjq.59.1601854809620; Sun, 04 Oct 2020 16:40:09 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id x22sm7652583pfp.181.2020.10.04.16.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Oct 2020 16:40:09 -0700 (PDT) Date: Sun, 4 Oct 2020 16:40:08 -0700 From: Moritz Fischer To: Tom Rix Cc: Moritz Fischer , linux-fpga@vger.kernel.org, hao.wu@intel.com, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, russell.h.weight@intel.com, matthew.gerlach@intel.com Subject: Re: [PATCH 03/10] fpga: fpga-mgr: dfl-fme-mgr: Simplify registration Message-ID: <20201004234008.GB111357@epycbox.lan> References: <20201004051423.75879-1-mdf@kernel.org> <20201004051423.75879-4-mdf@kernel.org> <408267d9-1026-1a80-56c9-3a8beaaa2b82@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <408267d9-1026-1a80-56c9-3a8beaaa2b82@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 04, 2020 at 11:22:31AM -0700, Tom Rix wrote: > > On 10/3/20 10:14 PM, Moritz Fischer wrote: > > Simplify registration using new devm_fpga_mgr_register() API. > > > > Signed-off-by: Moritz Fischer > > --- > > drivers/fpga/dfl-fme-mgr.c | 12 +----------- > > 1 file changed, 1 insertion(+), 11 deletions(-) > > > > diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c > > index b3f7eee3c93f..3fc2be87d059 100644 > > --- a/drivers/fpga/dfl-fme-mgr.c > > +++ b/drivers/fpga/dfl-fme-mgr.c > > @@ -316,16 +316,7 @@ static int fme_mgr_probe(struct platform_device *pdev) > > mgr->compat_id = compat_id; > > platform_set_drvdata(pdev, mgr); > Nice catch. Will fix. > Is this call is still needed ? > > Tom > > > > > - return fpga_mgr_register(mgr); > > -} > > - > > -static int fme_mgr_remove(struct platform_device *pdev) > > -{ > > - struct fpga_manager *mgr = platform_get_drvdata(pdev); > > - > > - fpga_mgr_unregister(mgr); > > - > > - return 0; > > + return devm_fpga_mgr_register(dev, mgr); > > } > > > > static struct platform_driver fme_mgr_driver = { > > @@ -333,7 +324,6 @@ static struct platform_driver fme_mgr_driver = { > > .name = DFL_FPGA_FME_MGR, > > }, > > .probe = fme_mgr_probe, > > - .remove = fme_mgr_remove, > > }; > > > > module_platform_driver(fme_mgr_driver); > Cheers, Moritz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4F96C4363C for ; Sun, 4 Oct 2020 23:41:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D625205CB for ; Sun, 4 Oct 2020 23:41:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0l9sNy4u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D625205CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jrHj/vPWg+bcPgq7UpuKRZB8dZS6oGgLj5NBvTa07Z4=; b=0l9sNy4uhAC3fQT9K5RKMYkVO t41co5fQ19I38zPervEeNt/vYIZPcYddc9K0MIOb7kmeEs16oH49jY2gnGwDsBtsfa47oaHvxAZax s0/S1LqUX5QZPRyeAZ4ku66K2pIHCglBK/5Gk4u08nOtqrJEGdPzCaJ5IkhmpjM2rg88Cd3zDwTtt /h/5dd25xDV3qCtUYfS785yD5MO5c2dbSMDXeM13tCUqiRIyZ/SQAuyhqbMm1Z85Dzq17/bTmUvzC ZAaXPxpm8PBZ0ogtgMVHgS5tOEX/wxBMr/3r8KJMRvuHt/FdL4PBD7W9FMwxNGFYFyPaK0E1zr5kk ZB4LLqypA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPDbx-0007aL-4J; Sun, 04 Oct 2020 23:40:13 +0000 Received: from mail-pj1-f66.google.com ([209.85.216.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPDbu-0007Zr-Rw for linux-arm-kernel@lists.infradead.org; Sun, 04 Oct 2020 23:40:11 +0000 Received: by mail-pj1-f66.google.com with SMTP id a17so3937811pju.1 for ; Sun, 04 Oct 2020 16:40:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5RmC8lajvDc8JqqhpPvdF9cVFad8GQY7C5ZedFzF2D4=; b=OpQlwIBpE1RMq/rUAVXROb5BecIOYHB5ITRlhMW8iZNKDF92XSY/ICJ8hNkHN04kgx PSQF1/7tNYDNTuBD3M2NOq+HCfsvHwvhwKO6bmHmypPqxFNb0PtSIvi+rHLe4C39tYQP sXZTfOLj/e8Hb3DjQb1t9V3O8LwlkCzbECaEt1CoQNeadnibpFxfmHgvAalRBVIRyNhr OixH8dBpn6hcGoKzvW6Qdh+qy2gc7TT7j2EItY2PdG8k8Shbpd48zndRJCrag7nXYUZe pVssp0puFQ153hbOAdbliCYmxsFlVjE7H3XTaVr1Kl85soVdAEQ+h+6AbUMv5I3Xm7ED X6Ww== X-Gm-Message-State: AOAM5325Nu44XFajNzAWJNaDj38KGO7ZDRqZ+ihnDiI9DcoT6GsQWoge N7XUy6RccNMaBGR4XW5yHog= X-Google-Smtp-Source: ABdhPJwzpONdJUJJVy488Qvmo0+TrrapgrC7zUxvxXWZByizaGqJE/ZtWk2CB+oYu7/wLlyCfnG5JA== X-Received: by 2002:a17:90a:aa05:: with SMTP id k5mr13402380pjq.59.1601854809620; Sun, 04 Oct 2020 16:40:09 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id x22sm7652583pfp.181.2020.10.04.16.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Oct 2020 16:40:09 -0700 (PDT) Date: Sun, 4 Oct 2020 16:40:08 -0700 From: Moritz Fischer To: Tom Rix Subject: Re: [PATCH 03/10] fpga: fpga-mgr: dfl-fme-mgr: Simplify registration Message-ID: <20201004234008.GB111357@epycbox.lan> References: <20201004051423.75879-1-mdf@kernel.org> <20201004051423.75879-4-mdf@kernel.org> <408267d9-1026-1a80-56c9-3a8beaaa2b82@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <408267d9-1026-1a80-56c9-3a8beaaa2b82@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201004_194010_930053_02BC63B7 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: russell.h.weight@intel.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, matthew.gerlach@intel.com, michal.simek@xilinx.com, Moritz Fischer , linux-arm-kernel@lists.infradead.org, hao.wu@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Oct 04, 2020 at 11:22:31AM -0700, Tom Rix wrote: > > On 10/3/20 10:14 PM, Moritz Fischer wrote: > > Simplify registration using new devm_fpga_mgr_register() API. > > > > Signed-off-by: Moritz Fischer > > --- > > drivers/fpga/dfl-fme-mgr.c | 12 +----------- > > 1 file changed, 1 insertion(+), 11 deletions(-) > > > > diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c > > index b3f7eee3c93f..3fc2be87d059 100644 > > --- a/drivers/fpga/dfl-fme-mgr.c > > +++ b/drivers/fpga/dfl-fme-mgr.c > > @@ -316,16 +316,7 @@ static int fme_mgr_probe(struct platform_device *pdev) > > mgr->compat_id = compat_id; > > platform_set_drvdata(pdev, mgr); > Nice catch. Will fix. > Is this call is still needed ? > > Tom > > > > > - return fpga_mgr_register(mgr); > > -} > > - > > -static int fme_mgr_remove(struct platform_device *pdev) > > -{ > > - struct fpga_manager *mgr = platform_get_drvdata(pdev); > > - > > - fpga_mgr_unregister(mgr); > > - > > - return 0; > > + return devm_fpga_mgr_register(dev, mgr); > > } > > > > static struct platform_driver fme_mgr_driver = { > > @@ -333,7 +324,6 @@ static struct platform_driver fme_mgr_driver = { > > .name = DFL_FPGA_FME_MGR, > > }, > > .probe = fme_mgr_probe, > > - .remove = fme_mgr_remove, > > }; > > > > module_platform_driver(fme_mgr_driver); > Cheers, Moritz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel