From: David Miller <davem@davemloft.net>
To: vladimir.oltean@nxp.com
Cc: netdev@vger.kernel.org, kuba@kernel.org, f.fainelli@gmail.com,
martin.blumenstingl@googlemail.com, hauke@hauke-m.de,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
sean.wang@mediatek.com, Landen.Chao@mediatek.com, andrew@lunn.ch,
vivien.didelot@gmail.com, noodles@earth.li,
linus.walleij@linaro.org, alexandre.belloni@bootlin.com,
claudiu.manoil@nxp.com
Subject: Re: [PATCH net-next] net: dsa: propagate switchdev vlan_filtering prepare phase to drivers
Date: Mon, 05 Oct 2020 06:05:52 -0700 (PDT) [thread overview]
Message-ID: <20201005.060552.685538059223511166.davem@davemloft.net> (raw)
In-Reply-To: <20201002220646.3826555-1-vladimir.oltean@nxp.com>
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: Sat, 3 Oct 2020 01:06:46 +0300
> A driver may refuse to enable VLAN filtering for any reason beyond what
> the DSA framework cares about, such as:
> - having tc-flower rules that rely on the switch being VLAN-aware
> - the particular switch does not support VLAN, even if the driver does
> (the DSA framework just checks for the presence of the .port_vlan_add
> and .port_vlan_del pointers)
> - simply not supporting this configuration to be toggled at runtime
>
> Currently, when a driver rejects a configuration it cannot support, it
> does this from the commit phase, which triggers various warnings in
> switchdev.
>
> So propagate the prepare phase to drivers, to give them the ability to
> refuse invalid configurations cleanly and avoid the warnings.
>
> Since we need to modify all function prototypes and check for the
> prepare phase from within the drivers, take that opportunity and move
> the existing driver restrictions within the prepare phase where that is
> possible and easy.
...
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Applied, thanks.
prev parent reply other threads:[~2020-10-05 13:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 22:06 [PATCH net-next] net: dsa: propagate switchdev vlan_filtering prepare phase to drivers Vladimir Oltean
2020-10-04 20:59 ` Vladimir Oltean
2020-10-05 0:45 ` Florian Fainelli
2020-10-05 3:28 ` Florian Fainelli
2020-10-05 13:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005.060552.685538059223511166.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Landen.Chao@mediatek.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=noodles@earth.li \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.