From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62144C4363A for ; Mon, 5 Oct 2020 08:28:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F9452078E for ; Mon, 5 Oct 2020 08:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601886531; bh=jCtswKiG459H2C8CPf5ZmeX+FMSWF0/Phzu2cqrkLTM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tySRYjBwlReLaBGnC7rphuzFUOiXixlCV0YJ9Ui0EbQmka1DPKhSb/3kl8B4NcQBy /ViMnB6k5hjqOa9sinXnV7DgbH3YpIbvhkxrApDWE8BBaZ1JrF756wGt/rHLmPuQjR IAd6Ox3Q/Xyw6kgui9d58uO4Y8Ubu5zltCigedls= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725946AbgJEI2u (ORCPT ); Mon, 5 Oct 2020 04:28:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:54916 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725880AbgJEI2t (ORCPT ); Mon, 5 Oct 2020 04:28:49 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6DBF520776; Mon, 5 Oct 2020 08:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601886529; bh=jCtswKiG459H2C8CPf5ZmeX+FMSWF0/Phzu2cqrkLTM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=stauSqrp7dBUXk1Y7D+05A3YuE0VA5eGvHYqu9N9lN+ZD+y0pFuyBgn36rHY3Gynz qgVprU1GUPIyEoH3Zf+ttW6Ryw4OhgAul0EQzkA6xyzv639R1lw1nVbQ7lJhhgpkEY p8HisDzW4i5NtphO683Gui6/pA6Q+tZAX6k8Duik= Date: Mon, 5 Oct 2020 10:29:35 +0200 From: Greg Kroah-Hartman To: Bastien Nocera Cc: Marcel Holtmann , Johan Hedberg , Sathish Narsimman , "David S. Miller" , Jakub Kicinski , linux-bluetooth , "open list:NETWORKING [GENERAL]" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist" Message-ID: <20201005082935.GA2448@kroah.com> References: <20201003135449.GA2691@kroah.com> <20201003160713.GA1512229@kroah.com> <20201004105124.GA2429@kroah.com> <04e0af8618f95a4483f5a72ba90d4f8b1d9094bd.camel@hadess.net> <20201004131844.GA185109@kroah.com> <457d516913ebf5b73d2b250516f3d9e9c59fdfe9.camel@hadess.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="pf9I7BMVVzbSWLtt" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <457d516913ebf5b73d2b250516f3d9e9c59fdfe9.camel@hadess.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Sun, Oct 04, 2020 at 03:23:18PM +0200, Bastien Nocera wrote: > On Sun, 2020-10-04 at 15:18 +0200, Greg Kroah-Hartman wrote: > > On Sun, Oct 04, 2020 at 02:17:06PM +0200, Bastien Nocera wrote: > > > On Sun, 2020-10-04 at 12:51 +0200, Greg Kroah-Hartman wrote: > > > > On Sat, Oct 03, 2020 at 08:33:18PM +0200, Marcel Holtmann wrote: > > > > > Hi Greg, > > > > > > > > > > > > > This reverts commit > > > > > > > > 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 > > > > > > > > as it > > > > > > > > breaks all bluetooth connections on my machine. > > > > > > > > > > > > > > > > Cc: Marcel Holtmann > > > > > > > > Cc: Sathish Narsimman > > > > > > > > Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list > > > > > > > > when > > > > > > > > updating whitelist") > > > > > > > > Signed-off-by: Greg Kroah-Hartman > > > > > > > > > > > > > > > > --- > > > > > > > > net/bluetooth/hci_request.c | 41 ++---------------------- > > > > > > > > ---- > > > > > > > > --------- > > > > > > > > 1 file changed, 2 insertions(+), 39 deletions(-) > > > > > > > > > > > > > > > > This has been bugging me for since 5.9-rc1, when all > > > > > > > > bluetooth devices > > > > > > > > stopped working on my desktop system.  I finally got the > > > > > > > > time > > > > > > > > to do > > > > > > > > bisection today, and it came down to this patch.  > > > > > > > > Reverting > > > > > > > > it on top of > > > > > > > > 5.9-rc7 restored bluetooth devices and now my input > > > > > > > > devices > > > > > > > > properly > > > > > > > > work. > > > > > > > > > > > > > > > > As it's almost 5.9-final, any chance this can be merged > > > > > > > > now > > > > > > > > to fix the > > > > > > > > issue? > > > > > > > > > > > > > > can you be specific what breaks since our guys and I also > > > > > > > think > > > > > > > the > > > > > > > ChromeOS guys have been testing these series of patches > > > > > > > heavily. > > > > > > > > > > > > My bluetooth trackball does not connect at all.  With this > > > > > > reverted, it > > > > > > all "just works". > > > > > > > > > > > > Same I think for a Bluetooth headset, can check that again if > > > > > > you > > > > > > really > > > > > > need me to, but the trackball is reliable here. > > > > > > > > > > > > > When you run btmon does it indicate any errors? > > > > > > > > > > > > How do I run it and where are the errors displayed? > > > > > > > > > > you can do btmon -w trace.log and just let it run like tcdpump. > > > > > > > > Ok, attached. > > > > > > > > The device is not connecting, and then I open the gnome bluetooth > > > > dialog > > > > and it scans for devices in the area, but does not connect to my > > > > existing devices at all. > > > > > > > > Any ideas? > > > > > > Use bluetoothctl instead, the Bluetooth Settings from GNOME also > > > run a > > > discovery the whole time the panel is opened, and this breaks a > > > fair > > > number of poor quality adapters. This is worked-around in the most > > > recent version, but using bluetoothctl is a better debugging option > > > in > > > all cases. > > > > Ok, but how do I use that tool?  How do I shut down the gnome > > bluetooth > > stuff? > > You close the settings window... > > > I need newbie steps here please for what to run and what to show you. > > bluetoothctl connect "bluetooth address" > eg. > bluetoothctl connect "12:34:56:78:90" Ok, here that is on a clean 5.9-rc8 release: $ bluetoothctl connect F1:85:91:79:73:70 Attempting to connect to F1:85:91:79:73:70 Failed to connect: org.bluez.Error.Failed I've attached the trace log from that effort. I'll go try Marcel's proposed patch now as well... thanks, greg k-h --pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="trace.log" Content-Transfer-Encoding: quoted-printable btsnoop=00=00=00=00=01=00=00=07=D1=00=00=00!=00=00=00!=FF=FF=00=0C=00=00=00= =00=00=E2=8E=9BM#=3D=CALinux version 5.9.0-rc8 (x86_64)=00=00=00=00!=00=00= =00!=FF=FF=00=0C=00=00=00=00=00=E2=8E=9BM#=3D=CCBluetooth subsystem version= 2.22=00=00=00=00=10=00=00=00=10=00=00=00=00=00=00=00=00=00=E2=8E=9BM#=3D= =CD=00=01pe=F6=85=E0Phci0=00=00=00=00=00=00=00=00=00=00=00=00=00=00=00=08= =00=00=00=00=00=E2=8E=9BM#=3D=CD=00=00=00=08=00=00=00=08=00=00=00 =00=00=00=00=00=E2=8E=9BM#=3D=CEpe=F6=85=E0P=02=00=00=00=00=1E=00=00=00=1E= =FF=FF=00=0E=00=00=00=00=00=E2=8E=9BM#=3D=CE=01=00=00=00=02=00=01=12=00=01= =00=00=00=10bluetoothd=00=00=00=00=00=00=00=00=00 =00=00=00 =00=00=00=02=00= =00=00=00=00=E2=8E=9BN=12=13=FCB =06=00=00=00=00=00=00=00=00=00=06=00=00=00= =06=00=00=00=03=00=00=00=00=00=E2=8E=9BN=13=DDg=0E=04=02B =00=00=00=00=0B= =00=00=00=0B=00=00=00=02=00=00=00=00=00=E2=8E=9BN=13=DD=8CA =08=00=01=01=00= `=00`=00=00=00=00=06=00=00=00=06=00=00=00=03=00=00=00=00=00=E2=8E=9BN=13=ED= t=0E=04=01A =00=00=00=00 =00=00=00 =00=00=00=02=00=00=00=00=00=E2=8E=9BN=13= =ED=A1B =06=01=01=00=00=00=00=00=00=00=06=00=00=00=06=00=00=00=03=00=00=00= =00=00=E2=8E=9BN=13=FD=19=0E=04=02B =00=00=00=00 =00=00=00 =00=00=00=02=00= =00=00=00=00=E2=8E=9BP=85.)B =06=00=00=00=00=00=00=00=00=00=06=00=00=00=06= =00=00=00=03=00=00=00=00=00=E2=8E=9BP=87 =B0=0E=04=02B =00=00=00=00=0B=00= =00=00=0B=00=00=00=02=00=00=00=00=00=E2=8E=9BP=87 =FFA =08=00=01=01=00`=000= =00=00=00=00=06=00=00=00=06=00=00=00=03=00=00=00=00=00=E2=8E=9BP=87,N=0E=04= =01A =00=00=00=00 =00=00=00 =00=00=00=02=00=00=00=00=00=E2=8E=9BP=87,=8FB = =06=01=01=00=00=00=00=00=00=00=06=00=00=00=06=00=00=00=03=00=00=00=00=00=E2= =8E=9BP=87:`=0E=04=02B =00 --pf9I7BMVVzbSWLtt--