From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE75C4363A for ; Mon, 5 Oct 2020 09:18:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A74B20756 for ; Mon, 5 Oct 2020 09:18:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725910AbgJEJSJ (ORCPT ); Mon, 5 Oct 2020 05:18:09 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:46856 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725887AbgJEJSJ (ORCPT ); Mon, 5 Oct 2020 05:18:09 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: rcn) with ESMTPSA id 7FF3128DB82 Date: Mon, 5 Oct 2020 11:18:04 +0200 From: Ricardo =?utf-8?Q?Ca=C3=B1uelo?= To: Enric Balletbo i Serra Cc: robh@kernel.org, kernel@collabora.com, bleung@chromium.org, groeck@chromium.org, sjg@chromium.org, dianders@chromium.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: i2c: convert i2c-cros-ec-tunnel to json-schema Message-ID: <20201005091804.2xjwer6ppoog5orm@rcn-XPS-13-9360> References: <20201005071403.17450-1-ricardo.canuelo@collabora.com> <20201005071403.17450-2-ricardo.canuelo@collabora.com> <19e0e78e-f490-8bcb-cfdb-338a577b2205@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <19e0e78e-f490-8bcb-cfdb-338a577b2205@collabora.com> User-Agent: NeoMutt/20171215 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Enric, thanks for reviewing the patch. On lun 05-10-2020 10:52:26, Enric Balletbo i Serra wrote: > > +examples: > > + - | > > + cros-ec { > > We try to use always a complete example, and I think that, Rob also prefers > complete examples, so here you are missing the spi node. Ok, I'll prepare a new patch with an extended example. > > + compatible = "google,cros-ec-spi"; > > And, at least, should have a reg. Did not give you an error? AFAIK, the reg property is only enforced if the node name includes the unit-address. Cheers, Ricardo