All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-integrity@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
	Jerry Snitselaar <jsnitsel@redhat.com>,
	Peter Huewe <peterhuewe@gmx.de>
Subject: Re: [PATCH v2 2/5] tpm_tis: Clean up locality release
Date: Mon, 5 Oct 2020 20:03:32 +0300	[thread overview]
Message-ID: <20201005170332.GD6232@linux.intel.com> (raw)
In-Reply-To: <20201001180925.13808-3-James.Bottomley@HansenPartnership.com>

On Thu, Oct 01, 2020 at 11:09:22AM -0700, James Bottomley wrote:
> The current release locality code seems to be based on the
> misunderstanding that the TPM interrupts when a locality is released:
> it doesn't, only when the locality is acquired.
> 
> Furthermore, there seems to be no point in waiting for the locality to
> be released.  All it does is penalize the last TPM user.  However, if
> there's no next TPM user, this is a pointless wait and if there is a
> next TPM user, they'll pay the penalty waiting for the new locality
> (or possibly not if it's the same as the old locality).
> 
> Fix the code by making release_locality as simple write to release
> with no waiting for completion.
> 
> Fixes: 33bafe90824b ("tpm_tis: verify locality released before returning from release_locality")
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> 
> ---
> 
> v2: added fixes

Also, this should go to cover letter (with some detail on the fixes).

/Jarkko

  parent reply	other threads:[~2020-10-05 18:58 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01 18:09 [PATCH v2 0/5] tpm_tis: fix interrupts (again) James Bottomley
2020-10-01 18:09 ` [PATCH v2 1/5] tpm_tis: Fix check_locality for correct locality acquisition James Bottomley
2020-10-05 15:34   ` Jarkko Sakkinen
2020-10-05 19:00     ` James Bottomley
2020-10-05 20:32       ` Jarkko Sakkinen
2020-10-19 23:16   ` Jerry Snitselaar
2020-10-24 12:07     ` Jarkko Sakkinen
2020-10-30 12:13       ` Jarkko Sakkinen
2020-10-01 18:09 ` [PATCH v2 2/5] tpm_tis: Clean up locality release James Bottomley
2020-10-05 17:02   ` Jarkko Sakkinen
2020-10-05 19:05     ` James Bottomley
2020-10-05 20:34       ` Jarkko Sakkinen
2020-10-05 17:03   ` Jarkko Sakkinen [this message]
2020-10-19 23:17   ` Jerry Snitselaar
2020-10-24 12:10     ` Jarkko Sakkinen
2020-10-30 12:17       ` Jarkko Sakkinen
2020-10-30 15:47         ` James Bottomley
2020-10-30 21:52           ` Jarkko Sakkinen
2020-10-01 18:09 ` [PATCH v2 3/5] tpm_tis: Fix interrupts for TIS TPMs without legacy cycles James Bottomley
2020-10-05 17:05   ` Jarkko Sakkinen
2020-10-20  0:14   ` Jerry Snitselaar
2020-10-24 12:15     ` Jarkko Sakkinen
2020-10-30 12:18       ` Jarkko Sakkinen
2020-10-30 16:06         ` Jerry Snitselaar
2020-11-03  4:16           ` Jarkko Sakkinen
2020-12-01 18:12   ` Jerry Snitselaar
2020-12-01 19:49     ` Jerry Snitselaar
2020-12-01 21:06       ` James Bottomley
2020-12-01 21:47         ` Jerry Snitselaar
2020-10-01 18:09 ` [PATCH v2 4/5] tpm_tis: fix IRQ probing James Bottomley
2020-10-05 17:05   ` Jarkko Sakkinen
2020-10-19 23:41   ` Jerry Snitselaar
2020-10-24 12:17     ` Jarkko Sakkinen
2020-10-30 12:43       ` Jarkko Sakkinen
2020-10-30 15:49         ` James Bottomley
2020-10-30 16:11           ` Jerry Snitselaar
2020-11-03  4:43             ` Jarkko Sakkinen
2020-11-03 23:00               ` Jerry Snitselaar
2020-11-04  0:31                 ` Jarkko Sakkinen
2020-11-03  4:17           ` Jarkko Sakkinen
2020-11-06 15:32         ` Jarkko Sakkinen
2020-11-06 16:21           ` James Bottomley
2020-11-06 22:07             ` Jarkko Sakkinen
2020-10-01 18:09 ` [PATCH v2 5/5] Revert "tpm: Revert "tpm_tis_core: Turn on the TPM before probing IRQ's"" James Bottomley
2020-10-19 20:23   ` Jerry Snitselaar
2020-10-19 22:54     ` James Bottomley
2020-10-19 23:40   ` Jerry Snitselaar
2020-10-12  5:39 ` [PATCH v2 0/5] tpm_tis: fix interrupts (again) Jerry Snitselaar
2020-10-13  1:23   ` Jarkko Sakkinen
2020-10-18  5:34     ` Jarkko Sakkinen
2020-10-13  1:17 ` Jarkko Sakkinen
2020-10-13 15:15   ` Jerry Snitselaar
2020-10-13 15:24     ` James Bottomley
2020-10-13 16:05       ` Jerry Snitselaar
2020-10-14 15:03         ` Hans de Goede
2020-10-14 15:23           ` James Bottomley
2020-10-14 16:04             ` Hans de Goede
2020-10-14 16:34               ` Jerry Snitselaar
2020-10-14 16:46                 ` Hans de Goede
2020-10-14 17:01                   ` Jerry Snitselaar
2020-10-14 17:04                     ` Jerry Snitselaar
2020-10-14 20:58                   ` Jerry Snitselaar
2020-10-15  7:38                     ` Hans de Goede
2020-10-18 21:09                       ` Jarkko Sakkinen
2020-10-15 15:36                     ` James Bottomley
2020-10-15 18:48                       ` Jerry Snitselaar
2020-10-15 18:57                         ` James Bottomley
2020-10-15 19:16                           ` Jerry Snitselaar
2020-10-14 16:49                 ` James Bottomley
2020-10-18 21:05     ` Jarkko Sakkinen
2020-10-20 23:10       ` Jerry Snitselaar
2020-10-24 12:20         ` Jarkko Sakkinen
2020-10-26 18:29           ` Jerry Snitselaar
2020-10-27 17:14             ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201005170332.GD6232@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=jgg@ziepe.ca \
    --cc=jsnitsel@redhat.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.