All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff LaBundy <jeff@labundy.com>
To: Alexander Dahl <post@lespocky.de>
Cc: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Alexander Dahl <ada@thorsis.com>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org,
	Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds
Date: Mon, 5 Oct 2020 21:17:29 -0500	[thread overview]
Message-ID: <20201006021729.GA4822@labundy.com> (raw)
In-Reply-To: <20201005203451.9985-4-post@lespocky.de>

Hi Alexander,

On Mon, Oct 05, 2020 at 10:34:42PM +0200, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now).  Parent node name is not enforced, but recommended
> by DT project.
> 
>   DTC     Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
>   CHECK   Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
>         From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> 
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
> 
> Notes:
>     v6 -> v7:
>       * added warning message to commit message (Krzysztof Kozlowski)
>     
>     v6:
>       * added this patch to series
> 
>  Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/iqs62x.yaml b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> index 541b06d80e73..92dc48a8dfa7 100644
> --- a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> +++ b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> @@ -90,10 +90,11 @@ examples:
>              };
>      };
>  
> -    pwmleds {
> +    led-controller {
>              compatible = "pwm-leds";
>  
> -            panel {
> +            led-1 {
> +                    label = "panel";
>                      pwms = <&iqs620a_pwm 0 1000000>;
>                      max-brightness = <255>;
>              };
> -- 
> 2.20.1
> 

I like the consistency this brings. My only feedback is that in the other
examples I found (common.yaml and leds-gpio.yaml), the children count off
from 0 (e.g. led-0) instead of 1 as your series appears to.

That's not a huge deal; it simply seems more consistent to count from the
first index allowed by the regex (0). The patch is still fine, and so:

Acked-by: Jeff LaBundy <jeff@labundy.com>

Kind regards,
Jeff LaBundy

WARNING: multiple messages have this Message-ID (diff)
From: Jeff LaBundy <jeff@labundy.com>
To: Alexander Dahl <post@lespocky.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	Alexander Dahl <ada@thorsis.com>,
	linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>, Dan Murphy <dmurphy@ti.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org,
	Lee Jones <lee.jones@linaro.org>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-leds@vger.kernel.org,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>
Subject: Re: [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds
Date: Mon, 5 Oct 2020 21:17:29 -0500	[thread overview]
Message-ID: <20201006021729.GA4822@labundy.com> (raw)
In-Reply-To: <20201005203451.9985-4-post@lespocky.de>

Hi Alexander,

On Mon, Oct 05, 2020 at 10:34:42PM +0200, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now).  Parent node name is not enforced, but recommended
> by DT project.
> 
>   DTC     Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
>   CHECK   Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
>         From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> 
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
> 
> Notes:
>     v6 -> v7:
>       * added warning message to commit message (Krzysztof Kozlowski)
>     
>     v6:
>       * added this patch to series
> 
>  Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/iqs62x.yaml b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> index 541b06d80e73..92dc48a8dfa7 100644
> --- a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> +++ b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> @@ -90,10 +90,11 @@ examples:
>              };
>      };
>  
> -    pwmleds {
> +    led-controller {
>              compatible = "pwm-leds";
>  
> -            panel {
> +            led-1 {
> +                    label = "panel";
>                      pwms = <&iqs620a_pwm 0 1000000>;
>                      max-brightness = <255>;
>              };
> -- 
> 2.20.1
> 

I like the consistency this brings. My only feedback is that in the other
examples I found (common.yaml and leds-gpio.yaml), the children count off
from 0 (e.g. led-0) instead of 1 as your series appears to.

That's not a huge deal; it simply seems more consistent to count from the
first index allowed by the regex (0). The patch is still fine, and so:

Acked-by: Jeff LaBundy <jeff@labundy.com>

Kind regards,
Jeff LaBundy

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Jeff LaBundy <jeff@labundy.com>
To: Alexander Dahl <post@lespocky.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	Alexander Dahl <ada@thorsis.com>,
	linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>, Dan Murphy <dmurphy@ti.com>,
	Pavel Machek <pavel@ucw.cz>,
	linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org,
	Lee Jones <lee.jones@linaro.org>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-leds@vger.kernel.org,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>
Subject: Re: [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds
Date: Mon, 5 Oct 2020 21:17:29 -0500	[thread overview]
Message-ID: <20201006021729.GA4822@labundy.com> (raw)
In-Reply-To: <20201005203451.9985-4-post@lespocky.de>

Hi Alexander,

On Mon, Oct 05, 2020 at 10:34:42PM +0200, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now).  Parent node name is not enforced, but recommended
> by DT project.
> 
>   DTC     Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
>   CHECK   Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
>         From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> 
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
> 
> Notes:
>     v6 -> v7:
>       * added warning message to commit message (Krzysztof Kozlowski)
>     
>     v6:
>       * added this patch to series
> 
>  Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/iqs62x.yaml b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> index 541b06d80e73..92dc48a8dfa7 100644
> --- a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> +++ b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> @@ -90,10 +90,11 @@ examples:
>              };
>      };
>  
> -    pwmleds {
> +    led-controller {
>              compatible = "pwm-leds";
>  
> -            panel {
> +            led-1 {
> +                    label = "panel";
>                      pwms = <&iqs620a_pwm 0 1000000>;
>                      max-brightness = <255>;
>              };
> -- 
> 2.20.1
> 

I like the consistency this brings. My only feedback is that in the other
examples I found (common.yaml and leds-gpio.yaml), the children count off
from 0 (e.g. led-0) instead of 1 as your series appears to.

That's not a huge deal; it simply seems more consistent to count from the
first index allowed by the regex (0). The patch is still fine, and so:

Acked-by: Jeff LaBundy <jeff@labundy.com>

Kind regards,
Jeff LaBundy

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2020-10-06  2:17 UTC|newest]

Thread overview: 122+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
2020-10-05 20:34 ` Alexander Dahl
2020-10-05 20:34 ` Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 01/12] leds: pwm: Remove platform_data support Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-07 10:03   ` Pavel Machek
2020-10-07 10:03     ` Pavel Machek
2020-10-07 10:03     ` Pavel Machek
2020-10-05 20:34 ` [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-07 10:02   ` Pavel Machek
2020-10-07 10:02     ` Pavel Machek
2020-10-07 10:02     ` Pavel Machek
2020-10-07 10:03     ` Krzysztof Kozlowski
2020-10-07 10:03       ` Krzysztof Kozlowski
2020-10-07 10:03       ` Krzysztof Kozlowski
2020-10-28 20:39   ` Alexander Dahl
2020-10-28 20:39     ` Alexander Dahl
2020-10-28 20:39     ` Alexander Dahl
2020-10-29 13:46     ` Russell King - ARM Linux admin
2020-10-29 13:46       ` Russell King - ARM Linux admin
2020-10-29 13:46       ` Russell King - ARM Linux admin
2020-11-25 11:08   ` Pavel Machek
2020-11-25 11:08     ` Pavel Machek
2020-11-25 11:08     ` Pavel Machek
2020-10-05 20:34 ` [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-06  2:17   ` Jeff LaBundy [this message]
2020-10-06  2:17     ` Jeff LaBundy
2020-10-06  2:17     ` Jeff LaBundy
2020-10-06  6:34     ` Alexander Dahl
2020-10-06  6:34       ` Alexander Dahl
2020-10-06  6:34       ` Alexander Dahl
2020-10-06 22:27       ` Rob Herring
2020-10-06 22:27         ` Rob Herring
2020-10-06 22:27         ` Rob Herring
2020-10-06 22:28   ` Rob Herring
2020-10-06 22:28     ` Rob Herring
2020-10-06 22:28     ` Rob Herring
2020-10-07 10:03   ` Pavel Machek
2020-10-07 10:03     ` Pavel Machek
2020-10-07 10:03     ` Pavel Machek
2020-10-07 10:08     ` Alexander Dahl
2020-10-07 10:08       ` Alexander Dahl
2020-10-07 10:08       ` Alexander Dahl
2020-10-08  7:33     ` Lee Jones
2020-10-08  7:33       ` Lee Jones
2020-10-08  7:33       ` Lee Jones
2020-10-08  7:50       ` Pavel Machek
2020-10-08  7:50         ` Pavel Machek
2020-10-08  7:50         ` Pavel Machek
2020-10-05 20:34 ` [PATCH v7 04/12] ARM: dts: at91: smartkiz: Reference led node directly Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 05/12] ARM: dts: at91: Fix schema warnings for pwm-leds Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 06/12] ARM: dts: berlin: " Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 07/12] ARM: dts: exynos: " Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-07  6:25   ` Krzysztof Kozlowski
2020-10-07  6:25     ` Krzysztof Kozlowski
2020-10-07  6:25     ` Krzysztof Kozlowski
2020-10-26 18:45   ` Krzysztof Kozlowski
2020-10-26 18:45     ` Krzysztof Kozlowski
2020-10-26 18:45     ` Krzysztof Kozlowski
2020-10-05 20:34 ` [PATCH v7 08/12] ARM: dts: imx: " Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-30  7:46   ` Shawn Guo
2020-10-30  7:46     ` Shawn Guo
2020-10-30  7:46     ` Shawn Guo
2020-10-05 20:34 ` [PATCH v7 09/12] ARM: dts: omap: " Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-11-10 13:25   ` Tony Lindgren
2020-11-10 13:25     ` Tony Lindgren
2020-11-10 13:25     ` Tony Lindgren
2020-10-05 20:34 ` [PATCH v7 10/12] ARM: dts: stm32: " Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-27  7:03   ` [Linux-stm32] " Ahmad Fatoum
2020-10-27  7:03     ` Ahmad Fatoum
2020-10-27  7:03     ` Ahmad Fatoum
2020-10-27 10:05     ` Alexander Dahl
2020-10-27 10:05       ` Alexander Dahl
2020-10-27 10:05       ` Alexander Dahl
2020-10-27 10:58       ` Ahmad Fatoum
2020-10-27 10:58         ` Ahmad Fatoum
2020-10-27 10:58         ` Ahmad Fatoum
2020-10-28  7:34         ` Alexander Dahl
2020-10-28  7:34           ` Alexander Dahl
2020-10-28  7:34           ` Alexander Dahl
2020-11-02 10:47           ` Ahmad Fatoum
2020-11-02 10:47             ` Ahmad Fatoum
2020-11-02 10:47             ` Ahmad Fatoum
2020-10-31 13:54         ` Alexander Dahl
2020-10-31 13:54           ` Alexander Dahl
2020-11-02 11:10           ` Ahmad Fatoum
2020-11-02 11:10             ` Ahmad Fatoum
2020-11-09 11:02           ` Alexandre Torgue
2020-11-09 11:02             ` Alexandre Torgue
2020-11-09 22:21             ` Alexander Dahl
2020-11-09 22:21               ` Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 11/12] arm64: dts: meson: " Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 12/12] MIPS: DTS: img: " Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-05 20:34   ` Alexander Dahl
2020-10-28 18:56 ` [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexandre Belloni
2020-10-28 18:56   ` Alexandre Belloni
2020-10-28 18:56   ` Alexandre Belloni
2020-10-28 19:21   ` Alexandre Belloni
2020-10-28 19:21     ` Alexandre Belloni
2020-10-28 19:21     ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201006021729.GA4822@labundy.com \
    --to=jeff@labundy.com \
    --cc=ada@thorsis.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=pavel@ucw.cz \
    --cc=post@lespocky.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.