CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Denis Efremov CC: Julia Lawall CC: Bernie Thompson CC: Bartlomiej Zolnierkiewicz CC: linux-fbdev(a)vger.kernel.org CC: dri-devel(a)lists.freedesktop.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/video/fbdev/udlfb.c:1436:8-16: WARNING: use scnprintf or sprintf drivers/video/fbdev/udlfb.c:1428:8-16: WARNING: use scnprintf or sprintf drivers/video/fbdev/udlfb.c:1444:8-16: WARNING: use scnprintf or sprintf drivers/video/fbdev/udlfb.c:1452:8-16: WARNING: use scnprintf or sprintf From Documentation/filesystems/sysfs.txt: show() must not use snprintf() when formatting the value to be returned to user space. If you can guarantee that an overflow will never happen you can use sprintf() otherwise you must use scnprintf(). Generated by: scripts/coccinelle/api/device_attr_show.cocci Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 7575fdda569b2a2e8be32c1a64ecb05d6f96a500 commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script :::::: branch date: 12 hours ago :::::: commit date: 9 weeks ago Please take the patch only if it's a positive warning. Thanks! udlfb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/drivers/video/fbdev/udlfb.c +++ b/drivers/video/fbdev/udlfb.c @@ -1425,7 +1425,7 @@ static ssize_t metrics_bytes_rendered_sh struct device_attribute *a, char *buf) { struct fb_info *fb_info = dev_get_drvdata(fbdev); struct dlfb_data *dlfb = fb_info->par; - return snprintf(buf, PAGE_SIZE, "%u\n", + return scnprintf(buf, PAGE_SIZE, "%u\n", atomic_read(&dlfb->bytes_rendered)); } @@ -1433,7 +1433,7 @@ static ssize_t metrics_bytes_identical_s struct device_attribute *a, char *buf) { struct fb_info *fb_info = dev_get_drvdata(fbdev); struct dlfb_data *dlfb = fb_info->par; - return snprintf(buf, PAGE_SIZE, "%u\n", + return scnprintf(buf, PAGE_SIZE, "%u\n", atomic_read(&dlfb->bytes_identical)); } @@ -1441,7 +1441,7 @@ static ssize_t metrics_bytes_sent_show(s struct device_attribute *a, char *buf) { struct fb_info *fb_info = dev_get_drvdata(fbdev); struct dlfb_data *dlfb = fb_info->par; - return snprintf(buf, PAGE_SIZE, "%u\n", + return scnprintf(buf, PAGE_SIZE, "%u\n", atomic_read(&dlfb->bytes_sent)); } @@ -1449,7 +1449,7 @@ static ssize_t metrics_cpu_kcycles_used_ struct device_attribute *a, char *buf) { struct fb_info *fb_info = dev_get_drvdata(fbdev); struct dlfb_data *dlfb = fb_info->par; - return snprintf(buf, PAGE_SIZE, "%u\n", + return scnprintf(buf, PAGE_SIZE, "%u\n", atomic_read(&dlfb->cpu_kcycles_used)); }