From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7915C41604 for ; Tue, 6 Oct 2020 09:02:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CAC22080A for ; Tue, 6 Oct 2020 09:02:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="g9wi81nr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725934AbgJFJCG (ORCPT ); Tue, 6 Oct 2020 05:02:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725972AbgJFJCG (ORCPT ); Tue, 6 Oct 2020 05:02:06 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE2E0C0613D1 for ; Tue, 6 Oct 2020 02:02:05 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id g12so7097672wrp.10 for ; Tue, 06 Oct 2020 02:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ELTOM63/E69ypngcYfw/PJPfhYd4cEJ7an+k4N3B6b0=; b=g9wi81nrJ6UmEn/MRqwSU3xumhiaQ0GlcaOw6xhEiKsSlmdZGbw38cKNFRTONJfpMI rShanLIbCvxjdhkiYNqPKi8Vup+zyqcTTnfz4QRxI2fGoVF/BXzxdheJLLdkAm12bFyk 3kBeDptyUMuaNkrhRSTcA1A/T6L6yWAM6n5FeSKYE2zaV/4ekUktD7m6gzftaKqCslQR huR7AcNlYvOew6KNi+AYhIHETRnDzB8NwQj18Wh7qqEdGSSm3mOuAbvbqWH4Ba7Xfwi+ fgpsN7r8/tS8zIrrqQMGr7zwKzIZg+cN6IJHlSWnWOoGC6fYbIhpRIsIOTcTbuR/xJfb 1jtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ELTOM63/E69ypngcYfw/PJPfhYd4cEJ7an+k4N3B6b0=; b=MlyzDdQrlHiUnq5xJ4y1akt8r3qyMnkIKNDoYKG2uUZGgrJEhYW5XZgtw1QPh7hThX l0ZexNmXvKzAsM06N7K9KiKamFn+bqEU0i1vu+bUqqb1f0KZFtuJxNXUKOrlnMoSCk8Y +QaeTxHeLDv/QPfwd6+IyZ2xUPiMfTINsa7gPgF5Lfg/9O/IW/HHheMbvggu0DnGL71y F7PISooz1ZIrv/EWpkYJYFmYd2l51beZpsGDaY0YQsjUFFAMFq6nlFZf8Grpf5UaIbsZ /dekRarh4h32oJz+C0r3H4NrVG/tpJgB1C90Xol5RMqGB9drZy36pVOfDOj/44KHMN3i i92w== X-Gm-Message-State: AOAM533aD/n8S5hYk/RZCme7XsxdGhz490GQXyhOYFjvAUBilNsd+jNa 9/ijAbEwPVDhiTdCxof64YF1Zw== X-Google-Smtp-Source: ABdhPJw9C14n0661BEnE2zEAj/ACDnuST1NwREigggn7nJYJ/4H739MpvIQh/+WmIXOHfrDVMm5QuA== X-Received: by 2002:adf:9541:: with SMTP id 59mr3734807wrs.396.1601974924384; Tue, 06 Oct 2020 02:02:04 -0700 (PDT) Received: from localhost ([85.163.43.78]) by smtp.gmail.com with ESMTPSA id q15sm3609684wrr.8.2020.10.06.02.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2020 02:02:03 -0700 (PDT) Date: Tue, 6 Oct 2020 11:02:03 +0200 From: Jiri Pirko To: "Allan W. Nielsen" Cc: Henrik Bjoernlund , davem@davemloft.net, kuba@kernel.org, roopa@nvidia.com, nikolay@nvidia.com, jiri@mellanox.com, idosch@mellanox.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, UNGLinuxDriver@microchip.com, Horatiu Vultur Subject: Re: [net-next v2 10/11] bridge: switchdev: cfm: switchdev interface implementation Message-ID: <20201006090203.GA3336@nanopsycho> References: <20201001103019.1342470-1-henrik.bjoernlund@microchip.com> <20201001103019.1342470-11-henrik.bjoernlund@microchip.com> <20201001124929.GM8264@nanopsycho> <20201005130712.ybbgiddb7bnbkz6h@ws.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201005130712.ybbgiddb7bnbkz6h@ws.localdomain> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mon, Oct 05, 2020 at 03:07:12PM CEST, allan.nielsen@microchip.com wrote: >Hi Jiri > >On 01.10.2020 14:49, Jiri Pirko wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> Thu, Oct 01, 2020 at 12:30:18PM CEST, henrik.bjoernlund@microchip.com wrote: >> > This is the definition of the CFM switchdev interface. >> > >> > The interface consist of these objects: >> > SWITCHDEV_OBJ_ID_MEP_CFM, >> > SWITCHDEV_OBJ_ID_MEP_CONFIG_CFM, >> > SWITCHDEV_OBJ_ID_CC_CONFIG_CFM, >> > SWITCHDEV_OBJ_ID_CC_PEER_MEP_CFM, >> > SWITCHDEV_OBJ_ID_CC_CCM_TX_CFM, >> > SWITCHDEV_OBJ_ID_MEP_STATUS_CFM, >> > SWITCHDEV_OBJ_ID_PEER_MEP_STATUS_CFM >> > >> > MEP instance add/del >> > switchdev_port_obj_add(SWITCHDEV_OBJ_ID_MEP_CFM) >> > switchdev_port_obj_del(SWITCHDEV_OBJ_ID_MEP_CFM) >> > >> > MEP cofigure >> > switchdev_port_obj_add(SWITCHDEV_OBJ_ID_MEP_CONFIG_CFM) >> > >> > MEP CC cofigure >> > switchdev_port_obj_add(SWITCHDEV_OBJ_ID_CC_CONFIG_CFM) >> > >> > Peer MEP add/del >> > switchdev_port_obj_add(SWITCHDEV_OBJ_ID_CC_PEER_MEP_CFM) >> > switchdev_port_obj_del(SWITCHDEV_OBJ_ID_CC_PEER_MEP_CFM) >> > >> > Start/stop CCM transmission >> > switchdev_port_obj_add(SWITCHDEV_OBJ_ID_CC_CCM_TX_CFM) >> > >> > Get MEP status >> > switchdev_port_obj_get(SWITCHDEV_OBJ_ID_MEP_STATUS_CFM) >> > >> > Get Peer MEP status >> > switchdev_port_obj_get(SWITCHDEV_OBJ_ID_PEER_MEP_STATUS_CFM) >> > >> > Reviewed-by: Horatiu Vultur >> > Signed-off-by: Henrik Bjoernlund >> >> You have to submit the driver parts as a part of this patchset. >> Otherwise it is no good. >Fair enough. > >With MRP we did it like this, and after Nik asked for details on what is >being offload, we thought that adding this would help. > >The reason why we did not include the implementation of this interface >is that it is for a new SoC which is still not fully available which is >why we have not done the basic SwitchDev driver for it yet. But the >basic functionality clearly needs to come first. > >Our preference is to continue fixing the comments we got on the pure SW >implementation and then get back to the SwitchDev offloading. > >This will mean dropping the last 2 patches in the serie. > >Does that work for you Jiri, and Nik? Sure. > >/Allan >