From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CC5CC41604 for ; Tue, 6 Oct 2020 15:30:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B65AA206DD for ; Tue, 6 Oct 2020 15:30:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726060AbgJFPao (ORCPT ); Tue, 6 Oct 2020 11:30:44 -0400 Received: from mga11.intel.com ([192.55.52.93]:50431 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726012AbgJFPao (ORCPT ); Tue, 6 Oct 2020 11:30:44 -0400 IronPort-SDR: qs6DtO7cepNn/ugYjrEG0MdbmkQRhp2Ebtat1vgmqcWgf1kk2X1F5rG4Df+EjFKBd2K6S7+x6w elJIJgrMI21g== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="161142162" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="161142162" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 08:13:35 -0700 IronPort-SDR: jPUSRul6dmnX/quE+mWdCAmAcsoMHiT6J5ZKPwndtDnVEeHOOnXmmhkgWrTT6OznbQ9HAIIDBo 590TjXibqe7A== X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="527395662" Received: from thijsmet-mobl.ger.corp.intel.com (HELO localhost) ([10.249.34.36]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 08:13:34 -0700 Date: Tue, 6 Oct 2020 18:13:28 +0300 From: Jarkko Sakkinen To: Sean Christopherson Cc: Jethro Beekman , "linux-sgx@vger.kernel.org" Subject: Re: Unable to load large enclave Message-ID: <20201006151328.GA109815@linux.intel.com> References: <9393934c-e390-a7df-2e74-08f16d4f48d4@fortanix.com> <20200930011650.GA808399@linux.intel.com> <81e38a1b-c9a7-209e-76f5-e2c91f49c1e3@fortanix.com> <20200930114554.GA7612@linux.intel.com> <20201005225652.GD15803@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201005225652.GD15803@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Mon, Oct 05, 2020 at 03:56:52PM -0700, Sean Christopherson wrote: > On Wed, Sep 30, 2020 at 02:45:54PM +0300, Jarkko Sakkinen wrote: > > On Wed, Sep 30, 2020 at 09:12:06AM +0200, Jethro Beekman wrote: > > > On 2020-09-30 03:16, Jarkko Sakkinen wrote: > > > > On Tue, Sep 29, 2020 at 05:52:48PM +0200, Jethro Beekman wrote: > > > >> Since the latest API changes, I'm unable to load a large enclave. The > > > >> test program at > > > >> https://github.com/fortanix/rust-sgx/blob/sgx-load-large-enclave-test/src/main.rs > > > >> always fails with ENOMEM after loading 0xffd6 pages. > > > >> > > > >> I've tested this with v36, if there's reason to believe it has been > > > >> fixed I'd be happy to try it out on a newer patch set. > > > > > > > > I recommend using v39-rc1 tag that I created for testing because API is > > > > reverted back to be compatible with v36. > > > > > > Not sure what you're saying. I tested with v36. You're saying v39-rc1 > > > will be the same? Or did you fix the issue since v36? > > > > v37 and v38 has an API change that is reverted in v39: > > > > https://lore.kernel.org/linux-sgx/20200921195822.GA58176@linux.intel.com/ > > > > I'm not sure of the root cause yet but you asked to try to out a newer > > patch set and v39-rc1 is the best option. > > > > There was off-by-one error in enclave maximum size calculation fixed in > > v37 (it was actually a bug in SDM inherited to the code) but that should > > not result the situation you just described. > > My money is on the XArray changes, that's the most notable change in v36 and > IIRC the only thing that touched EPC/memory management. Yeah, that's what we've been speculating for some days now. That's somewhat deprecated email. It all started to enroll when I asked Haitao to turn CONFIG_PROVE_LOCKING on, and we got the information required to root cause the bug. /Jarkko