From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF763C41604 for ; Tue, 6 Oct 2020 15:26:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08954206DD for ; Tue, 6 Oct 2020 15:26:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726398AbgJFP0a (ORCPT ); Tue, 6 Oct 2020 11:26:30 -0400 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]:54315 "EHLO wnew4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbgJFP03 (ORCPT ); Tue, 6 Oct 2020 11:26:29 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 8DF8FB4A; Tue, 6 Oct 2020 11:26:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 06 Oct 2020 11:26:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=XVvl+TcUjqRrvpH+Af1XcXoFBtY BObBimd5gmwU57Mw=; b=A6a59ePBVWis3JnCMLKaoEu4oiB/c7FqU16aXuN+a5U ByIlUcyZIubF3xEDmtZtO7VTivlUrIWx6x+lXhVBIu7GB2jygM/4IdnD3RoJb175 gq6NsATT8cmmecH+JTu7nQNmK5X6T+wO+ooEZ8FRpqpDuumnbsQ3N3Og3JWGAWjl 7L27z3I7JeubaR0F46itiboMEzrQ6ZHRh9bXghut9jrONtc0lDsAFPMobvE8Opfx n5lwo0Fc21YcK26Dz8bdZIRU9I0gn7weywCm9KZN8FDO1Z4VepPS5blLSOS+Ravp Uzkb8g82FFIpDuuVjHCtkSveDbvBFr+7ucdCdFsI6Ag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=XVvl+T cUjqRrvpH+Af1XcXoFBtYBObBimd5gmwU57Mw=; b=o0nzk1wz4WX3tcF2/7nutH XMS26VsqE4V8B+bt4zdCs0aG3D8UH7Y5w28EFUfnZbri4ruMPPOZhU17cQ0V8t0H ssO4xQlwG4NYr/UUicrGn2Jylg2N4xT7hEyrAiKCYQp/ALBNl+PsNXR4N7VMZ4iQ T9j83OT/ObTIIUx8+KXAvNTenD5DJ1pFzqgKT13FxxmX2ubHEGa4yw0nEeCNyamI /ictGq4RWmyvVeNOXF7ZAi19Sr/M6diWRDk3pqherYmCPYR+XX+qzPPl81Y0npjX 8Ny3UasbvM1Vghxus21gzqPkYDyJM5AM4unghxYMuGzYoY81GiMw7TrPMlwHYRyA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrgeeggdekjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id A19393280064; Tue, 6 Oct 2020 11:26:25 -0400 (EDT) Date: Tue, 6 Oct 2020 17:26:23 +0200 From: Maxime Ripard To: Dave Stevenson Cc: Tim Gover , Stefan Wahren , Nathan Chancellor , Nicolas Saenz Julienne , Eric Anholt , LKML , DRI Development , Hoegeun Kwon , Chanwoo Choi , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline Message-ID: <20201006152623.sjc3jxagj4wh7g5f@gilmour.lan> References: <20200929221526.GA1370981@ubuntu-m3-large-x86> <20200930140758.gummt3umouva3wyu@gilmour.lan> <20200930163823.GA237050@ubuntu-m3-large-x86> <20201001064843.dlewcu3b7dvqanyy@gilmour.lan> <20201001085402.t6mzzwzplviunhoc@gilmour.lan> <20201002151954.wazqc5riesdomlpx@gilmour.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2vhbw75wrhkhefhs" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2vhbw75wrhkhefhs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Dave, On Fri, Oct 02, 2020 at 04:57:05PM +0100, Dave Stevenson wrote: > Hi Maxime >=20 > On Fri, 2 Oct 2020 at 16:19, Maxime Ripard wrote: > > > > Hi Tim, > > > > On Thu, Oct 01, 2020 at 11:15:46AM +0100, Tim Gover wrote: > > > hdmi_enable_4k60=3D1 causes the firmware to select 3.3 GHz for the PL= LC > > > VCO to support a core-frequency of 550 MHz which is the minimum > > > frequency required by the HVS at 4Kp60. The side effect is that if the > > > display clock requirements are lower than 4Kp60 then you will see > > > different core frequencies selected by DVFS. > > > > > > If enable_uart=3D1 and the mini-uart is selected (default unless > > > bluetooth is disabled) then the firmware will pin the core-frequency > > > to either core_freq max (500 or 550). Although, I think there is a way > > > of pinning it to a lower fixed frequency. > > > > > > The table in overclocking.md defines options for setting the maximum > > > core frequency but unless core_freq_min is specified DVFS will > > > automatically pick the lowest idle frequency required by the display > > > resolution. > > > > I'm wondering if there's some way to detect this from Linux? I guess it > > would be nice to be able to at least detect a broken config to warn / > > prevent an user that their situation is not going to be reliable / work > > really well (like if they have a 4k display without hdmi_enable_4kp60 > > set, or the issue we're discussing here) >=20 > The main filter in the firmware is the parameter > hdmi_pixel_freq_limit. That can either be set manually from > config.txt, or defaults appropriately based on hdmi_enable_4kp60. > Under firmware_kms [1] I read back those values to use as a filter > within crtc_mode_valid[2]. > I can't think of a nice way of exposing that without the vc4 driver > gaining a DT link to the firmware, and that starts to get ugly. I had in mind something like if the clock driver can infer that somehow through some the boundaries reported by the firmware maybe? IIRC, hdmi_enable_4kp60 will already change the max frequency reported to 550MHz instead of 500MHz Maxime --2vhbw75wrhkhefhs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX3yMnwAKCRDj7w1vZxhR xR/iAQD6pwgr2GpbJCVGim38pNOLxZo5Rqj2JwUV2k0DX+7aogD7BRzKIBKaqme7 8XvNoJP3M2U/v4jVWse/ISyU9jMM/Ao= =Bl+M -----END PGP SIGNATURE----- --2vhbw75wrhkhefhs-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE40C41604 for ; Tue, 6 Oct 2020 15:28:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4788206DD for ; Tue, 6 Oct 2020 15:28:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tU0J6Ghn"; dkim=temperror (0-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="A6a59ePB"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="o0nzk1wz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4788206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1uvTVp6FPKX6ZAnYDBTyO1SXTX+NcUNbAKuZB7Wf7KM=; b=tU0J6GhnOkj5UEfCaQZYma+At 7rgZ87pip1xdPeKrHHR24D3937OAi8TZxLmJatYOdaDf4M7C5S3ubfFBn/S4dzAxFLYb2Km1IOAWe s6umcYGNGypJP4J2pJN5Ddfb3iYPzQ9XLgm9DGWqWW8AS30Q4dycSVjR6p2wiKRqcyrcNwxs5NrZq Kbw/fZtGo2zf6q/E4KVjaz4QTXW1wEtOKPNuHxcf9XS/NTjurO6a0zAXgQL+AIujG55rtmsgrp+b0 xMbi1p7WSXsNxjPGiRf9EW+wz16/cRXlu2yzeSLvoLDPay/h6pjd0DMOHmFlvVgDkAz8+ROS6HKZ7 4AZ9q6YyQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPorP-0007S2-Qp; Tue, 06 Oct 2020 15:26:39 +0000 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPorK-0007Q2-Kr; Tue, 06 Oct 2020 15:26:35 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 8DF8FB4A; Tue, 6 Oct 2020 11:26:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 06 Oct 2020 11:26:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=XVvl+TcUjqRrvpH+Af1XcXoFBtY BObBimd5gmwU57Mw=; b=A6a59ePBVWis3JnCMLKaoEu4oiB/c7FqU16aXuN+a5U ByIlUcyZIubF3xEDmtZtO7VTivlUrIWx6x+lXhVBIu7GB2jygM/4IdnD3RoJb175 gq6NsATT8cmmecH+JTu7nQNmK5X6T+wO+ooEZ8FRpqpDuumnbsQ3N3Og3JWGAWjl 7L27z3I7JeubaR0F46itiboMEzrQ6ZHRh9bXghut9jrONtc0lDsAFPMobvE8Opfx n5lwo0Fc21YcK26Dz8bdZIRU9I0gn7weywCm9KZN8FDO1Z4VepPS5blLSOS+Ravp Uzkb8g82FFIpDuuVjHCtkSveDbvBFr+7ucdCdFsI6Ag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=XVvl+T cUjqRrvpH+Af1XcXoFBtYBObBimd5gmwU57Mw=; b=o0nzk1wz4WX3tcF2/7nutH XMS26VsqE4V8B+bt4zdCs0aG3D8UH7Y5w28EFUfnZbri4ruMPPOZhU17cQ0V8t0H ssO4xQlwG4NYr/UUicrGn2Jylg2N4xT7hEyrAiKCYQp/ALBNl+PsNXR4N7VMZ4iQ T9j83OT/ObTIIUx8+KXAvNTenD5DJ1pFzqgKT13FxxmX2ubHEGa4yw0nEeCNyamI /ictGq4RWmyvVeNOXF7ZAi19Sr/M6diWRDk3pqherYmCPYR+XX+qzPPl81Y0npjX 8Ny3UasbvM1Vghxus21gzqPkYDyJM5AM4unghxYMuGzYoY81GiMw7TrPMlwHYRyA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrgeeggdekjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id A19393280064; Tue, 6 Oct 2020 11:26:25 -0400 (EDT) Date: Tue, 6 Oct 2020 17:26:23 +0200 From: Maxime Ripard To: Dave Stevenson Subject: Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline Message-ID: <20201006152623.sjc3jxagj4wh7g5f@gilmour.lan> References: <20200929221526.GA1370981@ubuntu-m3-large-x86> <20200930140758.gummt3umouva3wyu@gilmour.lan> <20200930163823.GA237050@ubuntu-m3-large-x86> <20201001064843.dlewcu3b7dvqanyy@gilmour.lan> <20201001085402.t6mzzwzplviunhoc@gilmour.lan> <20201002151954.wazqc5riesdomlpx@gilmour.lan> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201006_112634_824396_40B79729 X-CRM114-Status: GOOD ( 27.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , Tim Gover , Chanwoo Choi , LKML , DRI Development , Phil Elwell , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Nathan Chancellor , Hoegeun Kwon , Nicolas Saenz Julienne , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7856956818318079458==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7856956818318079458== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2vhbw75wrhkhefhs" Content-Disposition: inline --2vhbw75wrhkhefhs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Dave, On Fri, Oct 02, 2020 at 04:57:05PM +0100, Dave Stevenson wrote: > Hi Maxime >=20 > On Fri, 2 Oct 2020 at 16:19, Maxime Ripard wrote: > > > > Hi Tim, > > > > On Thu, Oct 01, 2020 at 11:15:46AM +0100, Tim Gover wrote: > > > hdmi_enable_4k60=3D1 causes the firmware to select 3.3 GHz for the PL= LC > > > VCO to support a core-frequency of 550 MHz which is the minimum > > > frequency required by the HVS at 4Kp60. The side effect is that if the > > > display clock requirements are lower than 4Kp60 then you will see > > > different core frequencies selected by DVFS. > > > > > > If enable_uart=3D1 and the mini-uart is selected (default unless > > > bluetooth is disabled) then the firmware will pin the core-frequency > > > to either core_freq max (500 or 550). Although, I think there is a way > > > of pinning it to a lower fixed frequency. > > > > > > The table in overclocking.md defines options for setting the maximum > > > core frequency but unless core_freq_min is specified DVFS will > > > automatically pick the lowest idle frequency required by the display > > > resolution. > > > > I'm wondering if there's some way to detect this from Linux? I guess it > > would be nice to be able to at least detect a broken config to warn / > > prevent an user that their situation is not going to be reliable / work > > really well (like if they have a 4k display without hdmi_enable_4kp60 > > set, or the issue we're discussing here) >=20 > The main filter in the firmware is the parameter > hdmi_pixel_freq_limit. That can either be set manually from > config.txt, or defaults appropriately based on hdmi_enable_4kp60. > Under firmware_kms [1] I read back those values to use as a filter > within crtc_mode_valid[2]. > I can't think of a nice way of exposing that without the vc4 driver > gaining a DT link to the firmware, and that starts to get ugly. I had in mind something like if the clock driver can infer that somehow through some the boundaries reported by the firmware maybe? IIRC, hdmi_enable_4kp60 will already change the max frequency reported to 550MHz instead of 500MHz Maxime --2vhbw75wrhkhefhs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX3yMnwAKCRDj7w1vZxhR xR/iAQD6pwgr2GpbJCVGim38pNOLxZo5Rqj2JwUV2k0DX+7aogD7BRzKIBKaqme7 8XvNoJP3M2U/v4jVWse/ISyU9jMM/Ao= =Bl+M -----END PGP SIGNATURE----- --2vhbw75wrhkhefhs-- --===============7856956818318079458== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7856956818318079458==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30BC7C41604 for ; Wed, 7 Oct 2020 07:23:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D03F620797 for ; Wed, 7 Oct 2020 07:23:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D03F620797 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3183D6E89F; Wed, 7 Oct 2020 07:22:44 +0000 (UTC) Received: from wnew4-smtp.messagingengine.com (wnew4-smtp.messagingengine.com [64.147.123.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id F12656E15E for ; Tue, 6 Oct 2020 15:26:31 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 8DF8FB4A; Tue, 6 Oct 2020 11:26:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 06 Oct 2020 11:26:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=XVvl+TcUjqRrvpH+Af1XcXoFBtY BObBimd5gmwU57Mw=; b=A6a59ePBVWis3JnCMLKaoEu4oiB/c7FqU16aXuN+a5U ByIlUcyZIubF3xEDmtZtO7VTivlUrIWx6x+lXhVBIu7GB2jygM/4IdnD3RoJb175 gq6NsATT8cmmecH+JTu7nQNmK5X6T+wO+ooEZ8FRpqpDuumnbsQ3N3Og3JWGAWjl 7L27z3I7JeubaR0F46itiboMEzrQ6ZHRh9bXghut9jrONtc0lDsAFPMobvE8Opfx n5lwo0Fc21YcK26Dz8bdZIRU9I0gn7weywCm9KZN8FDO1Z4VepPS5blLSOS+Ravp Uzkb8g82FFIpDuuVjHCtkSveDbvBFr+7ucdCdFsI6Ag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=XVvl+T cUjqRrvpH+Af1XcXoFBtYBObBimd5gmwU57Mw=; b=o0nzk1wz4WX3tcF2/7nutH XMS26VsqE4V8B+bt4zdCs0aG3D8UH7Y5w28EFUfnZbri4ruMPPOZhU17cQ0V8t0H ssO4xQlwG4NYr/UUicrGn2Jylg2N4xT7hEyrAiKCYQp/ALBNl+PsNXR4N7VMZ4iQ T9j83OT/ObTIIUx8+KXAvNTenD5DJ1pFzqgKT13FxxmX2ubHEGa4yw0nEeCNyamI /ictGq4RWmyvVeNOXF7ZAi19Sr/M6diWRDk3pqherYmCPYR+XX+qzPPl81Y0npjX 8Ny3UasbvM1Vghxus21gzqPkYDyJM5AM4unghxYMuGzYoY81GiMw7TrPMlwHYRyA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrgeeggdekjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id A19393280064; Tue, 6 Oct 2020 11:26:25 -0400 (EDT) Date: Tue, 6 Oct 2020 17:26:23 +0200 From: Maxime Ripard To: Dave Stevenson Subject: Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline Message-ID: <20201006152623.sjc3jxagj4wh7g5f@gilmour.lan> References: <20200929221526.GA1370981@ubuntu-m3-large-x86> <20200930140758.gummt3umouva3wyu@gilmour.lan> <20200930163823.GA237050@ubuntu-m3-large-x86> <20201001064843.dlewcu3b7dvqanyy@gilmour.lan> <20201001085402.t6mzzwzplviunhoc@gilmour.lan> <20201002151954.wazqc5riesdomlpx@gilmour.lan> MIME-Version: 1.0 In-Reply-To: X-Mailman-Approved-At: Wed, 07 Oct 2020 07:22:33 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , Tim Gover , Chanwoo Choi , LKML , DRI Development , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Nathan Chancellor , Hoegeun Kwon , Nicolas Saenz Julienne , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1106267907==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============1106267907== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2vhbw75wrhkhefhs" Content-Disposition: inline --2vhbw75wrhkhefhs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Dave, On Fri, Oct 02, 2020 at 04:57:05PM +0100, Dave Stevenson wrote: > Hi Maxime >=20 > On Fri, 2 Oct 2020 at 16:19, Maxime Ripard wrote: > > > > Hi Tim, > > > > On Thu, Oct 01, 2020 at 11:15:46AM +0100, Tim Gover wrote: > > > hdmi_enable_4k60=3D1 causes the firmware to select 3.3 GHz for the PL= LC > > > VCO to support a core-frequency of 550 MHz which is the minimum > > > frequency required by the HVS at 4Kp60. The side effect is that if the > > > display clock requirements are lower than 4Kp60 then you will see > > > different core frequencies selected by DVFS. > > > > > > If enable_uart=3D1 and the mini-uart is selected (default unless > > > bluetooth is disabled) then the firmware will pin the core-frequency > > > to either core_freq max (500 or 550). Although, I think there is a way > > > of pinning it to a lower fixed frequency. > > > > > > The table in overclocking.md defines options for setting the maximum > > > core frequency but unless core_freq_min is specified DVFS will > > > automatically pick the lowest idle frequency required by the display > > > resolution. > > > > I'm wondering if there's some way to detect this from Linux? I guess it > > would be nice to be able to at least detect a broken config to warn / > > prevent an user that their situation is not going to be reliable / work > > really well (like if they have a 4k display without hdmi_enable_4kp60 > > set, or the issue we're discussing here) >=20 > The main filter in the firmware is the parameter > hdmi_pixel_freq_limit. That can either be set manually from > config.txt, or defaults appropriately based on hdmi_enable_4kp60. > Under firmware_kms [1] I read back those values to use as a filter > within crtc_mode_valid[2]. > I can't think of a nice way of exposing that without the vc4 driver > gaining a DT link to the firmware, and that starts to get ugly. I had in mind something like if the clock driver can infer that somehow through some the boundaries reported by the firmware maybe? IIRC, hdmi_enable_4kp60 will already change the max frequency reported to 550MHz instead of 500MHz Maxime --2vhbw75wrhkhefhs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX3yMnwAKCRDj7w1vZxhR xR/iAQD6pwgr2GpbJCVGim38pNOLxZo5Rqj2JwUV2k0DX+7aogD7BRzKIBKaqme7 8XvNoJP3M2U/v4jVWse/ISyU9jMM/Ao= =Bl+M -----END PGP SIGNATURE----- --2vhbw75wrhkhefhs-- --===============1106267907== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1106267907==--