From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83DB0C4727E for ; Tue, 6 Oct 2020 18:18:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C4BE206F7 for ; Tue, 6 Oct 2020 18:18:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602008317; bh=oFHUcM9h3z0IgMq+KYKXA/IoUEknKDCATmQQacVVQhY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=JuvI8E4XLuTtYwJwlF3/f8gOzuffKLsYvX6y4ItOkS2QBU1UNI3Ry3koO6jjM18tV sLY2TCkkPHSGB7eZsVNuD4nPJ9/zdZ0oXAo21MJklb15/Zg5nZkjvwmhK7pNAS33G3 kP1wUdgRpXhDtbOR+uc8YpXIK0+WSu2PNYoJi0kQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726839AbgJFSSe (ORCPT ); Tue, 6 Oct 2020 14:18:34 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:38048 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbgJFSSe (ORCPT ); Tue, 6 Oct 2020 14:18:34 -0400 Received: by mail-ot1-f66.google.com with SMTP id i12so7352239ota.5; Tue, 06 Oct 2020 11:18:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hy8u4oryHdrJw9k6yxuAVeerYVirHjXzT+ryq/l0sJI=; b=gyrEl7BZINBtuln7tBRPfzWbI8rQVMKpfHhzNY/aDejq2Cxv8dgNj4nkJMP+1xNdtS X599YKmm0IW6u+X+3hJeJDXY18FMYbuhI580z0dhsNYuwQkAbJtbMi4rkKWkAzY920ar /JCfjHImsnweqYz7rSHedGt2rVTX9V18TKvNsAiq2ZEjweBYFklGwVa6WA+i6qR+HQxO U89Yqx5B2+cci4+vWIlMjBqmRR76HSiFJYSjoqagcK7KSAAaF+acrH3flJvQI4jQ9+uR PTUNCAcMxsLgnjkxGblJyh6L8oQanojDgT7HO6w2Yj1wBoqPimydFv+V5D3RQ6CaF7T3 8Gog== X-Gm-Message-State: AOAM531P2O6mEGWTiSzTlY33WLLzetRiK/J8i9y4WYcA1CK5uOwyqNRP e1VRbaLWoLYoBjuBNUQb1A== X-Google-Smtp-Source: ABdhPJwG53MmjyQcM+RFl4ahPLOIQ9AtOizuvfBOaQSuAOXM6QUhNiSQCj7BeFRxNsdfSaTghhRHsA== X-Received: by 2002:a9d:491:: with SMTP id 17mr3859333otm.338.1602008310942; Tue, 06 Oct 2020 11:18:30 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id m187sm1446451oia.39.2020.10.06.11.18.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2020 11:18:29 -0700 (PDT) Received: (nullmailer pid 2571913 invoked by uid 1000); Tue, 06 Oct 2020 18:18:28 -0000 Date: Tue, 6 Oct 2020 13:18:28 -0500 From: Rob Herring To: Varadarajan Narayanan Cc: agross@kernel.org, bjorn.andersson@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linus.walleij@linaro.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, nsekar@codeaurora.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sricharan@codeaurora.org Subject: Re: [PATCH 6/7] arm64: dts: Add ipq5018 SoC and MP03 board support Message-ID: <20201006181828.GA2554170@bogus> References: <1601270140-4306-1-git-send-email-varada@codeaurora.org> <1601270140-4306-7-git-send-email-varada@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1601270140-4306-7-git-send-email-varada@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Sep 28, 2020 at 10:45:39AM +0530, Varadarajan Narayanan wrote: > Add initial device tree support for the Qualcomm IPQ5018 SoC and > MP03.1-C2 board. > > Signed-off-by: Varadarajan Narayanan > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 7 + Bindings and dts files should be separate patches. > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/ipq5018-mp03.1-c2.dts | 30 ++++ > arch/arm64/boot/dts/qcom/ipq5018.dtsi | 201 ++++++++++++++++++++++++ > 4 files changed, 239 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-mp03.1-c2.dts > create mode 100644 arch/arm64/boot/dts/qcom/ipq5018.dtsi > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 6031aee..694063f 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -28,6 +28,7 @@ description: | > apq8074 > apq8084 > apq8096 > + ipq5018 > ipq6018 > ipq8074 > mdm9615 > @@ -49,6 +50,7 @@ description: | > hk01 > idp > liquid > + mp03 > mtp > qrd > sbc > @@ -142,6 +144,11 @@ properties: > > - items: > - enum: > + - qcom,ipq5018-mp03 > + - const: qcom,ipq5018 > + > + - items: > + - enum: > - qcom,ipq8064-ap148 > - const: qcom,ipq8064 > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index d8f1466..3873970 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb > dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq6018-cp01-c1.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk01.dtb > +dtb-$(CONFIG_ARCH_QCOM) += ipq5018-mp03.1-c2.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-longcheer-l8150.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-a3u-eur.dtb > diff --git a/arch/arm64/boot/dts/qcom/ipq5018-mp03.1-c2.dts b/arch/arm64/boot/dts/qcom/ipq5018-mp03.1-c2.dts > new file mode 100644 > index 00000000..41bb3b3 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/ipq5018-mp03.1-c2.dts > @@ -0,0 +1,30 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) Your employer is okay with GPL3 (and later)? > +/* > + * IPQ5018 CP01 board device tree source > + * > + * Copyright (c) 2019, The Linux Foundation. All rights reserved. It's 2020. > + */ > + > +/dts-v1/; > + > +#include "ipq5018.dtsi" > + > +/ { > + model = "Qualcomm Technologies, Inc. IPQ5018/AP-MP03-C2"; > + compatible = "qcom,ipq5018-mp03", "qcom,ipq5018"; > + > + aliases { > + serial0 = &blsp1_uart1; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + bootargs-append = " swiotlb=1"; Not an upstream property. > + }; > +}; > + > +&blsp1_uart1 { > + pinctrl-0 = <&serial_1_pins>; > + pinctrl-names = "default"; > + status = "ok"; > +}; > diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi > new file mode 100644 > index 00000000..12492a4 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi > @@ -0,0 +1,201 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) > +/* > + * IPQ5018 SoC device tree source > + * > + * Copyright (c) 2019, The Linux Foundation. All rights reserved. > + */ > + > +#include > +#include > +#include > + > +/ { > + #address-cells = <2>; > + #size-cells = <2>; > + interrupt-parent = <&intc>; > + > + clocks { Drop the container node. > + sleep_clk: sleep-clk { > + compatible = "fixed-clock"; > + clock-frequency = <32000>; > + #clock-cells = <0>; > + }; > + > + xo: xo { > + compatible = "fixed-clock"; > + clock-frequency = <24000000>; > + #clock-cells = <0>; > + }; > + }; > + > + cpus: cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + CPU0: cpu@0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x0>; > + enable-method = "psci"; > + next-level-cache = <&L2_0>; > + }; > + > + CPU1: cpu@1 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + enable-method = "psci"; > + reg = <0x1>; > + next-level-cache = <&L2_0>; > + }; > + > + L2_0: l2-cache { > + compatible = "cache"; > + cache-level = <0x2>; > + }; > + }; > + > + pmuv8: pmu { > + compatible = "arm,cortex-a53-pmu"; > + interrupts = + IRQ_TYPE_LEVEL_HIGH)>; > + }; > + > + psci: psci { Drop unused (and likely never needed) labels. > + compatible = "arm,psci-1.0"; > + method = "smc"; > + }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + tz: tz@4ac00000 { > + reg = <0x0 0x4ac00000 0x0 0x00400000>; > + no-map; > + }; > + }; > + > + soc: soc { soc@0 Build dtbs with W=1 and fix any warnings. This should be one. > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0 0 0xffffffff>; > + dma-ranges; > + compatible = "simple-bus"; > + > + tlmm: pinctrl@1000000 { > + compatible = "qcom,ipq5018-pinctrl"; > + reg = <0x01000000 0x300000>; > + interrupts = ; > + gpio-controller; > + #gpio-cells = <2>; > + gpio-ranges = <&tlmm 0 80>; > + interrupt-controller; > + #interrupt-cells = <2>; > + > + serial_1_pins: serial1-pinmux { > + pins = "gpio31", "gpio32", "gpio33", "gpio34"; > + function = "blsp1_uart1"; > + drive-strength = <8>; > + bias-pull-down; > + }; > + }; > + > + gcc: gcc@1800000 { clock-controller@... > + compatible = "qcom,gcc-ipq5018"; > + reg = <0x01800000 0x80000>; > + clocks = <&xo>, <&sleep_clk>; > + clock-names = "xo", "sleep_clk"; > + #clock-cells = <1>; > + #reset-cells = <1>; > + }; > + > + blsp1_uart1: serial@78af000 { > + compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm"; > + reg = <0x078af000 0x200>; > + interrupts = ; > + clocks = <&gcc GCC_BLSP1_UART1_APPS_CLK>, > + <&gcc GCC_BLSP1_AHB_CLK>; > + clock-names = "core", "iface"; > + status = "disabled"; > + }; > + > + intc: interrupt-controller@b000000 { > + compatible = "qcom,msm-qgic2"; > + interrupt-controller; > + #interrupt-cells = <0x3>; > + reg = <0x0b000000 0x1000>, /*GICD*/ > + <0x0b002000 0x1000>, /*GICC*/ > + <0x0b001000 0x1000>, /*GICH*/ > + <0x0b004000 0x1000>; /*GICV*/ > + interrupts = ; > + }; > + > + timer { Not memory mapped, move to top-level. > + compatible = "arm,armv8-timer"; > + interrupts = , > + , > + , > + ; > + }; > + > + timer@b120000 { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + compatible = "arm,armv7-timer-mem"; > + reg = <0x0b120000 0x1000>; > + clock-frequency = <19200000>; > + > + frame@b120000 { > + frame-number = <0>; > + interrupts = , > + ; > + reg = <0x0b121000 0x1000>, > + <0x0b122000 0x1000>; > + }; > + > + frame@b123000 { > + frame-number = <1>; > + interrupts = ; > + reg = <0xb123000 0x1000>; > + status = "disabled"; > + }; > + > + frame@b124000 { > + frame-number = <2>; > + interrupts = ; > + reg = <0x0b124000 0x1000>; > + status = "disabled"; > + }; > + > + frame@b125000 { > + frame-number = <3>; > + interrupts = ; > + reg = <0x0b125000 0x1000>; > + status = "disabled"; > + }; > + > + frame@b126000 { > + frame-number = <4>; > + interrupts = ; > + reg = <0x0b126000 0x1000>; > + status = "disabled"; > + }; > + > + frame@b127000 { > + frame-number = <5>; > + interrupts = ; > + reg = <0x0b127000 0x1000>; > + status = "disabled"; > + }; > + > + frame@b128000 { > + frame-number = <6>; > + interrupts = ; > + reg = <0x0b128000 0x1000>; > + status = "disabled"; > + }; > + }; > + }; No memory node... Rob > +}; > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C06EAC41604 for ; Tue, 6 Oct 2020 18:20:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39514206F7 for ; Tue, 6 Oct 2020 18:20:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Z21WbhOd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39514206F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RNR4puh7vgb12cHFD0UY/q1GIH8iJJoNYcB+9FOJxVM=; b=Z21WbhOdpDhMPyMGGHe6pcjnl xqEv6msYi4/o9XOw8dKcKdDFlF79iTsOdyghmGh/6WrZXWUyxeWmRgB8o1DVh/lx7mBUJ6iMoZnl8 QmhNaNOkwKgrlXNZRAepoOb6r9G8t7tfce9mvlm3ZPlbav0Ih4vNZC8ULtAyHJ6AZ2sTkaao1kaP8 S6E8yj17urBDaRamdyzKtDduKYxmUHNoUz4ej9+TS2OVG15hkVeColraeyyrQxPxbOyjpmJuAEwms eq/Jbw9NDM1pF678JyljaW0Ups/eqkmr5SfwrEuy3b5y1A0cGmDjfFj0RcTYKEseTGA42zrCOhHFd PXPiI41PQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPrXm-00042G-Qr; Tue, 06 Oct 2020 18:18:34 +0000 Received: from mail-ot1-f65.google.com ([209.85.210.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPrXj-00041t-Pk for linux-arm-kernel@lists.infradead.org; Tue, 06 Oct 2020 18:18:33 +0000 Received: by mail-ot1-f65.google.com with SMTP id f10so4648989otb.6 for ; Tue, 06 Oct 2020 11:18:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hy8u4oryHdrJw9k6yxuAVeerYVirHjXzT+ryq/l0sJI=; b=D1VHRwRtbdvAl0MUsWxQAD62TDGAWLFlJC0YxrftPp1x7FxV/t60EpuEFtdW22wryY 0+lDaXMs8cZT51VhEBRNyEXt6w+Gy6zAp9orCCW3MNPaDL9LporTLgXNwjym8JOw/bV0 ubRQ1gPcEi7B1GtrjEYVbXCx28YDULYNjxCeMO1HEGjxfDVwSQp2Qwg/p1wkOEr+/6vE jYxuj4zoDAjB2ewh43U3F8HuHKPVJiEWFfP1c/0ILhIgzklclrvBWxgMdojrwutxG9hO FovUKQCv6gwT1Yr7QV7CcXwCp474cnE34+8+rkbtgpxRWW4umxtNYK7526vtv/yDu8yI QULg== X-Gm-Message-State: AOAM531mcWrVHCvdFfYgH8zsijyk5YHCRicA0Ho+ERMgA1ZDLPK3CRWh QPDoM0xXvvkTUIWd2twVlw== X-Google-Smtp-Source: ABdhPJwG53MmjyQcM+RFl4ahPLOIQ9AtOizuvfBOaQSuAOXM6QUhNiSQCj7BeFRxNsdfSaTghhRHsA== X-Received: by 2002:a9d:491:: with SMTP id 17mr3859333otm.338.1602008310942; Tue, 06 Oct 2020 11:18:30 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id m187sm1446451oia.39.2020.10.06.11.18.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2020 11:18:29 -0700 (PDT) Received: (nullmailer pid 2571913 invoked by uid 1000); Tue, 06 Oct 2020 18:18:28 -0000 Date: Tue, 6 Oct 2020 13:18:28 -0500 From: Rob Herring To: Varadarajan Narayanan Subject: Re: [PATCH 6/7] arm64: dts: Add ipq5018 SoC and MP03 board support Message-ID: <20201006181828.GA2554170@bogus> References: <1601270140-4306-1-git-send-email-varada@codeaurora.org> <1601270140-4306-7-git-send-email-varada@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1601270140-4306-7-git-send-email-varada@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201006_141832_253231_443D5DC3 X-CRM114-Status: GOOD ( 22.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, nsekar@codeaurora.org, sboyd@kernel.org, catalin.marinas@arm.com, mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, linux-gpio@vger.kernel.org, agross@kernel.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, sricharan@codeaurora.org, will@kernel.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 28, 2020 at 10:45:39AM +0530, Varadarajan Narayanan wrote: > Add initial device tree support for the Qualcomm IPQ5018 SoC and > MP03.1-C2 board. > > Signed-off-by: Varadarajan Narayanan > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 7 + Bindings and dts files should be separate patches. > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/ipq5018-mp03.1-c2.dts | 30 ++++ > arch/arm64/boot/dts/qcom/ipq5018.dtsi | 201 ++++++++++++++++++++++++ > 4 files changed, 239 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-mp03.1-c2.dts > create mode 100644 arch/arm64/boot/dts/qcom/ipq5018.dtsi > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 6031aee..694063f 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -28,6 +28,7 @@ description: | > apq8074 > apq8084 > apq8096 > + ipq5018 > ipq6018 > ipq8074 > mdm9615 > @@ -49,6 +50,7 @@ description: | > hk01 > idp > liquid > + mp03 > mtp > qrd > sbc > @@ -142,6 +144,11 @@ properties: > > - items: > - enum: > + - qcom,ipq5018-mp03 > + - const: qcom,ipq5018 > + > + - items: > + - enum: > - qcom,ipq8064-ap148 > - const: qcom,ipq8064 > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index d8f1466..3873970 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb > dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq6018-cp01-c1.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk01.dtb > +dtb-$(CONFIG_ARCH_QCOM) += ipq5018-mp03.1-c2.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-longcheer-l8150.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-a3u-eur.dtb > diff --git a/arch/arm64/boot/dts/qcom/ipq5018-mp03.1-c2.dts b/arch/arm64/boot/dts/qcom/ipq5018-mp03.1-c2.dts > new file mode 100644 > index 00000000..41bb3b3 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/ipq5018-mp03.1-c2.dts > @@ -0,0 +1,30 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) Your employer is okay with GPL3 (and later)? > +/* > + * IPQ5018 CP01 board device tree source > + * > + * Copyright (c) 2019, The Linux Foundation. All rights reserved. It's 2020. > + */ > + > +/dts-v1/; > + > +#include "ipq5018.dtsi" > + > +/ { > + model = "Qualcomm Technologies, Inc. IPQ5018/AP-MP03-C2"; > + compatible = "qcom,ipq5018-mp03", "qcom,ipq5018"; > + > + aliases { > + serial0 = &blsp1_uart1; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + bootargs-append = " swiotlb=1"; Not an upstream property. > + }; > +}; > + > +&blsp1_uart1 { > + pinctrl-0 = <&serial_1_pins>; > + pinctrl-names = "default"; > + status = "ok"; > +}; > diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi > new file mode 100644 > index 00000000..12492a4 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi > @@ -0,0 +1,201 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) > +/* > + * IPQ5018 SoC device tree source > + * > + * Copyright (c) 2019, The Linux Foundation. All rights reserved. > + */ > + > +#include > +#include > +#include > + > +/ { > + #address-cells = <2>; > + #size-cells = <2>; > + interrupt-parent = <&intc>; > + > + clocks { Drop the container node. > + sleep_clk: sleep-clk { > + compatible = "fixed-clock"; > + clock-frequency = <32000>; > + #clock-cells = <0>; > + }; > + > + xo: xo { > + compatible = "fixed-clock"; > + clock-frequency = <24000000>; > + #clock-cells = <0>; > + }; > + }; > + > + cpus: cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + CPU0: cpu@0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + reg = <0x0>; > + enable-method = "psci"; > + next-level-cache = <&L2_0>; > + }; > + > + CPU1: cpu@1 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53"; > + enable-method = "psci"; > + reg = <0x1>; > + next-level-cache = <&L2_0>; > + }; > + > + L2_0: l2-cache { > + compatible = "cache"; > + cache-level = <0x2>; > + }; > + }; > + > + pmuv8: pmu { > + compatible = "arm,cortex-a53-pmu"; > + interrupts = + IRQ_TYPE_LEVEL_HIGH)>; > + }; > + > + psci: psci { Drop unused (and likely never needed) labels. > + compatible = "arm,psci-1.0"; > + method = "smc"; > + }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + tz: tz@4ac00000 { > + reg = <0x0 0x4ac00000 0x0 0x00400000>; > + no-map; > + }; > + }; > + > + soc: soc { soc@0 Build dtbs with W=1 and fix any warnings. This should be one. > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0 0 0xffffffff>; > + dma-ranges; > + compatible = "simple-bus"; > + > + tlmm: pinctrl@1000000 { > + compatible = "qcom,ipq5018-pinctrl"; > + reg = <0x01000000 0x300000>; > + interrupts = ; > + gpio-controller; > + #gpio-cells = <2>; > + gpio-ranges = <&tlmm 0 80>; > + interrupt-controller; > + #interrupt-cells = <2>; > + > + serial_1_pins: serial1-pinmux { > + pins = "gpio31", "gpio32", "gpio33", "gpio34"; > + function = "blsp1_uart1"; > + drive-strength = <8>; > + bias-pull-down; > + }; > + }; > + > + gcc: gcc@1800000 { clock-controller@... > + compatible = "qcom,gcc-ipq5018"; > + reg = <0x01800000 0x80000>; > + clocks = <&xo>, <&sleep_clk>; > + clock-names = "xo", "sleep_clk"; > + #clock-cells = <1>; > + #reset-cells = <1>; > + }; > + > + blsp1_uart1: serial@78af000 { > + compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm"; > + reg = <0x078af000 0x200>; > + interrupts = ; > + clocks = <&gcc GCC_BLSP1_UART1_APPS_CLK>, > + <&gcc GCC_BLSP1_AHB_CLK>; > + clock-names = "core", "iface"; > + status = "disabled"; > + }; > + > + intc: interrupt-controller@b000000 { > + compatible = "qcom,msm-qgic2"; > + interrupt-controller; > + #interrupt-cells = <0x3>; > + reg = <0x0b000000 0x1000>, /*GICD*/ > + <0x0b002000 0x1000>, /*GICC*/ > + <0x0b001000 0x1000>, /*GICH*/ > + <0x0b004000 0x1000>; /*GICV*/ > + interrupts = ; > + }; > + > + timer { Not memory mapped, move to top-level. > + compatible = "arm,armv8-timer"; > + interrupts = , > + , > + , > + ; > + }; > + > + timer@b120000 { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + compatible = "arm,armv7-timer-mem"; > + reg = <0x0b120000 0x1000>; > + clock-frequency = <19200000>; > + > + frame@b120000 { > + frame-number = <0>; > + interrupts = , > + ; > + reg = <0x0b121000 0x1000>, > + <0x0b122000 0x1000>; > + }; > + > + frame@b123000 { > + frame-number = <1>; > + interrupts = ; > + reg = <0xb123000 0x1000>; > + status = "disabled"; > + }; > + > + frame@b124000 { > + frame-number = <2>; > + interrupts = ; > + reg = <0x0b124000 0x1000>; > + status = "disabled"; > + }; > + > + frame@b125000 { > + frame-number = <3>; > + interrupts = ; > + reg = <0x0b125000 0x1000>; > + status = "disabled"; > + }; > + > + frame@b126000 { > + frame-number = <4>; > + interrupts = ; > + reg = <0x0b126000 0x1000>; > + status = "disabled"; > + }; > + > + frame@b127000 { > + frame-number = <5>; > + interrupts = ; > + reg = <0x0b127000 0x1000>; > + status = "disabled"; > + }; > + > + frame@b128000 { > + frame-number = <6>; > + interrupts = ; > + reg = <0x0b128000 0x1000>; > + status = "disabled"; > + }; > + }; > + }; No memory node... Rob > +}; > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel