From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01389C4363D for ; Tue, 6 Oct 2020 23:59:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDB372100A for ; Tue, 6 Oct 2020 23:59:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726477AbgJFX7W (ORCPT ); Tue, 6 Oct 2020 19:59:22 -0400 Received: from correo.us.es ([193.147.175.20]:45900 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725925AbgJFX7W (ORCPT ); Tue, 6 Oct 2020 19:59:22 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 8F6BF1F0CE2 for ; Wed, 7 Oct 2020 01:59:19 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 81D56DA730 for ; Wed, 7 Oct 2020 01:59:19 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 77809DA72F; Wed, 7 Oct 2020 01:59:19 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 5D048DA704; Wed, 7 Oct 2020 01:59:17 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Wed, 07 Oct 2020 01:59:17 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 42A1842EF42A; Wed, 7 Oct 2020 01:59:17 +0200 (CEST) Date: Wed, 7 Oct 2020 01:59:16 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Phil Sutter Cc: netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH v2] libxtables: Make sure extensions register in revision order Message-ID: <20201006235916.GA2143@salvia> References: <20200922225341.8976-2-phil@nwl.cc> <20201006120748.22006-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201006120748.22006-1-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Oct 06, 2020 at 02:07:48PM +0200, Phil Sutter wrote: > Insert extensions into pending lists in ordered fashion: Group by > extension name (and, for matches, family) and order groups by descending > revision number. > > This allows to simplify the later full registration considerably. Since > that involves kernel compatibility checks, the extra cycles here pay off > eventually. LGTM.