From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15E4AC4363C for ; Wed, 7 Oct 2020 11:01:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 392BA2080A for ; Wed, 7 Oct 2020 11:01:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dMSHdM2I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 392BA2080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQ7Cg-0001ku-2h for qemu-devel@archiver.kernel.org; Wed, 07 Oct 2020 07:01:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQ7A7-0007rr-Ro for qemu-devel@nongnu.org; Wed, 07 Oct 2020 06:59:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50541) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kQ7A6-0002Xq-25 for qemu-devel@nongnu.org; Wed, 07 Oct 2020 06:59:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602068349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A1sx9xKlBP5VVwnvoVCDlyjftDAKIiVJLzpt1uSrVMQ=; b=dMSHdM2IPqmZBafOhSMjg2XAXHB8yZk4Sa+gGtaPU2GSWOC3M3pm4ALvkToGAd969W4Bw/ za6EMiIbkWPw5KaQVESHjCDh3HB6atjkoZ+fnIBW8OvximV0dJ/IplgS+xjVN24xeX1bn/ D8hLARNbf3YEFh/GOQZ6nADT8mlG/ME= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-34-WU2HB6LWOnGwzS6xHbm3-A-1; Wed, 07 Oct 2020 06:59:07 -0400 X-MC-Unique: WU2HB6LWOnGwzS6xHbm3-A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A2C981F004; Wed, 7 Oct 2020 10:59:06 +0000 (UTC) Received: from linux.fritz.box (ovpn-113-169.ams2.redhat.com [10.36.113.169]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 192A155789; Wed, 7 Oct 2020 10:59:04 +0000 (UTC) Date: Wed, 7 Oct 2020 12:59:03 +0200 From: Kevin Wolf To: John Snow Subject: Re: [PATCH 12/20] python/qemu/console_socket.py: Correct type of recv() Message-ID: <20201007105903.GF7212@linux.fritz.box> References: <20201006235817.3280413-1-jsnow@redhat.com> <20201006235817.3280413-13-jsnow@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201006235817.3280413-13-jsnow@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/07 00:44:56 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.742, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-block@nongnu.org, Max Reitz , qemu-devel@nongnu.org, Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 07.10.2020 um 01:58 hat John Snow geschrieben: > The type and parameter names of recv() should match socket.socket(). Should this be socket.socket without parentheses (the class name)? socket.socket() is the constructor and it takes very different parameters. > OK, easy enough, but in the cases we don't pass straight through to the > real socket implementation, we probably can't accept such flags. OK, for > now, assert that we don't receive flags in such cases. > > Signed-off-by: John Snow Reviewed-by: Kevin Wolf