From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 764CFC4363D for ; Wed, 7 Oct 2020 14:58:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BF8E212CC for ; Wed, 7 Oct 2020 14:58:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728745AbgJGO6N (ORCPT ); Wed, 7 Oct 2020 10:58:13 -0400 Received: from netrider.rowland.org ([192.131.102.5]:59523 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1728737AbgJGO6L (ORCPT ); Wed, 7 Oct 2020 10:58:11 -0400 Received: (qmail 456826 invoked by uid 1000); 7 Oct 2020 10:58:09 -0400 Date: Wed, 7 Oct 2020 10:58:09 -0400 From: Alan Stern To: Joel Stanley Cc: Ryan Chen , Andrew Jeffery , Linux ARM , linux-aspeed , Linux Kernel Mailing List , linux-usb@vger.kernel.org, bmc-sw@aspeedtech.com Subject: Re: [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci Message-ID: <20201007145809.GA456169@rowland.harvard.edu> References: <20200930040823.26065-1-ryan_chen@aspeedtech.com> <20200930040823.26065-3-ryan_chen@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2020 at 11:25:04AM +0000, Joel Stanley wrote: > On Wed, 30 Sep 2020 at 04:08, Ryan Chen wrote: > > > > Add support for AST2600 SOC UHCI driver. > > > > Signed-off-by: Ryan Chen > > Reviewed-by: Joel Stanley > > USB maintainers, can you please take this patch (2/3)? I will take the > others in this series through the aspeed tree. > > Cheers, > > Joel > > > > --- > > drivers/usb/host/uhci-platform.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c > > index 70dbd95c3f06..fa40fe125c2a 100644 > > --- a/drivers/usb/host/uhci-platform.c > > +++ b/drivers/usb/host/uhci-platform.c > > @@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev) > > num_ports); > > } > > if (of_device_is_compatible(np, "aspeed,ast2400-uhci") || > > - of_device_is_compatible(np, "aspeed,ast2500-uhci")) { > > + of_device_is_compatible(np, "aspeed,ast2500-uhci") || > > + of_device_is_compatible(np, "aspeed,ast2600-uhci")) { > > uhci->is_aspeed = 1; > > dev_info(&pdev->dev, > > "Enabled Aspeed implementation workarounds\n"); > > -- > > 2.17.1 > > The indentation of the continuation lines isn't good, because the continued parts are aligned with the lines in the conditional block. They should be visually distinct. Either align with the "of_device..." at the start or indent by two extra tab stops. Once this is fixed, you can add: Acked-by: Alan Stern Alan Stern From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87648C41604 for ; Wed, 7 Oct 2020 14:59:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01EB4208C7 for ; Wed, 7 Oct 2020 14:59:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jfgZtBKx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01EB4208C7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GTxJfYOXE/7yvvnwv96Sofv08PVzqu7FqUntL45icXg=; b=jfgZtBKxyZHJm65XKkIuyYtKv lFFRMsPWgTfpSWXYU/k4MvNPeMYZLpMNm1bXZr6y+zUvE1VSXKXai+bLZlazrhmt1pquP9VKToCy1 2/OBhJNoo101PdNKcEt9dB37ZeReX2mCJts7w/FwFYssBkcRGKgh1kdbBk2i77FoANqZuBsEh8Jxz MxGcSXmjVR7bMLXL3tEcLTtTgsp2qlu+5MMZ8OyXCUbhFcToEq2shu1yhotWYEN05l7TCRcWHxlpj aM22CTXH4fTdBpWHlPR2DJfkbO3KpfXrimhDmhskYhmzB4S9RsNlMK03YS6ULO0fJJ+TablU5LdIV gixlfF6GQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQAtR-0000OS-4r; Wed, 07 Oct 2020 14:58:14 +0000 Received: from netrider.rowland.org ([192.131.102.5]) by merlin.infradead.org with smtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQAtO-0000Nl-KX for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 14:58:11 +0000 Received: (qmail 456826 invoked by uid 1000); 7 Oct 2020 10:58:09 -0400 Date: Wed, 7 Oct 2020 10:58:09 -0400 From: Alan Stern To: Joel Stanley Subject: Re: [PATCH 2/3] usb: host: add uhci compatible support for ast2600-uhci Message-ID: <20201007145809.GA456169@rowland.harvard.edu> References: <20200930040823.26065-1-ryan_chen@aspeedtech.com> <20200930040823.26065-3-ryan_chen@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_105810_733497_947DED49 X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bmc-sw@aspeedtech.com, Ryan Chen , linux-aspeed , Andrew Jeffery , linux-usb@vger.kernel.org, Linux Kernel Mailing List , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 07, 2020 at 11:25:04AM +0000, Joel Stanley wrote: > On Wed, 30 Sep 2020 at 04:08, Ryan Chen wrote: > > > > Add support for AST2600 SOC UHCI driver. > > > > Signed-off-by: Ryan Chen > > Reviewed-by: Joel Stanley > > USB maintainers, can you please take this patch (2/3)? I will take the > others in this series through the aspeed tree. > > Cheers, > > Joel > > > > --- > > drivers/usb/host/uhci-platform.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c > > index 70dbd95c3f06..fa40fe125c2a 100644 > > --- a/drivers/usb/host/uhci-platform.c > > +++ b/drivers/usb/host/uhci-platform.c > > @@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev) > > num_ports); > > } > > if (of_device_is_compatible(np, "aspeed,ast2400-uhci") || > > - of_device_is_compatible(np, "aspeed,ast2500-uhci")) { > > + of_device_is_compatible(np, "aspeed,ast2500-uhci") || > > + of_device_is_compatible(np, "aspeed,ast2600-uhci")) { > > uhci->is_aspeed = 1; > > dev_info(&pdev->dev, > > "Enabled Aspeed implementation workarounds\n"); > > -- > > 2.17.1 > > The indentation of the continuation lines isn't good, because the continued parts are aligned with the lines in the conditional block. They should be visually distinct. Either align with the "of_device..." at the start or indent by two extra tab stops. Once this is fixed, you can add: Acked-by: Alan Stern Alan Stern _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel