From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 735DFC41604 for ; Wed, 7 Oct 2020 17:39:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15BF42173E for ; Wed, 7 Oct 2020 17:39:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Dz0OOWtV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728183AbgJGRjP (ORCPT ); Wed, 7 Oct 2020 13:39:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727863AbgJGRjO (ORCPT ); Wed, 7 Oct 2020 13:39:14 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 725DBC0613D2 for ; Wed, 7 Oct 2020 10:39:13 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id 188so3740537qkk.12 for ; Wed, 07 Oct 2020 10:39:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=muCEajJ6hDOPl6eL85j4HlmJ9WtV9zWU+bfCV/Cq9BI=; b=Dz0OOWtV09rElfhUKte1coDG1XmH70sU+t7XSvzch8QKv+JqccAMRzt3CfP44+/AfQ BSOmkO0/4DojdkfFvQXoQgyy0jQhFfYLuGtSpIEzw2ZgOz60sA9Vk6P6Joyx8mLM7oVI GulM3GKMb4JRE2TKQ53Eo7+b0LYA9pmvGiN/xhtwvUGDgP8zpeZiK3xp1njllpvHZ6s7 +zEZsvi99NmVaNYy4acbivpnVkuHyfeEWt1WrvUqBOOC668uWgAj9EFU3nanuKQfFrvC NI/B5LDgDV7l6mq+xucfE4i5Vmh8E5S9NLZXdlnDCI7i7X4L/RR/AAH2/qqGFU9zUkKq IF+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=muCEajJ6hDOPl6eL85j4HlmJ9WtV9zWU+bfCV/Cq9BI=; b=oAW97awUTzAtHFy3PQ1Kld+EZxcbUadi6DJVcNzcE1tmY5i10WWZJZGykfu+Uc3sqL ikzMLs1X0rbsEJfanC6mZzJQ7wXfe1RAnPsE6T5OCfEnybEmjaLiEo082ttbrRdeXQsU jDYOpnVMu0/FiDD+L9y4yAiQQLH8cJRyiV2uBjIDIvB5R3/qO4daedsWunLgSr204i67 oz2oGwm4KXCmSM+s0Yg5Dr1ef9WsGVc5IkOLl+Gu/0FSXcIms3GyqvDI3MYYJGQARQN6 8yiioPvWWEesKxJ38zIvomUvPVoeHzcqYR10AQAJKZ7+lgw9ee9V9jaMiZ+LQHX7ZQtQ FFAw== X-Gm-Message-State: AOAM533klzthrt3nFFkdOSgeym1n4WDeMEmNWFGI5PTkbJ2iBzX35WOm L3raSrvLR5a6J/77iMXpT2MJog== X-Google-Smtp-Source: ABdhPJwRH/CX2FYRARUgG1+mzIa/QuVNWzg4jQoHZB7NOT97+fmtc0eat9IRh9q/mSpxChFc0Hp56Q== X-Received: by 2002:a05:620a:54f:: with SMTP id o15mr3905794qko.91.1602092352650; Wed, 07 Oct 2020 10:39:12 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id d14sm2013598qtr.62.2020.10.07.10.39.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 10:39:11 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kQDPD-00112O-7o; Wed, 07 Oct 2020 14:39:11 -0300 Date: Wed, 7 Oct 2020 14:39:11 -0300 From: Jason Gunthorpe To: Daniel Vetter Cc: DRI Development , LKML , kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Daniel Vetter , Kees Cook , Dan Williams , Andrew Morton , John Hubbard , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Jan Kara , Alex Williamson , Cornelia Huck Subject: Re: [PATCH 13/13] vfio/type1: Mark follow_pfn as unsafe Message-ID: <20201007173911.GX5177@ziepe.ca> References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-14-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201007164426.1812530-14-daniel.vetter@ffwll.ch> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2020 at 06:44:26PM +0200, Daniel Vetter wrote: > The code seems to stuff these pfns into iommu pts (or something like > that, I didn't follow), but there's no mmu_notifier to ensure that > access is synchronized with pte updates. > > Hence mark these as unsafe. This means that with > CONFIG_STRICT_FOLLOW_PFN, these will be rejected. > > Real fix is to wire up an mmu_notifier ... somehow. Probably means any > invalidate is a fatal fault for this vfio device, but then this > shouldn't ever happen if userspace is reasonable. > > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Kees Cook > Cc: Dan Williams > Cc: Andrew Morton > Cc: John Hubbard > Cc: Jérôme Glisse > Cc: Jan Kara > Cc: Dan Williams > Cc: linux-mm@kvack.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-media@vger.kernel.org > Cc: Alex Williamson > Cc: Cornelia Huck > Cc: kvm@vger.kernel.org > --- > drivers/vfio/vfio_iommu_type1.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index 5fbf0c1f7433..a4d53f3d0a35 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -421,7 +421,7 @@ static int follow_fault_pfn(struct vm_area_struct *vma, struct mm_struct *mm, > { > int ret; > > - ret = follow_pfn(vma, vaddr, pfn); > + ret = unsafe_follow_pfn(vma, vaddr, pfn); > if (ret) { > bool unlocked = false; > > @@ -435,7 +435,7 @@ static int follow_fault_pfn(struct vm_area_struct *vma, struct mm_struct *mm, > if (ret) > return ret; > > - ret = follow_pfn(vma, vaddr, pfn); > + ret = unsafe_follow_pfn(vma, vaddr, pfn); > } This is actually being commonly used, so it needs fixing. When I talked to Alex about this last we had worked out a patch series that adds a test on vm_ops that the vma came from vfio in the first place. The VMA's created by VFIO are 'safe' as the PTEs are never changed. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A705EC41604 for ; Wed, 7 Oct 2020 17:40:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 142E82168B for ; Wed, 7 Oct 2020 17:40:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sSlWry7B"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Dz0OOWtV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 142E82168B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hkPP7WVM+EVbmQyhV2z0LttlAaYjvpxhuTiuY4yiHEY=; b=sSlWry7Br9L1akUrAXwOV1/6V pTGK5C9sxPLtS5MMJJI0uLn3+8BCvHmOf5jFO1epk5YUsHF7UJ/+yhWAVzMEmVN5KlKnFFZz/2ogT 2wgWKqjXNqYE7eizVlIxurVukSrg2dD7rmAl5vLWt2otlipqmE8DZVTm1qIJpHDJxuHkjZwzA4wqk V1+sIwhZs+5+wV+sSKjnWVocHBaetiqJ+5Ys5HXg49cGLz0wqt9C8Srmw2KuRkUu9iT8Qk2FXBlrn syaYQBo/8EWjWCAYXu8Jqwvid4Dk1WzlbVoyB58giJpYywLjaCqGlwURs5gVWd7AAH+LvnGFC2S1a gXp1J2gsA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQDPJ-0001Bn-5j; Wed, 07 Oct 2020 17:39:17 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQDPG-0001An-HD for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 17:39:15 +0000 Received: by mail-qk1-x744.google.com with SMTP id c2so3771589qkf.10 for ; Wed, 07 Oct 2020 10:39:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=muCEajJ6hDOPl6eL85j4HlmJ9WtV9zWU+bfCV/Cq9BI=; b=Dz0OOWtV09rElfhUKte1coDG1XmH70sU+t7XSvzch8QKv+JqccAMRzt3CfP44+/AfQ BSOmkO0/4DojdkfFvQXoQgyy0jQhFfYLuGtSpIEzw2ZgOz60sA9Vk6P6Joyx8mLM7oVI GulM3GKMb4JRE2TKQ53Eo7+b0LYA9pmvGiN/xhtwvUGDgP8zpeZiK3xp1njllpvHZ6s7 +zEZsvi99NmVaNYy4acbivpnVkuHyfeEWt1WrvUqBOOC668uWgAj9EFU3nanuKQfFrvC NI/B5LDgDV7l6mq+xucfE4i5Vmh8E5S9NLZXdlnDCI7i7X4L/RR/AAH2/qqGFU9zUkKq IF+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=muCEajJ6hDOPl6eL85j4HlmJ9WtV9zWU+bfCV/Cq9BI=; b=h7CVTwHFCy25DuL7Wfn7G8wwy/7gRfFV5pknif1IJVvLYu33ey3QKGiEHZr0ERqX8E tdzHce5MQQYMMA2aJcaCuVm8kXA/PFjF3k+LJJA4ec6vl8WalYupxnKtSK9rF7pCSxEw nwEPTXRX5TumfF8K78OQDNVkWZVZFiZoV4K/ggk43yMauF14nYxBN9i+CIf8m/tHGCFk Ie05nyM/kza/TlzIl5DiUHMe35b89YZevwfm150cINhs7iMnYR5lM7MndW6xojlJqUeF lJRtemRJO1MnEHOwEZR0a8uSyPTTfJhv360Nvn5vZuWECKKt8GZyR3UwY31oQNxb3QGo tZHw== X-Gm-Message-State: AOAM530d70If691SAVHVWmDPD1lIb/QhhmX17syyi18nvnLE5ReJ3l03 Mm4rKDH3XOa6gq34zpr2mxY4qg== X-Google-Smtp-Source: ABdhPJwRH/CX2FYRARUgG1+mzIa/QuVNWzg4jQoHZB7NOT97+fmtc0eat9IRh9q/mSpxChFc0Hp56Q== X-Received: by 2002:a05:620a:54f:: with SMTP id o15mr3905794qko.91.1602092352650; Wed, 07 Oct 2020 10:39:12 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id d14sm2013598qtr.62.2020.10.07.10.39.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 10:39:11 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kQDPD-00112O-7o; Wed, 07 Oct 2020 14:39:11 -0300 Date: Wed, 7 Oct 2020 14:39:11 -0300 From: Jason Gunthorpe To: Daniel Vetter Subject: Re: [PATCH 13/13] vfio/type1: Mark follow_pfn as unsafe Message-ID: <20201007173911.GX5177@ziepe.ca> References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-14-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201007164426.1812530-14-daniel.vetter@ffwll.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_133914_579620_FAA331EF X-CRM114-Status: GOOD ( 25.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Jan Kara , Kees Cook , kvm@vger.kernel.org, John Hubbard , Cornelia Huck , LKML , DRI Development , linux-mm@kvack.org, =?utf-8?B?SsOpcsO0bWU=?= Glisse , Alex Williamson , Daniel Vetter , Dan Williams , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBPY3QgMDcsIDIwMjAgYXQgMDY6NDQ6MjZQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBUaGUgY29kZSBzZWVtcyB0byBzdHVmZiB0aGVzZSBwZm5zIGludG8gaW9tbXUgcHRz IChvciBzb21ldGhpbmcgbGlrZQo+IHRoYXQsIEkgZGlkbid0IGZvbGxvdyksIGJ1dCB0aGVyZSdz IG5vIG1tdV9ub3RpZmllciB0byBlbnN1cmUgdGhhdAo+IGFjY2VzcyBpcyBzeW5jaHJvbml6ZWQg d2l0aCBwdGUgdXBkYXRlcy4KPiAKPiBIZW5jZSBtYXJrIHRoZXNlIGFzIHVuc2FmZS4gVGhpcyBt ZWFucyB0aGF0IHdpdGgKPiBDT05GSUdfU1RSSUNUX0ZPTExPV19QRk4sIHRoZXNlIHdpbGwgYmUg cmVqZWN0ZWQuCj4gCj4gUmVhbCBmaXggaXMgdG8gd2lyZSB1cCBhbiBtbXVfbm90aWZpZXIgLi4u IHNvbWVob3cuIFByb2JhYmx5IG1lYW5zIGFueQo+IGludmFsaWRhdGUgaXMgYSBmYXRhbCBmYXVs dCBmb3IgdGhpcyB2ZmlvIGRldmljZSwgYnV0IHRoZW4gdGhpcwo+IHNob3VsZG4ndCBldmVyIGhh cHBlbiBpZiB1c2Vyc3BhY2UgaXMgcmVhc29uYWJsZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBEYW5p ZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiBDYzogSmFzb24gR3VudGhvcnBl IDxqZ2dAemllcGUuY2E+Cj4gQ2M6IEtlZXMgQ29vayA8a2Vlc2Nvb2tAY2hyb21pdW0ub3JnPgo+ IENjOiBEYW4gV2lsbGlhbXMgPGRhbi5qLndpbGxpYW1zQGludGVsLmNvbT4KPiBDYzogQW5kcmV3 IE1vcnRvbiA8YWtwbUBsaW51eC1mb3VuZGF0aW9uLm9yZz4KPiBDYzogSm9obiBIdWJiYXJkIDxq aHViYmFyZEBudmlkaWEuY29tPgo+IENjOiBKw6lyw7RtZSBHbGlzc2UgPGpnbGlzc2VAcmVkaGF0 LmNvbT4KPiBDYzogSmFuIEthcmEgPGphY2tAc3VzZS5jej4KPiBDYzogRGFuIFdpbGxpYW1zIDxk YW4uai53aWxsaWFtc0BpbnRlbC5jb20+Cj4gQ2M6IGxpbnV4LW1tQGt2YWNrLm9yZwo+IENjOiBs aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBDYzogbGludXgtc2Ftc3VuZy1z b2NAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGxpbnV4LW1lZGlhQHZnZXIua2VybmVsLm9yZwo+IENj OiBBbGV4IFdpbGxpYW1zb24gPGFsZXgud2lsbGlhbXNvbkByZWRoYXQuY29tPgo+IENjOiBDb3Ju ZWxpYSBIdWNrIDxjb2h1Y2tAcmVkaGF0LmNvbT4KPiBDYzoga3ZtQHZnZXIua2VybmVsLm9yZwo+ IC0tLQo+ICBkcml2ZXJzL3ZmaW8vdmZpb19pb21tdV90eXBlMS5jIHwgNCArKy0tCj4gIDEgZmls ZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvdmZpby92ZmlvX2lvbW11X3R5cGUxLmMgYi9kcml2ZXJzL3ZmaW8vdmZpb19p b21tdV90eXBlMS5jCj4gaW5kZXggNWZiZjBjMWY3NDMzLi5hNGQ1M2YzZDBhMzUgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy92ZmlvL3ZmaW9faW9tbXVfdHlwZTEuYwo+ICsrKyBiL2RyaXZlcnMvdmZp by92ZmlvX2lvbW11X3R5cGUxLmMKPiBAQCAtNDIxLDcgKzQyMSw3IEBAIHN0YXRpYyBpbnQgZm9s bG93X2ZhdWx0X3BmbihzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSwgc3RydWN0IG1tX3N0cnVj dCAqbW0sCj4gIHsKPiAgCWludCByZXQ7Cj4gIAo+IC0JcmV0ID0gZm9sbG93X3Bmbih2bWEsIHZh ZGRyLCBwZm4pOwo+ICsJcmV0ID0gdW5zYWZlX2ZvbGxvd19wZm4odm1hLCB2YWRkciwgcGZuKTsK PiAgCWlmIChyZXQpIHsKPiAgCQlib29sIHVubG9ja2VkID0gZmFsc2U7Cj4gIAo+IEBAIC00MzUs NyArNDM1LDcgQEAgc3RhdGljIGludCBmb2xsb3dfZmF1bHRfcGZuKHN0cnVjdCB2bV9hcmVhX3N0 cnVjdCAqdm1hLCBzdHJ1Y3QgbW1fc3RydWN0ICptbSwKPiAgCQlpZiAocmV0KQo+ICAJCQlyZXR1 cm4gcmV0Owo+ICAKPiAtCQlyZXQgPSBmb2xsb3dfcGZuKHZtYSwgdmFkZHIsIHBmbik7Cj4gKwkJ cmV0ID0gdW5zYWZlX2ZvbGxvd19wZm4odm1hLCB2YWRkciwgcGZuKTsKPiAgCX0KClRoaXMgaXMg YWN0dWFsbHkgYmVpbmcgY29tbW9ubHkgdXNlZCwgc28gaXQgbmVlZHMgZml4aW5nLgoKV2hlbiBJ IHRhbGtlZCB0byBBbGV4IGFib3V0IHRoaXMgbGFzdCB3ZSBoYWQgd29ya2VkIG91dCBhIHBhdGNo IHNlcmllcwp0aGF0IGFkZHMgYSB0ZXN0IG9uIHZtX29wcyB0aGF0IHRoZSB2bWEgY2FtZSBmcm9t IHZmaW8gaW4gdGhlIGZpcnN0CnBsYWNlLiBUaGUgVk1BJ3MgY3JlYXRlZCBieSBWRklPIGFyZSAn c2FmZScgYXMgdGhlIFBURXMgYXJlIG5ldmVyIGNoYW5nZWQuCgpKYXNvbgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB001C47095 for ; Thu, 8 Oct 2020 07:21:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C5F12184D for ; Thu, 8 Oct 2020 07:21:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Dz0OOWtV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C5F12184D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC1026EA33; Thu, 8 Oct 2020 07:20:58 +0000 (UTC) Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by gabe.freedesktop.org (Postfix) with ESMTPS id 68D186E029 for ; Wed, 7 Oct 2020 17:39:13 +0000 (UTC) Received: by mail-qk1-x741.google.com with SMTP id d20so3804364qka.5 for ; Wed, 07 Oct 2020 10:39:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=muCEajJ6hDOPl6eL85j4HlmJ9WtV9zWU+bfCV/Cq9BI=; b=Dz0OOWtV09rElfhUKte1coDG1XmH70sU+t7XSvzch8QKv+JqccAMRzt3CfP44+/AfQ BSOmkO0/4DojdkfFvQXoQgyy0jQhFfYLuGtSpIEzw2ZgOz60sA9Vk6P6Joyx8mLM7oVI GulM3GKMb4JRE2TKQ53Eo7+b0LYA9pmvGiN/xhtwvUGDgP8zpeZiK3xp1njllpvHZ6s7 +zEZsvi99NmVaNYy4acbivpnVkuHyfeEWt1WrvUqBOOC668uWgAj9EFU3nanuKQfFrvC NI/B5LDgDV7l6mq+xucfE4i5Vmh8E5S9NLZXdlnDCI7i7X4L/RR/AAH2/qqGFU9zUkKq IF+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=muCEajJ6hDOPl6eL85j4HlmJ9WtV9zWU+bfCV/Cq9BI=; b=F2UXga+jJ49o0EQfc1llIuUFTEDv7Uag2U5D6Y2NSopEY6kGG3BWU3XDH/FbjuPnh5 SUrA+sEhTbfWc3baWPTcx+WiqvGlplglScrgrUTNQ+P37PAkVuubpAOeQcOZXFvZRNu/ vn8n8oEsN4q/f1GSqR/Y7UUa7NZoB7jD8VyKCyXERb+cqBZD++5oaHl51cZYQYy24zZO AY5VftUXevlo22A5X6D+kcUCxycbrOh85A2df7aXh25LGmuhqeEOssu5pf251cm3oZpW J/rafltmVrTQMjW6oxLDv8Y7tEJHIQ7S8R9KcTGXXBiBrAuBSLuvhoBregFErgwj6NiD fncQ== X-Gm-Message-State: AOAM533hRXHkDfK8iNd72yR2aC7N5U2yW+51AE8FPjhJqmaD3GaYNaKh eowQdq2CjcUILm0sM+/tqv3MzA== X-Google-Smtp-Source: ABdhPJwRH/CX2FYRARUgG1+mzIa/QuVNWzg4jQoHZB7NOT97+fmtc0eat9IRh9q/mSpxChFc0Hp56Q== X-Received: by 2002:a05:620a:54f:: with SMTP id o15mr3905794qko.91.1602092352650; Wed, 07 Oct 2020 10:39:12 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id d14sm2013598qtr.62.2020.10.07.10.39.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 10:39:11 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kQDPD-00112O-7o; Wed, 07 Oct 2020 14:39:11 -0300 Date: Wed, 7 Oct 2020 14:39:11 -0300 From: Jason Gunthorpe To: Daniel Vetter Subject: Re: [PATCH 13/13] vfio/type1: Mark follow_pfn as unsafe Message-ID: <20201007173911.GX5177@ziepe.ca> References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-14-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201007164426.1812530-14-daniel.vetter@ffwll.ch> X-Mailman-Approved-At: Thu, 08 Oct 2020 07:20:54 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Jan Kara , Kees Cook , kvm@vger.kernel.org, John Hubbard , Cornelia Huck , LKML , DRI Development , linux-mm@kvack.org, =?utf-8?B?SsOpcsO0bWU=?= Glisse , Alex Williamson , Daniel Vetter , Dan Williams , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCBPY3QgMDcsIDIwMjAgYXQgMDY6NDQ6MjZQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBUaGUgY29kZSBzZWVtcyB0byBzdHVmZiB0aGVzZSBwZm5zIGludG8gaW9tbXUgcHRz IChvciBzb21ldGhpbmcgbGlrZQo+IHRoYXQsIEkgZGlkbid0IGZvbGxvdyksIGJ1dCB0aGVyZSdz IG5vIG1tdV9ub3RpZmllciB0byBlbnN1cmUgdGhhdAo+IGFjY2VzcyBpcyBzeW5jaHJvbml6ZWQg d2l0aCBwdGUgdXBkYXRlcy4KPiAKPiBIZW5jZSBtYXJrIHRoZXNlIGFzIHVuc2FmZS4gVGhpcyBt ZWFucyB0aGF0IHdpdGgKPiBDT05GSUdfU1RSSUNUX0ZPTExPV19QRk4sIHRoZXNlIHdpbGwgYmUg cmVqZWN0ZWQuCj4gCj4gUmVhbCBmaXggaXMgdG8gd2lyZSB1cCBhbiBtbXVfbm90aWZpZXIgLi4u IHNvbWVob3cuIFByb2JhYmx5IG1lYW5zIGFueQo+IGludmFsaWRhdGUgaXMgYSBmYXRhbCBmYXVs dCBmb3IgdGhpcyB2ZmlvIGRldmljZSwgYnV0IHRoZW4gdGhpcwo+IHNob3VsZG4ndCBldmVyIGhh cHBlbiBpZiB1c2Vyc3BhY2UgaXMgcmVhc29uYWJsZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBEYW5p ZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiBDYzogSmFzb24gR3VudGhvcnBl IDxqZ2dAemllcGUuY2E+Cj4gQ2M6IEtlZXMgQ29vayA8a2Vlc2Nvb2tAY2hyb21pdW0ub3JnPgo+ IENjOiBEYW4gV2lsbGlhbXMgPGRhbi5qLndpbGxpYW1zQGludGVsLmNvbT4KPiBDYzogQW5kcmV3 IE1vcnRvbiA8YWtwbUBsaW51eC1mb3VuZGF0aW9uLm9yZz4KPiBDYzogSm9obiBIdWJiYXJkIDxq aHViYmFyZEBudmlkaWEuY29tPgo+IENjOiBKw6lyw7RtZSBHbGlzc2UgPGpnbGlzc2VAcmVkaGF0 LmNvbT4KPiBDYzogSmFuIEthcmEgPGphY2tAc3VzZS5jej4KPiBDYzogRGFuIFdpbGxpYW1zIDxk YW4uai53aWxsaWFtc0BpbnRlbC5jb20+Cj4gQ2M6IGxpbnV4LW1tQGt2YWNrLm9yZwo+IENjOiBs aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBDYzogbGludXgtc2Ftc3VuZy1z b2NAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGxpbnV4LW1lZGlhQHZnZXIua2VybmVsLm9yZwo+IENj OiBBbGV4IFdpbGxpYW1zb24gPGFsZXgud2lsbGlhbXNvbkByZWRoYXQuY29tPgo+IENjOiBDb3Ju ZWxpYSBIdWNrIDxjb2h1Y2tAcmVkaGF0LmNvbT4KPiBDYzoga3ZtQHZnZXIua2VybmVsLm9yZwo+ IC0tLQo+ICBkcml2ZXJzL3ZmaW8vdmZpb19pb21tdV90eXBlMS5jIHwgNCArKy0tCj4gIDEgZmls ZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvdmZpby92ZmlvX2lvbW11X3R5cGUxLmMgYi9kcml2ZXJzL3ZmaW8vdmZpb19p b21tdV90eXBlMS5jCj4gaW5kZXggNWZiZjBjMWY3NDMzLi5hNGQ1M2YzZDBhMzUgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy92ZmlvL3ZmaW9faW9tbXVfdHlwZTEuYwo+ICsrKyBiL2RyaXZlcnMvdmZp by92ZmlvX2lvbW11X3R5cGUxLmMKPiBAQCAtNDIxLDcgKzQyMSw3IEBAIHN0YXRpYyBpbnQgZm9s bG93X2ZhdWx0X3BmbihzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSwgc3RydWN0IG1tX3N0cnVj dCAqbW0sCj4gIHsKPiAgCWludCByZXQ7Cj4gIAo+IC0JcmV0ID0gZm9sbG93X3Bmbih2bWEsIHZh ZGRyLCBwZm4pOwo+ICsJcmV0ID0gdW5zYWZlX2ZvbGxvd19wZm4odm1hLCB2YWRkciwgcGZuKTsK PiAgCWlmIChyZXQpIHsKPiAgCQlib29sIHVubG9ja2VkID0gZmFsc2U7Cj4gIAo+IEBAIC00MzUs NyArNDM1LDcgQEAgc3RhdGljIGludCBmb2xsb3dfZmF1bHRfcGZuKHN0cnVjdCB2bV9hcmVhX3N0 cnVjdCAqdm1hLCBzdHJ1Y3QgbW1fc3RydWN0ICptbSwKPiAgCQlpZiAocmV0KQo+ICAJCQlyZXR1 cm4gcmV0Owo+ICAKPiAtCQlyZXQgPSBmb2xsb3dfcGZuKHZtYSwgdmFkZHIsIHBmbik7Cj4gKwkJ cmV0ID0gdW5zYWZlX2ZvbGxvd19wZm4odm1hLCB2YWRkciwgcGZuKTsKPiAgCX0KClRoaXMgaXMg YWN0dWFsbHkgYmVpbmcgY29tbW9ubHkgdXNlZCwgc28gaXQgbmVlZHMgZml4aW5nLgoKV2hlbiBJ IHRhbGtlZCB0byBBbGV4IGFib3V0IHRoaXMgbGFzdCB3ZSBoYWQgd29ya2VkIG91dCBhIHBhdGNo IHNlcmllcwp0aGF0IGFkZHMgYSB0ZXN0IG9uIHZtX29wcyB0aGF0IHRoZSB2bWEgY2FtZSBmcm9t IHZmaW8gaW4gdGhlIGZpcnN0CnBsYWNlLiBUaGUgVk1BJ3MgY3JlYXRlZCBieSBWRklPIGFyZSAn c2FmZScgYXMgdGhlIFBURXMgYXJlIG5ldmVyIGNoYW5nZWQuCgpKYXNvbgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK