All of lore.kernel.org
 help / color / mirror / Atom feed
* [to-be-updated] mm-frame-vec-use-foll_longterm.patch removed from -mm tree
@ 2020-10-07 21:13 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2020-10-07 21:13 UTC (permalink / raw)
  To: dan.j.williams, daniel.vetter, daniel.vetter, gregkh, inki.dae,
	jack, jgg, jglisse, jhubbard, jy0922.shim, kgene, krzk,
	kyungmin.park, m.szyprowski, mm-commits, oded.gabbay,
	oshpigelman, pawel, ppiskorski, sw0312.kim, tfiga, ttayar


The patch titled
     Subject: mm/frame-vec: use FOLL_LONGTERM
has been removed from the -mm tree.  Its filename was
     mm-frame-vec-use-foll_longterm.patch

This patch was dropped because an updated version will be merged

------------------------------------------------------
From: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: mm/frame-vec: use FOLL_LONGTERM

For $reasons I've stumbled over this code and I'm not sure the change to
the new gup functions in 55a650c35fea ("mm/gup: frame_vector: convert
get_user_pages() --> pin_user_pages()") was entirely correct.

This here is used for long term buffers (not just quick I/O) like RDMA,
and John notes this in his patch.  But I thought the rule for these is
that they need to add FOLL_LONGTERM, which John's patch didn't do.

There is already a dax specific check (added in b7f0554a56f2 ("mm: fail
get_vaddr_frames() for filesystem-dax mappings")), so this seems like the
prudent thing to do.

Link: https://lkml.kernel.org/r/20201002175303.390363-2-daniel.vetter@ffwll.ch
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Jérôme Glisse <jglisse@redhat.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Oded Gabbay <oded.gabbay@gmail.com>
Cc: Omer Shpigelman <oshpigelman@habana.ai>
Cc: Pawel Osciak <pawel@osciak.com>
Cc: Pawel Piskorski <ppiskorski@habana.ai>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Tomasz Figa <tfiga@chromium.org>
Cc: Tomer Tayar <ttayar@habana.ai>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/frame_vector.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/frame_vector.c~mm-frame-vec-use-foll_longterm
+++ a/mm/frame_vector.c
@@ -35,7 +35,7 @@ int get_vaddr_frames(unsigned long start
 {
 	struct mm_struct *mm = current->mm;
 	struct vm_area_struct *vma;
-	unsigned int gup_flags = FOLL_WRITE | FOLL_FORCE;
+	unsigned int gup_flags = FOLL_WRITE | FOLL_FORCE | FOLL_LONGTERM;
 	int ret = 0;
 	int err;
 	int locked;
_

Patches currently in -mm which might be from daniel.vetter@ffwll.ch are



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-10-07 21:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-07 21:13 [to-be-updated] mm-frame-vec-use-foll_longterm.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.