From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E82F4C4363D for ; Wed, 7 Oct 2020 21:37:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 897102083B for ; Wed, 7 Oct 2020 21:37:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GkEtSOQi"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="a+p3YznV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 897102083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ULPg8ViGAGRDBnhPbblUnP6NIj1hmmTkbefD9N6vbdk=; b=GkEtSOQizg24miTKS57DvFil5 40cOd4XDouE5alGZfi4hXa0I7fitnuYaf7R0vrGG4Ei/Kxmdndb8k9MGVEApnW4ZLi2+lFn+mD4Bg EnCkVYgR2xhgJdzUVZzwD/f8gOTgAvqAAV+4qJ+JOei/uaGdEuqBy9C7kNG7dub3Mt5xzHR9vSuzO Vs+TrcvJasIKXbx1ALgSPEEFzXR7HvQFIc3pG9fmNnfECEPlurrt+iNMf9G0b/wXs4V6M47oiKImA sDZXC+/RTtB6C9VZ2l86gtL0Q9EXsiZA3ZnwuEkkhMfRn7w8wQ84tqCsWL0YKtR9qCaDcCKP6FO2t peyz0tzoA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQH6V-000097-I3; Wed, 07 Oct 2020 21:36:07 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQH6Q-0008EL-9o for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 21:36:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6JD9soJE6mhpt0ENUrHc0EsZuRAF8Gp9dkEkndiCBmE=; b=a+p3YznVqxD5RId67TVo0W+uD +z7tbbn4Eb/PwJQwKXfOmAVl82Z4AYEVaT9+gZPMIwvCtu12a6e1jUt7fOkDBBvxJuyjb9W1ihlx5 8iOkhcNScTfENMwKj7TqZRLRujUfc0lT/qB44+bnf/aaicY/ExNgVG1HEVxNySorjRhTSmFX0HByH +i+1g2Lwrt7Ji/Y26UnYuAHr+nQPTd0+hIjMRvmpKSP71qEy8ARBF0xH4Ko97/tgFJPeqjstbo5cI t/2l8HMRrxIx/fvKx5b82FH2RNSSfolUpu0iADNGUALiGqbn/t2JY4ynXGKVF/7LavR7DM9PY2EI1 a1ReVC3HQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:43210) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQH3P-0005We-GK; Wed, 07 Oct 2020 22:32:55 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kQH3N-0000zh-LP; Wed, 07 Oct 2020 22:32:53 +0100 Date: Wed, 7 Oct 2020 22:32:53 +0100 From: Russell King - ARM Linux admin To: Nicolas Pitre Subject: Re: [PATCH v2 2/2] ARM: move device tree mapping out of linear region Message-ID: <20201007213253.GJ1551@shell.armlinux.org.uk> References: <20201007083944.27910-1-ardb@kernel.org> <20201007083944.27910-3-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_173602_469172_BB3051CC X-CRM114-Status: GOOD ( 15.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Linus Walleij , Florian Fainelli , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 07, 2020 at 11:28:03AM -0400, Nicolas Pitre wrote: > On Wed, 7 Oct 2020, Ard Biesheuvel wrote: > > > @@ -1078,13 +1078,18 @@ void __init hyp_mode_check(void) > > void __init setup_arch(char **cmdline_p) > > { > > const struct machine_desc *mdesc = NULL; > > + void *atags_vaddr; > > > > if (__atags_pointer) > > - atags_vaddr = phys_to_virt(__atags_pointer); > > + atags_vaddr = FDT_VIRT_ADDR(__atags_pointer); > > > > setup_processor(); > > - if (atags_vaddr) > > + if (atags_vaddr) { > > mdesc = setup_machine_fdt(atags_vaddr); > > If __atags_pointer is zero, you'll end up with atags_vaddr being > undefined here. I'm surprised the compiler didn't warn about that. The warning has been disabled. See commit 78a5255ffb6a1af189a83e493d916ba1c54d8c75. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel