Hi Matthew,

I love your patch! Yet something to improve:

[auto build test ERROR on vfio/next]
[also build test ERROR on s390/features linus/master kvms390/next v5.9-rc8 next-20201007]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Matthew-Rosato/Pass-zPCI-hardware-information-via-VFIO/20201008-034906
base:   https://github.com/awilliam/linux-vfio.git next
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c09b4427b95cc448fb0ed2a4b3125643dea2bc7b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matthew-Rosato/Pass-zPCI-hardware-information-via-VFIO/20201008-034906
        git checkout c09b4427b95cc448fb0ed2a4b3125643dea2bc7b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from drivers/vfio/pci/vfio_pci.c:31:
>> drivers/vfio/pci/vfio_pci_private.h:223:1: error: expected identifier or '(' before '{' token
     223 | {
         | ^
>> drivers/vfio/pci/vfio_pci_private.h:221:19: warning: 'vfio_pci_info_zdev_add_caps' used but never defined
     221 | static inline int vfio_pci_info_zdev_add_caps(struct vfio_pci_device *vdev,
         |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
--
   In file included from drivers/vfio/pci/vfio_pci_intrs.c:23:
>> drivers/vfio/pci/vfio_pci_private.h:223:1: error: expected identifier or '(' before '{' token
     223 | {
         | ^
   drivers/vfio/pci/vfio_pci_private.h:221:19: warning: 'vfio_pci_info_zdev_add_caps' declared 'static' but never defined [-Wunused-function]
     221 | static inline int vfio_pci_info_zdev_add_caps(struct vfio_pci_device *vdev,
         |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +223 drivers/vfio/pci/vfio_pci_private.h

   216	
   217	#ifdef CONFIG_VFIO_PCI_ZDEV
   218	extern int vfio_pci_info_zdev_add_caps(struct vfio_pci_device *vdev,
   219					       struct vfio_info_cap *caps);
   220	#else
 > 221	static inline int vfio_pci_info_zdev_add_caps(struct vfio_pci_device *vdev,
   222						      struct vfio_info_cap *caps);
 > 223	{
   224		return -ENODEV;
   225	}
   226	#endif
   227	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org