From: Peter Zijlstra <peterz@infradead.org>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
Michael Matz <matz@suse.de>, Dave Jiang <dave.jiang@intel.com>,
Borislav Petkov <bp@suse.de>, Tony Luck <tony.luck@intel.com>,
x86 <x86@kernel.org>,
hjl.tools@gmail.com, linux-toolchains@vger.kernel.org
Subject: Re: [tip: x86/pasid] x86/asm: Carve out a generic movdir64b() helper for general usage
Date: Thu, 8 Oct 2020 08:49:28 +0200 [thread overview]
Message-ID: <20201008064928.GR2628@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20201007211327.GN5607@zn.tnic>
On Wed, Oct 07, 2020 at 11:13:27PM +0200, Borislav Petkov wrote:
> On Wed, Oct 07, 2020 at 07:08:35PM +0200, Peter Zijlstra wrote:
> > (%rdx), %rax, surely?
>
> Right, later. Already tagged the branch so that Vinod can base stuff ontop.
>
> > Also, that's a horrible convention, but I suppose (%rdx), (%rax) was
> > out?
>
> See the end of this mail:
>
> https://lkml.kernel.org/r/alpine.LSU.2.20.2009241356020.20802@wotan.suse.de
That, 100x that. Why wasn't it fixed then? How about we fix binutils to
accept the sane mnemonic as well?
> > Can we pretty please get a binutils version that knows about this
> > instruction, such that we know when we can get rid of the silly .byte
> > encoded mess?
>
> It looks like support for this insn got introduced in this binutils commit:
>
> c0a30a9f0ab4 ("Enable Intel MOVDIRI, MOVDIR64B instructions")
>
> So I guess from 2.31 onwards:
Then we'll just keep the byte code around until we reach the min
binutils that's sane, but at least we can fix the comment to not be
insane.
next prev parent reply other threads:[~2020-10-08 6:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 15:11 [PATCH v7 0/5] Add shared workqueue support for idxd driver Dave Jiang
2020-10-05 15:11 ` [PATCH v7 1/5] x86/asm: Carve out a generic movdir64b() helper for general usage Dave Jiang
2020-10-07 16:14 ` [tip: x86/pasid] " tip-bot2 for Dave Jiang
2020-10-07 17:08 ` Peter Zijlstra
2020-10-07 21:13 ` Borislav Petkov
2020-10-08 6:49 ` Peter Zijlstra [this message]
2020-10-05 15:11 ` [PATCH v7 2/5] x86/asm: Add an enqcmds() wrapper for the ENQCMDS instruction Dave Jiang
2020-10-05 15:11 ` [PATCH v7 3/5] dmaengine: idxd: Add shared workqueue support Dave Jiang
2020-10-05 15:11 ` [PATCH v7 4/5] dmaengine: idxd: Clean up descriptors with fault error Dave Jiang
2020-10-05 15:11 ` [PATCH v7 5/5] dmaengine: idxd: Add ABI documentation for shared wq Dave Jiang
2020-10-07 7:01 ` [PATCH v7 0/5] Add shared workqueue support for idxd driver Vinod Koul
2020-10-07 8:48 ` Borislav Petkov
2020-10-07 9:53 ` Vinod Koul
2020-10-07 10:04 ` Borislav Petkov
2020-10-07 14:57 ` Vinod Koul
2020-10-07 16:16 ` Borislav Petkov
2020-10-07 16:50 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008064928.GR2628@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=dave.jiang@intel.com \
--cc=hjl.tools@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=matz@suse.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.