From: Serg Tereshchenko <serg.partizan@gmail.com>
To: me@yadavpratyush.com
Cc: git@vger.kernel.org, serg.partizan@gmail.com
Subject: Re: [PATCH] git-gui: Basic dark mode support
Date: Thu, 8 Oct 2020 11:24:39 +0300 [thread overview]
Message-ID: <20201008082439.6013-1-serg.partizan@gmail.com> (raw)
In-Reply-To: <20201007110751.237kem2mlnb7hbrk@yadavpratyush.com>
> The commit message could be improved. It should first describe the
> problem it is trying to solve, why it is worth solving, and then tell
> the codebase to fix it. The details of how it is done can be learned
> from the contents of the patch, so they are not as important.
>
> How about the message below?
>
> The colors of some ttext widgets are hard-coded. These hard-coded
> colors are okay with a light theme but with a dark theme some widgets
> are dark colored and the hard-coded ones are still light. This defeats
> the purpose of applying the theme and makes the UI look very awkward.
>
> Remove the hard-coded colors in ttext calls and use colors from the
> theme for those widgets via Text.Background and Text.Foreground from
> the option database.
>
> Similarly, the highlighting for the currently selected file(s) in the
> "Staged Files" and "Unstaged Files" sections is also hard-coded. Pull
> the colors for that from the current theme to make sure it is in line
> with the rest of the theme colors.
>
> No need to resend. I'll use this message when applying unless you have
> any suggestions or objections.
I have no objections, please use this message.
I'll try to write better commit messages in the future.
--
Regards,
Serg Tereshchenko
next prev parent reply other threads:[~2020-10-08 8:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 15:48 [PATCH] git-gui: Basic dark mode support Serg Tereshchenko
2020-08-25 19:01 ` Matthias Aßhauer
2020-09-22 11:04 ` Pratyush Yadav
2020-09-26 14:54 ` [PATCH v2] " Serg Tereshchenko
2020-10-07 11:07 ` Pratyush Yadav
2020-10-08 8:24 ` Serg Tereshchenko [this message]
2020-10-08 13:07 ` Pratyush Yadav
2020-11-21 17:47 ` Stefan Haller
2020-11-22 12:30 ` serg.partizan
2020-11-22 13:32 ` [PATCH] git-gui: Fix selected text colors Serg Tereshchenko
2020-11-22 15:41 ` Stefan Haller
2020-11-22 17:16 ` serg.partizan
2020-11-23 11:48 ` [PATCH] git-gui: use gray selection background for inactive text widgets Stefan Haller
2020-11-23 13:13 ` serg.partizan
2020-11-23 19:03 ` Stefan Haller
2020-11-23 20:08 ` serg.partizan
2020-11-29 17:40 ` Stefan Haller
2020-11-30 13:41 ` serg.partizan
2020-11-30 18:08 ` [PATCH] git-gui: use gray selection background for inactive text?? widgets Pratyush Yadav
2020-11-30 20:18 ` [PATCH] git-gui: use gray selection background for inactive text widgets Stefan Haller
2020-11-30 20:18 ` [PATCH] git-gui: keep showing selection when diff view gets deactivated on Mac Stefan Haller
2020-11-23 19:03 ` [PATCH] git-gui: Fix selected text colors Stefan Haller
2020-11-23 20:50 ` serg.partizan
2020-11-24 21:19 ` Stefan Haller
2020-11-24 21:23 ` [PATCH v2] git-gui: use gray background for inactive text widgets Stefan Haller
2020-12-17 21:49 ` Pratyush Yadav
2020-12-17 22:14 ` Stefan Haller
2020-12-18 12:50 ` Pratyush Yadav
2020-12-18 13:01 ` Stefan Haller
2020-12-18 9:43 ` [PATCH v3] " Stefan Haller
2020-12-18 12:51 ` Pratyush Yadav
2020-12-18 19:46 ` Pratyush Yadav
2020-12-17 20:23 ` [PATCH] git-gui: Fix selected text colors Pratyush Yadav
2020-10-07 11:13 ` [PATCH] git-gui: Basic dark mode support Pratyush Yadav
2020-10-08 8:20 ` Serg Tereshchenko
2020-10-08 8:28 ` Pratyush Yadav
2020-10-08 8:44 ` Serg Tereshchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008082439.6013-1-serg.partizan@gmail.com \
--to=serg.partizan@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@yadavpratyush.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.