From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Pavel Reichl <preichl@redhat.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v9 4/4] xfs: replace mrlock_t with rw_semaphores
Date: Thu, 8 Oct 2020 09:16:39 -0700 [thread overview]
Message-ID: <20201008161639.GP6540@magnolia> (raw)
In-Reply-To: <eebc3029-beb3-5b49-08d4-33ae63085411@redhat.com>
On Thu, Oct 08, 2020 at 03:55:16PM +0200, Pavel Reichl wrote:
>
> >> Hi,
> >>
> >> thanks for the comments, however for some reason I cannot reproduce
> >> the same memory corruption you are getting.
> >
> > <shrug> Do you have full preempt enabled?
>
> Hi, I'm not proud to admit that until now I tested w/o 'CONFIG_PREEMPT=y' :-/
> However at least now I can see the bug you hit and test that the
> proposed change in version #10 fixes that.
<shrug> That just means you get to hit all the stall warnings (which are
fixable with cond_resched()) that I rarely see because preempt kernels
can reschedule at will... :)
>
>
> >
> >> Do you think that moving the 'rwsem_release()' right before the
> >> 'complete()' should fix the problem?
> >>
> >> Something like:
> >>
> >>
> >> + /*
> >> + * Update lockdep's lock ownership information to point to
> >> + * this thread as the thread that scheduled this worker is waiting
> >> + * for it's completion.
> >
> > Nit: "it's" is always a contraction of "it is"; "its" is correct
> > (posessive) form here.
>
> Thanks for noticing. I know the difference...but still I did this
> mistake. I must focus more next time.
No worries, English is a weird language.
"Inflammable means flammable? What a country!"
-- Dr. Nick Riviera
--D
>
> >
> > Otherwise, this looks fine to me.
>
> Thanks, version #10 is on list now.
>
> Bye.
>
prev parent reply other threads:[~2020-10-08 16:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 19:15 [PATCH v9 0/4] xfs: Remove wrappers for some semaphores Pavel Reichl
2020-10-06 19:15 ` [PATCH v9 1/4] xfs: Refactor xfs_isilocked() Pavel Reichl
2020-10-06 19:15 ` [PATCH v9 2/4] xfs: clean up whitespace in xfs_isilocked() calls Pavel Reichl
2020-10-06 19:15 ` [PATCH v9 3/4] xfs: xfs_isilocked() can only check a single lock type Pavel Reichl
2020-10-06 19:15 ` [PATCH v9 4/4] xfs: replace mrlock_t with rw_semaphores Pavel Reichl
2020-10-07 1:21 ` Darrick J. Wong
2020-10-07 14:17 ` Eric Sandeen
2020-10-07 15:25 ` Darrick J. Wong
2020-10-07 21:15 ` Pavel Reichl
2020-10-07 21:55 ` Darrick J. Wong
2020-10-08 13:55 ` Pavel Reichl
2020-10-08 16:16 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008161639.GP6540@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.