From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/fail2ban: fix fail2ban-python symlink
Date: Thu, 8 Oct 2020 22:13:44 +0200 [thread overview]
Message-ID: <20201008221344.1543e09d@windsurf.hq.k.grp> (raw)
In-Reply-To: <20201005055809.24044-1-peter@korsgaard.com>
On Mon, 5 Oct 2020 07:58:08 +0200
Peter Korsgaard <peter@korsgaard.com> wrote:
> Fixes (reproducible):
> http://autobuild.buildroot.net/results/50f/50f199bfe06d054cc6770760e73ac0de594a0670/diffoscope-results.txt
>
> Fail2ban installs the fail2ban-python symlink pointing to the host python
> intepreter used to run setup.py, which is naturally not valid at runtime and
> breaks the reproducible tests as shown in the diffoscope results:
>
> ? -lrwxrwxrwx 0 0 0 0 2020-10-04 10:50:38.000000 ./usr/bin/fail2ban-python -> /home/naourr/work/instance-0/output-1/host/bin/python
> ? +lrwxrwxrwx 0 0 0 0 2020-10-04 10:50:38.000000 ./usr/bin/fail2ban-python -> /home/naourr/work/instance-0/output-2/host/bin/python
>
> As a workaround, update the symlink after installation to point to the
> correct target python.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> package/fail2ban/fail2ban.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
It would have been nicer to have something supported by upstream
fail2ban. I guess like me you looked at the setup.py logic, and
realized that it was too convoluted to find a reasonably simple fix?
So applied to master. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-10-08 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 5:58 [Buildroot] [PATCH] package/fail2ban: fix fail2ban-python symlink Peter Korsgaard
2020-10-08 20:13 ` Thomas Petazzoni [this message]
2020-10-08 21:01 ` Peter Korsgaard
2020-10-10 21:00 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008221344.1543e09d@windsurf.hq.k.grp \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.