From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07443C433E7 for ; Fri, 9 Oct 2020 07:53:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9A2B22267 for ; Fri, 9 Oct 2020 07:53:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729278AbgJIHxq (ORCPT ); Fri, 9 Oct 2020 03:53:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbgJIHxq (ORCPT ); Fri, 9 Oct 2020 03:53:46 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BA3AC0613D2 for ; Fri, 9 Oct 2020 00:53:46 -0700 (PDT) Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQnDc-0002nC-33; Fri, 09 Oct 2020 09:53:36 +0200 Received: from ore by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1kQnDb-0000D2-KW; Fri, 09 Oct 2020 09:53:35 +0200 Date: Fri, 9 Oct 2020 09:53:35 +0200 From: Oleksij Rempel To: Christian Eggers Cc: Oleksij Rempel , Shawn Guo , Sascha Hauer , Fabio Estevam , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , David Laight , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , NXP Linux Team , Pengutronix Kernel Team , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH v5 2/3] i2c: imx: Check for I2SR_IAL after every byte Message-ID: <20201009075335.GC817@pengutronix.de> References: <20201007084524.10835-1-ceggers@arri.de> <20201007084524.10835-3-ceggers@arri.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201007084524.10835-3-ceggers@arri.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:53:03 up 35 days, 22:00, 231 users, load average: 0.34, 1.03, 4.32 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2020 at 10:45:23AM +0200, Christian Eggers wrote: > Arbitration Lost (IAL) can happen after every single byte transfer. If > arbitration is lost, the I2C hardware will autonomously switch from > master mode to slave. If a transfer is not aborted in this state, > consecutive transfers will not be executed by the hardware and will > timeout. > > Signed-off-by: Christian Eggers > Tested (not extensively) on Vybrid VF500 (Toradex VF50): > Tested-by: Krzysztof Kozlowski > Cc: stable@vger.kernel.org Acked-by: Oleksij Rempel Thank you! > --- > drivers/i2c/busses/i2c-imx.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > index cbdcab73a055..63575af41c09 100644 > --- a/drivers/i2c/busses/i2c-imx.c > +++ b/drivers/i2c/busses/i2c-imx.c > @@ -490,6 +490,16 @@ static int i2c_imx_trx_complete(struct imx_i2c_struct *i2c_imx, bool atomic) > dev_dbg(&i2c_imx->adapter.dev, "<%s> Timeout\n", __func__); > return -ETIMEDOUT; > } > + > + /* check for arbitration lost */ > + if (i2c_imx->i2csr & I2SR_IAL) { > + dev_dbg(&i2c_imx->adapter.dev, "<%s> Arbitration lost\n", __func__); > + i2c_imx_clear_irq(i2c_imx, I2SR_IAL); > + > + i2c_imx->i2csr = 0; > + return -EAGAIN; > + } > + > dev_dbg(&i2c_imx->adapter.dev, "<%s> TRX complete\n", __func__); > i2c_imx->i2csr = 0; > return 0; > -- > Christian Eggers > Embedded software developer > > Arnold & Richter Cine Technik GmbH & Co. Betriebs KG > Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918 > Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH > Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477 > Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22B1BC433E7 for ; Fri, 9 Oct 2020 07:55:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A321722267 for ; Fri, 9 Oct 2020 07:55:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZeeBIe9j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A321722267 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1+yBw8+6FHyoPVqas5sCXKwY8aYR+WtOTCBEi4k8qVE=; b=ZeeBIe9jegecFgwMt692uQlVk iLdFVI5e2uC713oGMB0vwFVm924RmZiKYVU3s/qOE58IDnBficozejDxc4QBjNujGaasvGL7JoOD+ yMEjASonIDt4FFwHfom3NhpL9h9DyTCNGiX+xiqLIpjKPLKiH0+25twjk2nJfROFBvtcjmfvAT0vK nlg0gG/lcGpIRwWEBLHllian+5w9fmi5vvPxROziNe/hTLUNgfo0Fl1NcLR6f+qtuHt31R87/EYml JSchk39dlD6ipXvq1FuwLhQGdN74J2ky/7AxwKp5B1dg+Li0x8HLWN61uqGK4gcYH3GWui1j77Ex7 egmH1IVsw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQnDm-0008TW-Jr; Fri, 09 Oct 2020 07:53:46 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQnDj-0008Rz-PE for linux-arm-kernel@lists.infradead.org; Fri, 09 Oct 2020 07:53:44 +0000 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQnDc-0002nC-33; Fri, 09 Oct 2020 09:53:36 +0200 Received: from ore by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1kQnDb-0000D2-KW; Fri, 09 Oct 2020 09:53:35 +0200 Date: Fri, 9 Oct 2020 09:53:35 +0200 From: Oleksij Rempel To: Christian Eggers Subject: Re: [PATCH v5 2/3] i2c: imx: Check for I2SR_IAL after every byte Message-ID: <20201009075335.GC817@pengutronix.de> References: <20201007084524.10835-1-ceggers@arri.de> <20201007084524.10835-3-ceggers@arri.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201007084524.10835-3-ceggers@arri.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:53:03 up 35 days, 22:00, 231 users, load average: 0.34, 1.03, 4.32 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201009_035343_864245_8993D207 X-CRM114-Status: GOOD ( 21.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Oleksij Rempel , David Laight , NXP Linux Team , Pengutronix Kernel Team , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , stable@vger.kernel.org, Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 07, 2020 at 10:45:23AM +0200, Christian Eggers wrote: > Arbitration Lost (IAL) can happen after every single byte transfer. If > arbitration is lost, the I2C hardware will autonomously switch from > master mode to slave. If a transfer is not aborted in this state, > consecutive transfers will not be executed by the hardware and will > timeout. > > Signed-off-by: Christian Eggers > Tested (not extensively) on Vybrid VF500 (Toradex VF50): > Tested-by: Krzysztof Kozlowski > Cc: stable@vger.kernel.org Acked-by: Oleksij Rempel Thank you! > --- > drivers/i2c/busses/i2c-imx.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > index cbdcab73a055..63575af41c09 100644 > --- a/drivers/i2c/busses/i2c-imx.c > +++ b/drivers/i2c/busses/i2c-imx.c > @@ -490,6 +490,16 @@ static int i2c_imx_trx_complete(struct imx_i2c_struct *i2c_imx, bool atomic) > dev_dbg(&i2c_imx->adapter.dev, "<%s> Timeout\n", __func__); > return -ETIMEDOUT; > } > + > + /* check for arbitration lost */ > + if (i2c_imx->i2csr & I2SR_IAL) { > + dev_dbg(&i2c_imx->adapter.dev, "<%s> Arbitration lost\n", __func__); > + i2c_imx_clear_irq(i2c_imx, I2SR_IAL); > + > + i2c_imx->i2csr = 0; > + return -EAGAIN; > + } > + > dev_dbg(&i2c_imx->adapter.dev, "<%s> TRX complete\n", __func__); > i2c_imx->i2csr = 0; > return 0; > -- > Christian Eggers > Embedded software developer > > Arnold & Richter Cine Technik GmbH & Co. Betriebs KG > Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918 > Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH > Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477 > Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel