From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 217E8C433E7 for ; Fri, 9 Oct 2020 08:31:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB91622240 for ; Fri, 9 Oct 2020 08:31:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732477AbgJIIbP (ORCPT ); Fri, 9 Oct 2020 04:31:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732438AbgJIIbP (ORCPT ); Fri, 9 Oct 2020 04:31:15 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E8BEC0613D2 for ; Fri, 9 Oct 2020 01:31:15 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94) (envelope-from ) id 1kQno1-0007i1-Ix; Fri, 09 Oct 2020 10:31:13 +0200 Date: Fri, 9 Oct 2020 10:31:13 +0200 From: Phil Sutter To: Gopal Yadav Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH v2] Solves Bug 1462 - `nft -j list set` does not show counters Message-ID: <20201009083113.GE13016@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Gopal Yadav , netfilter-devel@vger.kernel.org References: <20201007140337.21218-1-gopunop@gmail.com> <20201008170245.GC13016@orbyte.nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Fri, Oct 09, 2020 at 11:15:48AM +0530, Gopal Yadav wrote: > On Thu, Oct 8, 2020 at 10:32 PM Phil Sutter wrote: > > > > On Wed, Oct 07, 2020 at 07:33:37PM +0530, Gopal Yadav wrote: > > > Solves Bug 1462 - `nft -j list set` does not show counters > > > > > > Signed-off-by: Gopal Yadav > > > > Added a comment about potential clashes (json_object_update_missing() > > hides those) and replaced the duplicate subject line by a commit > > message, then applied the result. > > Any description of those potential clashes? AFAICT, none are possible right now. Though the design allows for it and we might miss that. Cheers, Phil