From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCD53C43457 for ; Fri, 9 Oct 2020 12:03:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95C20222B8 for ; Fri, 9 Oct 2020 12:03:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388329AbgJIMDm (ORCPT ); Fri, 9 Oct 2020 08:03:42 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:57010 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726118AbgJIMDm (ORCPT ); Fri, 9 Oct 2020 08:03:42 -0400 Received: from ip5f5af0a0.dynamic.kabel-deutschland.de ([95.90.240.160] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kQr7c-00083q-DF; Fri, 09 Oct 2020 12:03:40 +0000 Date: Fri, 9 Oct 2020 14:03:39 +0200 From: Christian Brauner To: Tommi Rantala Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Christian Brauner Subject: Re: [PATCH 05/13] selftests: pidfd: use ksft_test_result_skip() when skipping test Message-ID: <20201009120339.vcg6vds2frawu7b6@wittgenstein> References: <20201008122633.687877-1-tommi.t.rantala@nokia.com> <20201008122633.687877-6-tommi.t.rantala@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201008122633.687877-6-tommi.t.rantala@nokia.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2020 at 03:26:25PM +0300, Tommi Rantala wrote: > There's planned tests != run tests in pidfd_test when some test is > skipped: > > $ ./pidfd_test > TAP version 13 > 1..8 > [...] > # pidfd_send_signal signal recycled pid test: Skipping test > # Planned tests != run tests (8 != 7) > # Totals: pass:7 fail:0 xfail:0 xpass:0 skip:0 error:0 > > Fix by using ksft_test_result_skip(): > > $ ./pidfd_test > TAP version 13 > 1..8 > [...] > ok 8 # SKIP pidfd_send_signal signal recycled pid test: Unsharing pid namespace not permitted > # Totals: pass:7 fail:0 xfail:0 xpass:0 skip:1 error:0 > > Signed-off-by: Tommi Rantala > --- Thanks, I never got around to fixing this myself. Acked-by: Christian Brauner