From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54DE5C433E7 for ; Fri, 9 Oct 2020 14:42:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AFE520709 for ; Fri, 9 Oct 2020 14:42:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388865AbgJIOmT (ORCPT ); Fri, 9 Oct 2020 10:42:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:45858 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387662AbgJIOmS (ORCPT ); Fri, 9 Oct 2020 10:42:18 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8D67AAF2D; Fri, 9 Oct 2020 14:42:17 +0000 (UTC) Date: Fri, 9 Oct 2020 16:42:15 +0200 From: Joerg Roedel To: Arvind Sankar Cc: x86@kernel.org, Borislav Petkov , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/5] x86/boot/64: Show original faulting address in case of error Message-ID: <20201009144215.GA3302@suse.de> References: <20201008191623.2881677-1-nivedita@alum.mit.edu> <20201008191623.2881677-4-nivedita@alum.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201008191623.2881677-4-nivedita@alum.mit.edu> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2020 at 03:16:21PM -0400, Arvind Sankar wrote: > This makes the #PF handler print the original CR2 value in case of > error, instead of after aligning to PMD_SIZE. > > Signed-off-by: Arvind Sankar > --- > arch/x86/boot/compressed/ident_map_64.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/boot/compressed/ident_map_64.c b/arch/x86/boot/compressed/ident_map_64.c > index 063a60edcf99..fd957b2625e9 100644 > --- a/arch/x86/boot/compressed/ident_map_64.c > +++ b/arch/x86/boot/compressed/ident_map_64.c > @@ -327,9 +327,6 @@ void do_boot_page_fault(struct pt_regs *regs, unsigned long error_code) > > ghcb_fault = sev_es_check_ghcb_fault(address); > > - address &= PMD_MASK; > - end = address + PMD_SIZE; > - > /* > * Check for unexpected error codes. Unexpected are: > * - Faults on present pages > @@ -345,5 +342,8 @@ void do_boot_page_fault(struct pt_regs *regs, unsigned long error_code) > * Error code is sane - now identity map the 2M region around > * the faulting address. > */ > + address &= PMD_MASK; > + end = address + PMD_SIZE; > + > add_identity_map(address, end); > } Reviewed-by: Joerg Roedel