From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: "Pavel Dovgalyuk" <pavel.dovgalyuk@ispras.ru>,
"open list:IDE" <qemu-block@nongnu.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"John Snow" <jsnow@redhat.com>
Subject: [PULL 03/22] hw/ide: restore replay support of IDE
Date: Fri, 9 Oct 2020 17:31:28 +0100 [thread overview]
Message-ID: <20201009163147.28512-4-alex.bennee@linaro.org> (raw)
In-Reply-To: <20201009163147.28512-1-alex.bennee@linaro.org>
A recent change to weak reset handling broke replay due to the use of
aio_bh_schedule_oneshot instead of the replay aware
replay_bh_schedule_oneshot_event.
Fixes: 55adb3c456 ("ide: cancel pending callbacks on SRST")
Suggested-by: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: John Snow <jsnow@redhat.com>
Acked-by: John Snow <jsnow@redhat.com>
Message-Id: <20201007160038.26953-4-alex.bennee@linaro.org>
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 0e32abd779..693b352d5e 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -2289,8 +2289,8 @@ void ide_ctrl_write(void *opaque, uint32_t addr, uint32_t val)
s = &bus->ifs[i];
s->status |= BUSY_STAT;
}
- aio_bh_schedule_oneshot(qemu_get_aio_context(),
- ide_bus_perform_srst, bus);
+ replay_bh_schedule_oneshot_event(qemu_get_aio_context(),
+ ide_bus_perform_srst, bus);
}
bus->cmd = val;
--
2.20.1
next prev parent reply other threads:[~2020-10-09 17:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 16:31 [PULL 00/22] acceptance regressions, testing, gitdm, plugins Alex Bennée
2020-10-09 16:31 ` [PULL 01/22] configure: fix performance regression due to PIC objects Alex Bennée
2020-10-09 16:31 ` [PULL 02/22] hw/misc/mips_cpc: Start vCPU when powered on Alex Bennée
2020-10-09 16:31 ` Alex Bennée [this message]
2020-10-09 16:31 ` [PULL 04/22] cirrus: Fixing and speedup the msys2/mingw CI Alex Bennée
2020-10-09 16:31 ` [PULL 05/22] cirrus: msys2/mingw speed is up, add excluded target back Alex Bennée
2020-10-09 16:31 ` [PULL 06/22] tests/docker: Add genisoimage to the docker file Alex Bennée
2020-10-09 16:31 ` [PULL 07/22] contrib/gitdm: Add more academic domains Alex Bennée
2020-10-09 16:31 ` [PULL 08/22] contrib/gitdm: Add more individual contributors Alex Bennée
2020-10-09 16:31 ` [PULL 09/22] contrib/gitdm: Add Baidu to the domain map Alex Bennée
2020-10-09 16:31 ` [PULL 10/22] contrib/gitdm: Add ByteDance " Alex Bennée
2020-10-09 16:31 ` [PULL 11/22] contrib/gitdm: Add Google " Alex Bennée
2020-10-09 16:31 ` [PULL 12/22] contrib/gitdm: Add Nuvia " Alex Bennée
2020-10-09 16:31 ` [PULL 13/22] contrib/gitdm: Add Qualcomm " Alex Bennée
2020-10-09 16:31 ` [PULL 14/22] contrib/gitdm: Add Nir Soffer to Red Hat domain Alex Bennée
2020-10-09 16:31 ` [PULL 15/22] contrib/gitdm: Add SUSE to the domain map Alex Bennée
2020-10-09 16:31 ` [PULL 16/22] contrib/gitdm: Add Yadro " Alex Bennée
2020-10-09 16:31 ` [PULL 17/22] contrib/gitdm: Add Yandex " Alex Bennée
2020-10-09 16:31 ` [PULL 18/22] .mailmap: Fix more contributor entries Alex Bennée
2020-10-09 16:31 ` [PULL 19/22] plugins: Fixes a issue when dlsym failed, the handle not closed Alex Bennée
2020-10-09 16:31 ` [PULL 20/22] plugin: Fixes compiling errors on msys2/mingw Alex Bennée
2020-10-09 16:31 ` [PULL 21/22] cirrus: use V=1 when running tests on FreeBSD and macOS Alex Bennée
2020-10-09 16:31 ` [PULL 22/22] tests/acceptance: disable machine_rx_gdbsim on GitLab Alex Bennée
2020-10-11 16:20 ` [PULL 00/22] acceptance regressions, testing, gitdm, plugins Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009163147.28512-4-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=jsnow@redhat.com \
--cc=pavel.dovgalyuk@ispras.ru \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.