All of lore.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL tip/core/rcu+preempt] Fix RT raw/non-raw lock ordering
@ 2020-10-01 21:07 Paul E. McKenney
  2020-10-09 16:55 ` Ingo Molnar
  0 siblings, 1 reply; 4+ messages in thread
From: Paul E. McKenney @ 2020-10-01 21:07 UTC (permalink / raw)
  To: tglx, mingo
  Cc: linux-kernel, kernel-team, urezki, lkp, julia.lawall, mhocko,
	mgorman, vbabka, peterz, torvalds

Hello!

This pull request contains Thomas Gleixner's "Make preempt count
unconditional" series [1], but with the addition of a kvfree_rcu() bug-fix
commit making use of this PREEMPT_COUNT addition.  This series reduces
the size of the kernel by almost 100 lines of code and is intended for
the upcoming v5.10 merge window.

Please note that these commits must go in via the -tip tree [2].

The additional bug-fix commit addresses a bug reported by Sebastian
Andrzej Siewior [3].  Please note that with the advent of the new
lockdep Kconfig option CONFIG_PROVE_RAW_LOCK_NESTING, this is now also
a mainline bug.  In happy contrast to the surprisingly large number of
earlier versions of this fix, this version uses only pre-existing kernel
interfaces, and furthermore uses them in conventional ways.

This series has been posted to LKML:

https://lore.kernel.org/lkml/20200928233041.GA23230@paulmck-ThinkPad-P72

It has also been exposed to the kernel test robot and to -next testing.

Changes since the LKML posting are limited to the addition of a comment
block and commit-log changes, the latter including the addition of
a Reviewed-by.  Additional discussion led to an additional two commits
containing small updates, but these two additional commits are deferred
to a later pull request, almost certainly for a later merge window.

							Thanx, Paul

[1]	https://lore.kernel.org/linux-mm/20200914204209.256266093@linutronix.de/
[2]	https://lore.kernel.org/lkml/871riigxp9.fsf@nanos.tec.linutronix.de/
[3]	https://lore.kernel.org/lkml/20200630164543.4mdcf6zb4zfclhln@linutronix.de/

The following changes since commit 856deb866d16e29bd65952e0289066f6078af773:

  Linux 5.9-rc5 (2020-09-13 16:06:00 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/fix-rt

for you to fetch changes up to 849b9c5446ccb0c98c7b11c69f169d22777ab31b:

  kvfree_rcu(): Fix ifnullfree.cocci warnings (2020-10-01 09:07:24 -0700)

----------------------------------------------------------------
Thomas Gleixner (13):
      lib/debug: Remove pointless ARCH_NO_PREEMPT dependencies
      preempt: Make preempt count unconditional
      preempt: Cleanup PREEMPT_COUNT leftovers
      lockdep: Cleanup PREEMPT_COUNT leftovers
      mm/pagemap: Cleanup PREEMPT_COUNT leftovers
      locking/bitspinlock: Cleanup PREEMPT_COUNT leftovers
      uaccess: Cleanup PREEMPT_COUNT leftovers
      sched: Cleanup PREEMPT_COUNT leftovers
      ARM: Cleanup PREEMPT_COUNT leftovers
      xtensa: Cleanup PREEMPT_COUNT leftovers
      drm/i915: Cleanup PREEMPT_COUNT leftovers
      rcutorture: Cleanup PREEMPT_COUNT leftovers
      preempt: Remove PREEMPT_COUNT from Kconfig

Uladzislau Rezki (Sony) (1):
      rcu/tree: Allocate a page when caller is preemptible

kernel test robot (1):
      kvfree_rcu(): Fix ifnullfree.cocci warnings

 arch/arm/include/asm/assembler.h                   | 11 ---
 arch/arm/kernel/iwmmxt.S                           |  2 -
 arch/arm/mach-ep93xx/crunch-bits.S                 |  2 -
 arch/xtensa/kernel/entry.S                         |  2 +-
 drivers/gpu/drm/i915/Kconfig.debug                 |  1 -
 drivers/gpu/drm/i915/i915_utils.h                  |  3 +-
 include/linux/bit_spinlock.h                       |  4 +-
 include/linux/lockdep.h                            |  6 +-
 include/linux/pagemap.h                            |  4 +-
 include/linux/preempt.h                            | 37 ++--------
 include/linux/uaccess.h                            |  6 +-
 kernel/Kconfig.preempt                             |  4 --
 kernel/rcu/tree.c                                  | 79 ++++++++--------------
 kernel/sched/core.c                                |  6 +-
 lib/Kconfig.debug                                  |  3 -
 .../selftests/rcutorture/configs/rcu/SRCU-t        |  1 -
 .../selftests/rcutorture/configs/rcu/SRCU-u        |  1 -
 .../selftests/rcutorture/configs/rcu/TINY01        |  1 -
 .../testing/selftests/rcutorture/doc/TINY_RCU.txt  |  5 +-
 .../selftests/rcutorture/doc/TREE_RCU-kconfig.txt  |  1 -
 .../rcutorture/formal/srcu-cbmc/src/config.h       |  1 -
 21 files changed, 44 insertions(+), 136 deletions(-)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GIT PULL tip/core/rcu+preempt] Fix RT raw/non-raw lock ordering
  2020-10-01 21:07 [GIT PULL tip/core/rcu+preempt] Fix RT raw/non-raw lock ordering Paul E. McKenney
@ 2020-10-09 16:55 ` Ingo Molnar
  2020-10-09 17:13   ` Paul E. McKenney
  0 siblings, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2020-10-09 16:55 UTC (permalink / raw)
  To: Paul E. McKenney
  Cc: tglx, linux-kernel, kernel-team, urezki, lkp, julia.lawall,
	mhocko, mgorman, vbabka, peterz, torvalds


* Paul E. McKenney <paulmck@kernel.org> wrote:

> Hello!
> 
> This pull request contains Thomas Gleixner's "Make preempt count
> unconditional" series [1], but with the addition of a kvfree_rcu() bug-fix
> commit making use of this PREEMPT_COUNT addition.  This series reduces
> the size of the kernel by almost 100 lines of code and is intended for
> the upcoming v5.10 merge window.

> Thomas Gleixner (13):
>       lib/debug: Remove pointless ARCH_NO_PREEMPT dependencies
>       preempt: Make preempt count unconditional
>       preempt: Cleanup PREEMPT_COUNT leftovers
>       lockdep: Cleanup PREEMPT_COUNT leftovers
>       mm/pagemap: Cleanup PREEMPT_COUNT leftovers
>       locking/bitspinlock: Cleanup PREEMPT_COUNT leftovers
>       uaccess: Cleanup PREEMPT_COUNT leftovers
>       sched: Cleanup PREEMPT_COUNT leftovers
>       ARM: Cleanup PREEMPT_COUNT leftovers
>       xtensa: Cleanup PREEMPT_COUNT leftovers
>       drm/i915: Cleanup PREEMPT_COUNT leftovers
>       rcutorture: Cleanup PREEMPT_COUNT leftovers
>       preempt: Remove PREEMPT_COUNT from Kconfig
> 
> Uladzislau Rezki (Sony) (1):
>       rcu/tree: Allocate a page when caller is preemptible
> 
> kernel test robot (1):
>       kvfree_rcu(): Fix ifnullfree.cocci warnings

>  21 files changed, 44 insertions(+), 136 deletions(-)

Pulled into tip:core/rcu, thanks a lot guys!

	Ingo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GIT PULL tip/core/rcu+preempt] Fix RT raw/non-raw lock ordering
  2020-10-09 16:55 ` Ingo Molnar
@ 2020-10-09 17:13   ` Paul E. McKenney
  2020-10-09 18:03     ` Uladzislau Rezki
  0 siblings, 1 reply; 4+ messages in thread
From: Paul E. McKenney @ 2020-10-09 17:13 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: tglx, linux-kernel, kernel-team, urezki, lkp, julia.lawall,
	mhocko, mgorman, vbabka, peterz, torvalds

On Fri, Oct 09, 2020 at 06:55:00PM +0200, Ingo Molnar wrote:
> 
> * Paul E. McKenney <paulmck@kernel.org> wrote:
> 
> > Hello!
> > 
> > This pull request contains Thomas Gleixner's "Make preempt count
> > unconditional" series [1], but with the addition of a kvfree_rcu() bug-fix
> > commit making use of this PREEMPT_COUNT addition.  This series reduces
> > the size of the kernel by almost 100 lines of code and is intended for
> > the upcoming v5.10 merge window.
> 
> > Thomas Gleixner (13):
> >       lib/debug: Remove pointless ARCH_NO_PREEMPT dependencies
> >       preempt: Make preempt count unconditional
> >       preempt: Cleanup PREEMPT_COUNT leftovers
> >       lockdep: Cleanup PREEMPT_COUNT leftovers
> >       mm/pagemap: Cleanup PREEMPT_COUNT leftovers
> >       locking/bitspinlock: Cleanup PREEMPT_COUNT leftovers
> >       uaccess: Cleanup PREEMPT_COUNT leftovers
> >       sched: Cleanup PREEMPT_COUNT leftovers
> >       ARM: Cleanup PREEMPT_COUNT leftovers
> >       xtensa: Cleanup PREEMPT_COUNT leftovers
> >       drm/i915: Cleanup PREEMPT_COUNT leftovers
> >       rcutorture: Cleanup PREEMPT_COUNT leftovers
> >       preempt: Remove PREEMPT_COUNT from Kconfig
> > 
> > Uladzislau Rezki (Sony) (1):
> >       rcu/tree: Allocate a page when caller is preemptible
> > 
> > kernel test robot (1):
> >       kvfree_rcu(): Fix ifnullfree.cocci warnings
> 
> >  21 files changed, 44 insertions(+), 136 deletions(-)
> 
> Pulled into tip:core/rcu, thanks a lot guys!

Thank you, Ingo!!!

							Thanx, Paul

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [GIT PULL tip/core/rcu+preempt] Fix RT raw/non-raw lock ordering
  2020-10-09 17:13   ` Paul E. McKenney
@ 2020-10-09 18:03     ` Uladzislau Rezki
  0 siblings, 0 replies; 4+ messages in thread
From: Uladzislau Rezki @ 2020-10-09 18:03 UTC (permalink / raw)
  To: Paul E. McKenney, Ingo Molnar, Thomas Gleixner
  Cc: Ingo Molnar, tglx, linux-kernel, kernel-team, urezki, lkp,
	julia.lawall, mhocko, mgorman, vbabka, peterz, torvalds

On Fri, Oct 09, 2020 at 10:13:13AM -0700, Paul E. McKenney wrote:
> On Fri, Oct 09, 2020 at 06:55:00PM +0200, Ingo Molnar wrote:
> > 
> > * Paul E. McKenney <paulmck@kernel.org> wrote:
> > 
> > > Hello!
> > > 
> > > This pull request contains Thomas Gleixner's "Make preempt count
> > > unconditional" series [1], but with the addition of a kvfree_rcu() bug-fix
> > > commit making use of this PREEMPT_COUNT addition.  This series reduces
> > > the size of the kernel by almost 100 lines of code and is intended for
> > > the upcoming v5.10 merge window.
> > 
> > > Thomas Gleixner (13):
> > >       lib/debug: Remove pointless ARCH_NO_PREEMPT dependencies
> > >       preempt: Make preempt count unconditional
> > >       preempt: Cleanup PREEMPT_COUNT leftovers
> > >       lockdep: Cleanup PREEMPT_COUNT leftovers
> > >       mm/pagemap: Cleanup PREEMPT_COUNT leftovers
> > >       locking/bitspinlock: Cleanup PREEMPT_COUNT leftovers
> > >       uaccess: Cleanup PREEMPT_COUNT leftovers
> > >       sched: Cleanup PREEMPT_COUNT leftovers
> > >       ARM: Cleanup PREEMPT_COUNT leftovers
> > >       xtensa: Cleanup PREEMPT_COUNT leftovers
> > >       drm/i915: Cleanup PREEMPT_COUNT leftovers
> > >       rcutorture: Cleanup PREEMPT_COUNT leftovers
> > >       preempt: Remove PREEMPT_COUNT from Kconfig
> > > 
> > > Uladzislau Rezki (Sony) (1):
> > >       rcu/tree: Allocate a page when caller is preemptible
> > > 
> > > kernel test robot (1):
> > >       kvfree_rcu(): Fix ifnullfree.cocci warnings
> > 
> > >  21 files changed, 44 insertions(+), 136 deletions(-)
> > 
> > Pulled into tip:core/rcu, thanks a lot guys!
> 
> Thank you, Ingo!!!
> 
> 							Thanx, Paul
Thank you!

--
Vlad Rezki

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-10-09 18:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 21:07 [GIT PULL tip/core/rcu+preempt] Fix RT raw/non-raw lock ordering Paul E. McKenney
2020-10-09 16:55 ` Ingo Molnar
2020-10-09 17:13   ` Paul E. McKenney
2020-10-09 18:03     ` Uladzislau Rezki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.