From: Karsten Graul <kgraul@linux.ibm.com>
To: Pujin Shi <shipujin.t@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Ursula Braun <ubraun@linux.ibm.com>,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, hankinsea@gmail.com
Subject: Re: [PATCH 1/2] net: smc: fix missing brace warning for old compilers
Date: Fri, 9 Oct 2020 20:03:49 +0200 [thread overview]
Message-ID: <20201009200349.9bad6973760905b7d452e67a@linux.ibm.com> (raw)
In-Reply-To: <20201008121929.1270-1-shipujin.t@gmail.com>
On Thu, 8 Oct 2020 20:19:28 +0800
Pujin Shi <shipujin.t@gmail.com> wrote:
> For older versions of gcc, the array = {0}; will cause warnings:
>
> net/smc/smc_llc.c: In function 'smc_llc_send_link_delete_all':
> net/smc/smc_llc.c:1317:9: warning: missing braces around initializer [-Wmissing-braces]
> struct smc_llc_msg_del_link delllc = {0};
> ^
> net/smc/smc_llc.c:1317:9: warning: (near initialization for 'delllc.hd') [-Wmissing-braces]
>
> 1 warnings generated
>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
--
Karsten
next prev parent reply other threads:[~2020-10-09 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 12:19 [PATCH 1/2] net: smc: fix missing brace warning for old compilers Pujin Shi
2020-10-08 12:19 ` [PATCH 2/2] " Pujin Shi
2020-10-09 18:04 ` Karsten Graul
2020-10-09 18:03 ` Karsten Graul [this message]
2020-10-10 17:37 ` [PATCH 1/2] " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009200349.9bad6973760905b7d452e67a@linux.ibm.com \
--to=kgraul@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=hankinsea@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shipujin.t@gmail.com \
--cc=ubraun@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.