From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F024C433E7 for ; Sat, 10 Oct 2020 22:58:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E3942075E for ; Sat, 10 Oct 2020 22:58:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602370727; bh=/M97QDk4dmePHLGMz8L/1LDgfweGz0LFfE/UcKJE7Us=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Ojw8DJBVeAOG8bj3TIdsNo7d3Owk9oGNjMOLuWw9lYNAbjp5iIMcfi5AK17X4wIcA fRzeY9SBMBz3mrvk9uC0GM2ArfwMa+THBnkn8LTUJ1SktUAYpoEcmUwL7ozJ82+ltN Lhma96qIM7J7f0uaSuh4lTFYDFlrvdQFnmBdR6M8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730666AbgJJW6p (ORCPT ); Sat, 10 Oct 2020 18:58:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:56966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731025AbgJJTxO (ORCPT ); Sat, 10 Oct 2020 15:53:14 -0400 Received: from coco.lan (ip5f5ad5ce.dynamic.kabel-deutschland.de [95.90.213.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E166207CD; Sat, 10 Oct 2020 09:24:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602321866; bh=/M97QDk4dmePHLGMz8L/1LDgfweGz0LFfE/UcKJE7Us=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0WfcGZ/NRaNLmDS+jOh+NTKZmtgBMPUVlTwtRgayCgG8fNqT9ga5dKdpSd17V6cdr HukrmYrFiRiZHk4mzgeyyRmliXyLjN62NnFMnyCvZOm9KoAKj1aPSNb/0Gk/GRwb/0 cnkcKxRZlgiEC0lyCm9ojQx8D9uJxVDmS5Ffiehg= Date: Sat, 10 Oct 2020 11:24:16 +0200 From: Mauro Carvalho Chehab To: Daniel Vetter , Linus Torvalds Cc: DRI Development , LKML , kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Daniel Vetter , Jason Gunthorpe , Kees Cook , Dan Williams , Andrew Morton , John Hubbard , =?UTF-8?B?SsOpcsO0bWU=?= Glisse , Jan Kara , Pawel Osciak , Marek Szyprowski , Kyungmin Park , Tomasz Figa , Laurent Dufour , Vlastimil Babka , Daniel Jordan , Michel Lespinasse Subject: Re: [PATCH v2 10/17] media/videbuf1|2: Mark follow_pfn usage as unsafe Message-ID: <20201010112416.4259249a@coco.lan> In-Reply-To: <20201009075934.3509076-11-daniel.vetter@ffwll.ch> References: <20201009075934.3509076-1-daniel.vetter@ffwll.ch> <20201009075934.3509076-11-daniel.vetter@ffwll.ch> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, 9 Oct 2020 09:59:27 +0200 Daniel Vetter escreveu: > The media model assumes that buffers are all preallocated, so that > when a media pipeline is running we never miss a deadline because the > buffers aren't allocated or available. >=20 > This means we cannot fix the v4l follow_pfn usage through > mmu_notifier, without breaking how this all works. The only real fix > is to deprecate userptr support for VM_IO | VM_PFNMAP mappings and > tell everyone to cut over to dma-buf memory sharing for zerocopy. >=20 > userptr for normal memory will keep working as-is. I won't repeat here the discussions for patch 09/17, but just to be clear about this one: NACK. We need a better alternative to avoid breaking existing media applications. >=20 > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Kees Cook > Cc: Dan Williams > Cc: Andrew Morton > Cc: John Hubbard > Cc: J=C3=A9r=C3=B4me Glisse > Cc: Jan Kara > Cc: Dan Williams > Cc: linux-mm@kvack.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-media@vger.kernel.org > Cc: Pawel Osciak > Cc: Marek Szyprowski > Cc: Kyungmin Park > Cc: Tomasz Figa > Cc: Laurent Dufour > Cc: Vlastimil Babka > Cc: Daniel Jordan > Cc: Michel Lespinasse > --- > drivers/media/common/videobuf2/frame_vector.c | 2 +- > drivers/media/v4l2-core/videobuf-dma-contig.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/media/common/videobuf2/frame_vector.c b/drivers/medi= a/common/videobuf2/frame_vector.c > index 2b0b97761d15..a1b85fe9e7c1 100644 > --- a/drivers/media/common/videobuf2/frame_vector.c > +++ b/drivers/media/common/videobuf2/frame_vector.c > @@ -69,7 +69,7 @@ int get_vaddr_frames(unsigned long start, unsigned int = nr_frames, > break; > =20 > while (ret < nr_frames && start + PAGE_SIZE <=3D vma->vm_end) { > - err =3D follow_pfn(vma, start, &nums[ret]); > + err =3D unsafe_follow_pfn(vma, start, &nums[ret]); > if (err) { > if (ret =3D=3D 0) > ret =3D err; > diff --git a/drivers/media/v4l2-core/videobuf-dma-contig.c b/drivers/medi= a/v4l2-core/videobuf-dma-contig.c > index 52312ce2ba05..821c4a76ab96 100644 > --- a/drivers/media/v4l2-core/videobuf-dma-contig.c > +++ b/drivers/media/v4l2-core/videobuf-dma-contig.c > @@ -183,7 +183,7 @@ static int videobuf_dma_contig_user_get(struct videob= uf_dma_contig_memory *mem, > user_address =3D untagged_baddr; > =20 > while (pages_done < (mem->size >> PAGE_SHIFT)) { > - ret =3D follow_pfn(vma, user_address, &this_pfn); > + ret =3D unsafe_follow_pfn(vma, user_address, &this_pfn); > if (ret) > break; > =20 Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94877C433DF for ; Sat, 10 Oct 2020 09:26:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29436207E8 for ; Sat, 10 Oct 2020 09:26:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0/A+tfi0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0WfcGZ/N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29436207E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=60NFhj7Q7SJByJsG+F6vkAG+sz9n4YH7FFv931G+jQM=; b=0/A+tfi08pfy3QcMDVq2MQEf8 5ctoHPtm5cPYwRExUd0jrTKIkRcu9RjPvAbDZNquztka0iqkfYk4/wRjf6XStBJ0H2xlpPDibs3HA 8DTOESHsnMBgazmIuuxIRFlzhup2xEByn1HopXOyz8Vz/lEhpYK7tWzoYyNeSW7HP7UjNOwgZK7VB JutX7wTuQZyDVMEQumfgUDTzFTpNbYnBUqomd6L9vS9Ket73g5vQk04C5A1CvG92qJSaAXbCICOa7 gdtOx/hQ9zawAP1x2cOubbo3siD6QkThiBC26cSkobZk9ULia+FfYIMOngr2RSLkvWW9vWx0uOVgt d8sDpDbmg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRB78-00020P-W3; Sat, 10 Oct 2020 09:24:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRB75-0001zp-PM for linux-arm-kernel@lists.infradead.org; Sat, 10 Oct 2020 09:24:28 +0000 Received: from coco.lan (ip5f5ad5ce.dynamic.kabel-deutschland.de [95.90.213.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E166207CD; Sat, 10 Oct 2020 09:24:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602321866; bh=/M97QDk4dmePHLGMz8L/1LDgfweGz0LFfE/UcKJE7Us=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0WfcGZ/NRaNLmDS+jOh+NTKZmtgBMPUVlTwtRgayCgG8fNqT9ga5dKdpSd17V6cdr HukrmYrFiRiZHk4mzgeyyRmliXyLjN62NnFMnyCvZOm9KoAKj1aPSNb/0Gk/GRwb/0 cnkcKxRZlgiEC0lyCm9ojQx8D9uJxVDmS5Ffiehg= Date: Sat, 10 Oct 2020 11:24:16 +0200 From: Mauro Carvalho Chehab To: Daniel Vetter , Linus Torvalds Subject: Re: [PATCH v2 10/17] media/videbuf1|2: Mark follow_pfn usage as unsafe Message-ID: <20201010112416.4259249a@coco.lan> In-Reply-To: <20201009075934.3509076-11-daniel.vetter@ffwll.ch> References: <20201009075934.3509076-1-daniel.vetter@ffwll.ch> <20201009075934.3509076-11-daniel.vetter@ffwll.ch> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201010_052427_934218_FA2C3BCC X-CRM114-Status: GOOD ( 22.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jan Kara , kvm@vger.kernel.org, DRI Development , linux-mm@kvack.org, Daniel Vetter , Michel Lespinasse , Marek Szyprowski , linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Daniel Jordan , Jason Gunthorpe , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Kees Cook , Pawel Osciak , John Hubbard , =?UTF-8?B?SsOpcsO0bWU=?= Glisse , Dan Williams , Laurent Dufour , Vlastimil Babka , LKML , Tomasz Figa , Kyungmin Park , Andrew Morton Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gRnJpLCAgOSBPY3QgMjAyMCAwOTo1OToyNyArMDIwMApEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGZmd2xsLmNoPiBlc2NyZXZldToKCj4gVGhlIG1lZGlhIG1vZGVsIGFzc3VtZXMgdGhh dCBidWZmZXJzIGFyZSBhbGwgcHJlYWxsb2NhdGVkLCBzbyB0aGF0Cj4gd2hlbiBhIG1lZGlhIHBp cGVsaW5lIGlzIHJ1bm5pbmcgd2UgbmV2ZXIgbWlzcyBhIGRlYWRsaW5lIGJlY2F1c2UgdGhlCj4g YnVmZmVycyBhcmVuJ3QgYWxsb2NhdGVkIG9yIGF2YWlsYWJsZS4KPiAKPiBUaGlzIG1lYW5zIHdl IGNhbm5vdCBmaXggdGhlIHY0bCBmb2xsb3dfcGZuIHVzYWdlIHRocm91Z2gKPiBtbXVfbm90aWZp ZXIsIHdpdGhvdXQgYnJlYWtpbmcgaG93IHRoaXMgYWxsIHdvcmtzLiBUaGUgb25seSByZWFsIGZp eAo+IGlzIHRvIGRlcHJlY2F0ZSB1c2VycHRyIHN1cHBvcnQgZm9yIFZNX0lPIHwgVk1fUEZOTUFQ IG1hcHBpbmdzIGFuZAo+IHRlbGwgZXZlcnlvbmUgdG8gY3V0IG92ZXIgdG8gZG1hLWJ1ZiBtZW1v cnkgc2hhcmluZyBmb3IgemVyb2NvcHkuCj4gCj4gdXNlcnB0ciBmb3Igbm9ybWFsIG1lbW9yeSB3 aWxsIGtlZXAgd29ya2luZyBhcy1pcy4KCkkgd29uJ3QgcmVwZWF0IGhlcmUgdGhlIGRpc2N1c3Np b25zIGZvciBwYXRjaCAwOS8xNywgYnV0Cmp1c3QgdG8gYmUgY2xlYXIgYWJvdXQgdGhpcyBvbmU6 CgpOQUNLLgoKV2UgbmVlZCBhIGJldHRlciBhbHRlcm5hdGl2ZSB0byBhdm9pZCBicmVha2luZyBl eGlzdGluZwptZWRpYSBhcHBsaWNhdGlvbnMuCgo+IAo+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBW ZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+IENjOiBKYXNvbiBHdW50aG9ycGUgPGpn Z0B6aWVwZS5jYT4KPiBDYzogS2VlcyBDb29rIDxrZWVzY29va0BjaHJvbWl1bS5vcmc+Cj4gQ2M6 IERhbiBXaWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29tPgo+IENjOiBBbmRyZXcgTW9y dG9uIDxha3BtQGxpbnV4LWZvdW5kYXRpb24ub3JnPgo+IENjOiBKb2huIEh1YmJhcmQgPGpodWJi YXJkQG52aWRpYS5jb20+Cj4gQ2M6IErDqXLDtG1lIEdsaXNzZSA8amdsaXNzZUByZWRoYXQuY29t Pgo+IENjOiBKYW4gS2FyYSA8amFja0BzdXNlLmN6Pgo+IENjOiBEYW4gV2lsbGlhbXMgPGRhbi5q LndpbGxpYW1zQGludGVsLmNvbT4KPiBDYzogbGludXgtbW1Aa3ZhY2sub3JnCj4gQ2M6IGxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwo+IENjOiBsaW51eC1zYW1zdW5nLXNvY0B2 Z2VyLmtlcm5lbC5vcmcKPiBDYzogbGludXgtbWVkaWFAdmdlci5rZXJuZWwub3JnCj4gQ2M6IFBh d2VsIE9zY2lhayA8cGF3ZWxAb3NjaWFrLmNvbT4KPiBDYzogTWFyZWsgU3p5cHJvd3NraSA8bS5z enlwcm93c2tpQHNhbXN1bmcuY29tPgo+IENjOiBLeXVuZ21pbiBQYXJrIDxreXVuZ21pbi5wYXJr QHNhbXN1bmcuY29tPgo+IENjOiBUb21hc3ogRmlnYSA8dGZpZ2FAY2hyb21pdW0ub3JnPgo+IENj OiBMYXVyZW50IER1Zm91ciA8bGR1Zm91ckBsaW51eC5pYm0uY29tPgo+IENjOiBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6Pgo+IENjOiBEYW5pZWwgSm9yZGFuIDxkYW5pZWwubS5qb3Jk YW5Ab3JhY2xlLmNvbT4KPiBDYzogTWljaGVsIExlc3BpbmFzc2UgPHdhbGtlbkBnb29nbGUuY29t Pgo+IC0tLQo+ICBkcml2ZXJzL21lZGlhL2NvbW1vbi92aWRlb2J1ZjIvZnJhbWVfdmVjdG9yLmMg fCAyICstCj4gIGRyaXZlcnMvbWVkaWEvdjRsMi1jb3JlL3ZpZGVvYnVmLWRtYS1jb250aWcuYyB8 IDIgKy0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvY29tbW9uL3ZpZGVvYnVmMi9mcmFtZV92 ZWN0b3IuYyBiL2RyaXZlcnMvbWVkaWEvY29tbW9uL3ZpZGVvYnVmMi9mcmFtZV92ZWN0b3IuYwo+ IGluZGV4IDJiMGI5Nzc2MWQxNS4uYTFiODVmZTllN2MxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv bWVkaWEvY29tbW9uL3ZpZGVvYnVmMi9mcmFtZV92ZWN0b3IuYwo+ICsrKyBiL2RyaXZlcnMvbWVk aWEvY29tbW9uL3ZpZGVvYnVmMi9mcmFtZV92ZWN0b3IuYwo+IEBAIC02OSw3ICs2OSw3IEBAIGlu dCBnZXRfdmFkZHJfZnJhbWVzKHVuc2lnbmVkIGxvbmcgc3RhcnQsIHVuc2lnbmVkIGludCBucl9m cmFtZXMsCj4gIAkJCWJyZWFrOwo+ICAKPiAgCQl3aGlsZSAocmV0IDwgbnJfZnJhbWVzICYmIHN0 YXJ0ICsgUEFHRV9TSVpFIDw9IHZtYS0+dm1fZW5kKSB7Cj4gLQkJCWVyciA9IGZvbGxvd19wZm4o dm1hLCBzdGFydCwgJm51bXNbcmV0XSk7Cj4gKwkJCWVyciA9IHVuc2FmZV9mb2xsb3dfcGZuKHZt YSwgc3RhcnQsICZudW1zW3JldF0pOwo+ICAJCQlpZiAoZXJyKSB7Cj4gIAkJCQlpZiAocmV0ID09 IDApCj4gIAkJCQkJcmV0ID0gZXJyOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3Y0bDIt Y29yZS92aWRlb2J1Zi1kbWEtY29udGlnLmMgYi9kcml2ZXJzL21lZGlhL3Y0bDItY29yZS92aWRl b2J1Zi1kbWEtY29udGlnLmMKPiBpbmRleCA1MjMxMmNlMmJhMDUuLjgyMWM0YTc2YWI5NiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL21lZGlhL3Y0bDItY29yZS92aWRlb2J1Zi1kbWEtY29udGlnLmMK PiArKysgYi9kcml2ZXJzL21lZGlhL3Y0bDItY29yZS92aWRlb2J1Zi1kbWEtY29udGlnLmMKPiBA QCAtMTgzLDcgKzE4Myw3IEBAIHN0YXRpYyBpbnQgdmlkZW9idWZfZG1hX2NvbnRpZ191c2VyX2dl dChzdHJ1Y3QgdmlkZW9idWZfZG1hX2NvbnRpZ19tZW1vcnkgKm1lbSwKPiAgCXVzZXJfYWRkcmVz cyA9IHVudGFnZ2VkX2JhZGRyOwo+ICAKPiAgCXdoaWxlIChwYWdlc19kb25lIDwgKG1lbS0+c2l6 ZSA+PiBQQUdFX1NISUZUKSkgewo+IC0JCXJldCA9IGZvbGxvd19wZm4odm1hLCB1c2VyX2FkZHJl c3MsICZ0aGlzX3Bmbik7Cj4gKwkJcmV0ID0gdW5zYWZlX2ZvbGxvd19wZm4odm1hLCB1c2VyX2Fk ZHJlc3MsICZ0aGlzX3Bmbik7Cj4gIAkJaWYgKHJldCkKPiAgCQkJYnJlYWs7Cj4gIAoKCgpUaGFu a3MsCk1hdXJvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18CB9C433DF for ; Sat, 10 Oct 2020 09:24:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC656207E8 for ; Sat, 10 Oct 2020 09:24:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0WfcGZ/N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC656207E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3224D6EE65; Sat, 10 Oct 2020 09:24:27 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id E96626EE65 for ; Sat, 10 Oct 2020 09:24:26 +0000 (UTC) Received: from coco.lan (ip5f5ad5ce.dynamic.kabel-deutschland.de [95.90.213.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E166207CD; Sat, 10 Oct 2020 09:24:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602321866; bh=/M97QDk4dmePHLGMz8L/1LDgfweGz0LFfE/UcKJE7Us=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0WfcGZ/NRaNLmDS+jOh+NTKZmtgBMPUVlTwtRgayCgG8fNqT9ga5dKdpSd17V6cdr HukrmYrFiRiZHk4mzgeyyRmliXyLjN62NnFMnyCvZOm9KoAKj1aPSNb/0Gk/GRwb/0 cnkcKxRZlgiEC0lyCm9ojQx8D9uJxVDmS5Ffiehg= Date: Sat, 10 Oct 2020 11:24:16 +0200 From: Mauro Carvalho Chehab To: Daniel Vetter , Linus Torvalds Subject: Re: [PATCH v2 10/17] media/videbuf1|2: Mark follow_pfn usage as unsafe Message-ID: <20201010112416.4259249a@coco.lan> In-Reply-To: <20201009075934.3509076-11-daniel.vetter@ffwll.ch> References: <20201009075934.3509076-1-daniel.vetter@ffwll.ch> <20201009075934.3509076-11-daniel.vetter@ffwll.ch> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jan Kara , kvm@vger.kernel.org, DRI Development , linux-mm@kvack.org, Daniel Vetter , Michel Lespinasse , Marek Szyprowski , linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Daniel Jordan , Jason Gunthorpe , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Kees Cook , Pawel Osciak , John Hubbard , =?UTF-8?B?SsOpcsO0bWU=?= Glisse , Dan Williams , Laurent Dufour , Vlastimil Babka , LKML , Tomasz Figa , Kyungmin Park , Andrew Morton Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" RW0gRnJpLCAgOSBPY3QgMjAyMCAwOTo1OToyNyArMDIwMApEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGZmd2xsLmNoPiBlc2NyZXZldToKCj4gVGhlIG1lZGlhIG1vZGVsIGFzc3VtZXMgdGhh dCBidWZmZXJzIGFyZSBhbGwgcHJlYWxsb2NhdGVkLCBzbyB0aGF0Cj4gd2hlbiBhIG1lZGlhIHBp cGVsaW5lIGlzIHJ1bm5pbmcgd2UgbmV2ZXIgbWlzcyBhIGRlYWRsaW5lIGJlY2F1c2UgdGhlCj4g YnVmZmVycyBhcmVuJ3QgYWxsb2NhdGVkIG9yIGF2YWlsYWJsZS4KPiAKPiBUaGlzIG1lYW5zIHdl IGNhbm5vdCBmaXggdGhlIHY0bCBmb2xsb3dfcGZuIHVzYWdlIHRocm91Z2gKPiBtbXVfbm90aWZp ZXIsIHdpdGhvdXQgYnJlYWtpbmcgaG93IHRoaXMgYWxsIHdvcmtzLiBUaGUgb25seSByZWFsIGZp eAo+IGlzIHRvIGRlcHJlY2F0ZSB1c2VycHRyIHN1cHBvcnQgZm9yIFZNX0lPIHwgVk1fUEZOTUFQ IG1hcHBpbmdzIGFuZAo+IHRlbGwgZXZlcnlvbmUgdG8gY3V0IG92ZXIgdG8gZG1hLWJ1ZiBtZW1v cnkgc2hhcmluZyBmb3IgemVyb2NvcHkuCj4gCj4gdXNlcnB0ciBmb3Igbm9ybWFsIG1lbW9yeSB3 aWxsIGtlZXAgd29ya2luZyBhcy1pcy4KCkkgd29uJ3QgcmVwZWF0IGhlcmUgdGhlIGRpc2N1c3Np b25zIGZvciBwYXRjaCAwOS8xNywgYnV0Cmp1c3QgdG8gYmUgY2xlYXIgYWJvdXQgdGhpcyBvbmU6 CgpOQUNLLgoKV2UgbmVlZCBhIGJldHRlciBhbHRlcm5hdGl2ZSB0byBhdm9pZCBicmVha2luZyBl eGlzdGluZwptZWRpYSBhcHBsaWNhdGlvbnMuCgo+IAo+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBW ZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+IENjOiBKYXNvbiBHdW50aG9ycGUgPGpn Z0B6aWVwZS5jYT4KPiBDYzogS2VlcyBDb29rIDxrZWVzY29va0BjaHJvbWl1bS5vcmc+Cj4gQ2M6 IERhbiBXaWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29tPgo+IENjOiBBbmRyZXcgTW9y dG9uIDxha3BtQGxpbnV4LWZvdW5kYXRpb24ub3JnPgo+IENjOiBKb2huIEh1YmJhcmQgPGpodWJi YXJkQG52aWRpYS5jb20+Cj4gQ2M6IErDqXLDtG1lIEdsaXNzZSA8amdsaXNzZUByZWRoYXQuY29t Pgo+IENjOiBKYW4gS2FyYSA8amFja0BzdXNlLmN6Pgo+IENjOiBEYW4gV2lsbGlhbXMgPGRhbi5q LndpbGxpYW1zQGludGVsLmNvbT4KPiBDYzogbGludXgtbW1Aa3ZhY2sub3JnCj4gQ2M6IGxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwo+IENjOiBsaW51eC1zYW1zdW5nLXNvY0B2 Z2VyLmtlcm5lbC5vcmcKPiBDYzogbGludXgtbWVkaWFAdmdlci5rZXJuZWwub3JnCj4gQ2M6IFBh d2VsIE9zY2lhayA8cGF3ZWxAb3NjaWFrLmNvbT4KPiBDYzogTWFyZWsgU3p5cHJvd3NraSA8bS5z enlwcm93c2tpQHNhbXN1bmcuY29tPgo+IENjOiBLeXVuZ21pbiBQYXJrIDxreXVuZ21pbi5wYXJr QHNhbXN1bmcuY29tPgo+IENjOiBUb21hc3ogRmlnYSA8dGZpZ2FAY2hyb21pdW0ub3JnPgo+IENj OiBMYXVyZW50IER1Zm91ciA8bGR1Zm91ckBsaW51eC5pYm0uY29tPgo+IENjOiBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6Pgo+IENjOiBEYW5pZWwgSm9yZGFuIDxkYW5pZWwubS5qb3Jk YW5Ab3JhY2xlLmNvbT4KPiBDYzogTWljaGVsIExlc3BpbmFzc2UgPHdhbGtlbkBnb29nbGUuY29t Pgo+IC0tLQo+ICBkcml2ZXJzL21lZGlhL2NvbW1vbi92aWRlb2J1ZjIvZnJhbWVfdmVjdG9yLmMg fCAyICstCj4gIGRyaXZlcnMvbWVkaWEvdjRsMi1jb3JlL3ZpZGVvYnVmLWRtYS1jb250aWcuYyB8 IDIgKy0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvY29tbW9uL3ZpZGVvYnVmMi9mcmFtZV92 ZWN0b3IuYyBiL2RyaXZlcnMvbWVkaWEvY29tbW9uL3ZpZGVvYnVmMi9mcmFtZV92ZWN0b3IuYwo+ IGluZGV4IDJiMGI5Nzc2MWQxNS4uYTFiODVmZTllN2MxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv bWVkaWEvY29tbW9uL3ZpZGVvYnVmMi9mcmFtZV92ZWN0b3IuYwo+ICsrKyBiL2RyaXZlcnMvbWVk aWEvY29tbW9uL3ZpZGVvYnVmMi9mcmFtZV92ZWN0b3IuYwo+IEBAIC02OSw3ICs2OSw3IEBAIGlu dCBnZXRfdmFkZHJfZnJhbWVzKHVuc2lnbmVkIGxvbmcgc3RhcnQsIHVuc2lnbmVkIGludCBucl9m cmFtZXMsCj4gIAkJCWJyZWFrOwo+ICAKPiAgCQl3aGlsZSAocmV0IDwgbnJfZnJhbWVzICYmIHN0 YXJ0ICsgUEFHRV9TSVpFIDw9IHZtYS0+dm1fZW5kKSB7Cj4gLQkJCWVyciA9IGZvbGxvd19wZm4o dm1hLCBzdGFydCwgJm51bXNbcmV0XSk7Cj4gKwkJCWVyciA9IHVuc2FmZV9mb2xsb3dfcGZuKHZt YSwgc3RhcnQsICZudW1zW3JldF0pOwo+ICAJCQlpZiAoZXJyKSB7Cj4gIAkJCQlpZiAocmV0ID09 IDApCj4gIAkJCQkJcmV0ID0gZXJyOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3Y0bDIt Y29yZS92aWRlb2J1Zi1kbWEtY29udGlnLmMgYi9kcml2ZXJzL21lZGlhL3Y0bDItY29yZS92aWRl b2J1Zi1kbWEtY29udGlnLmMKPiBpbmRleCA1MjMxMmNlMmJhMDUuLjgyMWM0YTc2YWI5NiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL21lZGlhL3Y0bDItY29yZS92aWRlb2J1Zi1kbWEtY29udGlnLmMK PiArKysgYi9kcml2ZXJzL21lZGlhL3Y0bDItY29yZS92aWRlb2J1Zi1kbWEtY29udGlnLmMKPiBA QCAtMTgzLDcgKzE4Myw3IEBAIHN0YXRpYyBpbnQgdmlkZW9idWZfZG1hX2NvbnRpZ191c2VyX2dl dChzdHJ1Y3QgdmlkZW9idWZfZG1hX2NvbnRpZ19tZW1vcnkgKm1lbSwKPiAgCXVzZXJfYWRkcmVz cyA9IHVudGFnZ2VkX2JhZGRyOwo+ICAKPiAgCXdoaWxlIChwYWdlc19kb25lIDwgKG1lbS0+c2l6 ZSA+PiBQQUdFX1NISUZUKSkgewo+IC0JCXJldCA9IGZvbGxvd19wZm4odm1hLCB1c2VyX2FkZHJl c3MsICZ0aGlzX3Bmbik7Cj4gKwkJcmV0ID0gdW5zYWZlX2ZvbGxvd19wZm4odm1hLCB1c2VyX2Fk ZHJlc3MsICZ0aGlzX3Bmbik7Cj4gIAkJaWYgKHJldCkKPiAgCQkJYnJlYWs7Cj4gIAoKCgpUaGFu a3MsCk1hdXJvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=