All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Damien Hedde" <damien.hedde@greensocs.com>,
	"Huacai Chen" <zltjiangshi@gmail.com>,
	"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Luc Michel" <luc@lmichel.fr>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Paul Burton" <paulburton@kernel.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Huacai Chen" <chenhc@lemote.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v3 00/20] hw/mips: Set CPU frequency
Date: Sat, 10 Oct 2020 22:42:59 +0200	[thread overview]
Message-ID: <20201010204319.3119239-1-f4bug@amsat.org> (raw)

Since v2:
- Renamed "clk" -> "clk-in"
- Renamed "cpuclk-out -> "cpu-refclk"

Missing review: patches 6-20

~~~

All the MIPS cores emulated by QEMU provides the Coproc#0
'Count' register which can be used as a free running timer.

Since it's introduction in 2005 this timer uses a fixed
frequency of 100 MHz (for a CPU freq of 200 MHz).
While this is not an issue with Linux guests, it makes
some firmwares behave incorrectly.

The Clock API allow propagating clocks. It is particularly
useful when hardware dynamicly changes clock frequencies.

To be able to model such MIPS hardware, we need to refactor
the MIPS hardware code to handle clocks.

This series is organized as follow:

1/ qdev/clock patches already reviewed but not merged

2/ refactor the CP0 timer period to allow dynamic changes

3/ MIPS CPU get an optional input clock

4/ set correct CPU frequencies to all boards

I used a MIPSsim test suggested by Thomas.
The test is available on the list:
https://mid.mail-archive.com/20200928171539.788309-17-f4bug@amsat.org

Possible follow up:
- QOM'ify the GIC
- let the GIC handle dynamic clock changes

Regards,

Phil.

Luc Michel (1):
  hw/core/clock: add the clock_new helper function

Philippe Mathieu-Daudé (19):
  util/cutils: Introduce freq_to_str() to display Hertz units
  qdev-monitor: Display frequencies scaled to SI unit
  hw/qdev-clock: Display error hint when clock is missing from device
  target/mips: Move cpu_mips_get_random() with CP0 helpers
  target/mips/cp0_timer: Explicit unit in variable name
  target/mips/cp0_timer: Document TIMER_PERIOD origin
  target/mips: Move cp0_count_ns to CPUMIPSState
  target/mips/cpu: Calculate the CP0 timer period using the CPU
    frequency
  target/mips/cpu: Make cp0_count_rate a property
  target/mips/cpu: Allow the CPU to use dynamic frequencies
  hw/mips/r4k: Explicit CPU frequency is 200 MHz
  hw/mips/fuloong2e: Set CPU frequency to 533 MHz
  hw/mips/mipssim: Correct CPU frequency
  hw/mips/jazz: Correct CPU frequencies
  hw/mips/cps: Expose input clock and connect it to CPU cores
  hw/mips/boston: Set CPU frequency to 1 GHz
  hw/mips/malta: Set CPU frequency to 320 MHz
  hw/mips/cps: Do not allow use without input clock
  target/mips/cpu: Display warning when CPU is used without input clock

 include/hw/clock.h       | 13 ++++++++++
 include/hw/mips/cps.h    |  2 ++
 include/qemu/cutils.h    | 12 ++++++++++
 target/mips/cpu.h        | 14 +++++++++++
 target/mips/internal.h   |  2 +-
 hw/core/clock.c          | 15 ++++++++++++
 hw/core/qdev-clock.c     | 11 +++++++++
 hw/mips/boston.c         | 13 ++++++++++
 hw/mips/cps.c            |  9 +++++++
 hw/mips/fuloong2e.c      |  8 ++++++-
 hw/mips/jazz.c           | 16 ++++++++++++-
 hw/mips/malta.c          | 20 +++++++++++++---
 hw/mips/mipssim.c        | 12 +++++++++-
 hw/mips/r4k.c            |  8 ++++++-
 qdev-monitor.c           |  8 ++++---
 target/mips/cp0_helper.c | 25 ++++++++++++++++++++
 target/mips/cp0_timer.c  | 51 ++++++++++------------------------------
 target/mips/cpu.c        | 42 ++++++++++++++++++++++++++++++++-
 util/cutils.c            | 14 +++++++++++
 19 files changed, 245 insertions(+), 50 deletions(-)

-- 
2.26.2



             reply	other threads:[~2020-10-10 20:46 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-10 20:42 Philippe Mathieu-Daudé [this message]
2020-10-10 20:43 ` [PATCH v3 01/20] util/cutils: Introduce freq_to_str() to display Hertz units Philippe Mathieu-Daudé
2020-10-10 20:43 ` [PATCH v3 02/20] qdev-monitor: Display frequencies scaled to SI unit Philippe Mathieu-Daudé
2020-10-10 20:43 ` [PATCH v3 03/20] hw/qdev-clock: Display error hint when clock is missing from device Philippe Mathieu-Daudé
2020-10-10 20:43 ` [PATCH v3 04/20] hw/core/clock: add the clock_new helper function Philippe Mathieu-Daudé
2020-10-10 20:43 ` [PATCH v3 05/20] target/mips: Move cpu_mips_get_random() with CP0 helpers Philippe Mathieu-Daudé
2020-10-12  7:35   ` Luc Michel
2020-10-10 20:43 ` [PATCH v3 06/20] target/mips/cp0_timer: Explicit unit in variable name Philippe Mathieu-Daudé
2020-10-10 20:43 ` [PATCH v3 07/20] target/mips/cp0_timer: Document TIMER_PERIOD origin Philippe Mathieu-Daudé
2020-10-10 20:43 ` [PATCH v3 08/20] target/mips: Move cp0_count_ns to CPUMIPSState Philippe Mathieu-Daudé
2020-10-12  5:42   ` Jiaxun Yang
2020-10-10 20:43 ` [PATCH v3 09/20] target/mips/cpu: Calculate the CP0 timer period using the CPU frequency Philippe Mathieu-Daudé
2020-10-12  5:48   ` Jiaxun Yang
2020-10-10 20:43 ` [PATCH v3 10/20] target/mips/cpu: Make cp0_count_rate a property Philippe Mathieu-Daudé
2020-10-10 20:43 ` [PATCH v3 11/20] target/mips/cpu: Allow the CPU to use dynamic frequencies Philippe Mathieu-Daudé
2020-10-10 20:43 ` [PATCH v3 12/20] hw/mips/r4k: Explicit CPU frequency is 200 MHz Philippe Mathieu-Daudé
2020-10-11  3:52   ` chen huacai
2020-10-12  8:34     ` Philippe Mathieu-Daudé
2020-10-21 12:38       ` Igor Mammedov
2020-10-10 20:43 ` [PATCH v3 13/20] hw/mips/fuloong2e: Set CPU frequency to 533 MHz Philippe Mathieu-Daudé
2020-10-12  5:54   ` Jiaxun Yang
2020-10-10 20:43 ` [PATCH v3 14/20] hw/mips/mipssim: Correct CPU frequency Philippe Mathieu-Daudé
2020-10-10 20:43 ` [PATCH v3 15/20] hw/mips/jazz: Correct CPU frequencies Philippe Mathieu-Daudé
2020-10-10 20:43 ` [PATCH v3 16/20] hw/mips/cps: Expose input clock and connect it to CPU cores Philippe Mathieu-Daudé
2020-10-10 20:43 ` [PATCH v3 17/20] hw/mips/boston: Set CPU frequency to 1 GHz Philippe Mathieu-Daudé
2020-10-10 20:43 ` [PATCH v3 18/20] hw/mips/malta: Set CPU frequency to 320 MHz Philippe Mathieu-Daudé
2020-10-10 20:43 ` [PATCH v3 19/20] hw/mips/cps: Do not allow use without input clock Philippe Mathieu-Daudé
2020-10-10 20:43 ` [PATCH v3 20/20] target/mips/cpu: Display warning when CPU is used " Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201010204319.3119239-1-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=chenhc@lemote.com \
    --cc=damien.hedde@greensocs.com \
    --cc=ehabkost@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=luc@lmichel.fr \
    --cc=paulburton@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=zltjiangshi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.