All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	qemu-ppc@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"David Gibson" <david@gibson.dropbear.id.au>
Subject: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set
Date: Sun, 11 Oct 2020 21:03:32 +0200	[thread overview]
Message-ID: <20201011190332.3189611-1-f4bug@amsat.org> (raw)

The Grackle PCI host model expects the interrupt controller
being set, but does not verify it is present. Add a check to
help developers using this model.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/pci-host/grackle.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/pci-host/grackle.c b/hw/pci-host/grackle.c
index 57c29b20afb..20361d215ca 100644
--- a/hw/pci-host/grackle.c
+++ b/hw/pci-host/grackle.c
@@ -76,6 +76,10 @@ static void grackle_realize(DeviceState *dev, Error **errp)
     GrackleState *s = GRACKLE_PCI_HOST_BRIDGE(dev);
     PCIHostState *phb = PCI_HOST_BRIDGE(dev);
 
+    if (!s->pic) {
+        error_setg(errp, TYPE_GRACKLE_PCI_HOST_BRIDGE ": 'pic' link not set");
+        return;
+    }
     phb->bus = pci_register_root_bus(dev, NULL,
                                      pci_grackle_set_irq,
                                      pci_grackle_map_irq,
-- 
2.26.2



             reply	other threads:[~2020-10-11 19:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-11 19:03 Philippe Mathieu-Daudé [this message]
2020-10-11 22:34 ` [PATCH] hw/pci-host/grackle: Verify PIC link is properly set David Gibson
2020-10-12  6:21   ` Philippe Mathieu-Daudé
2020-10-12  6:54     ` David Gibson
2020-10-12 11:50       ` BALATON Zoltan via
2020-10-12 12:00         ` Philippe Mathieu-Daudé
2020-10-19  7:50           ` Markus Armbruster
2020-10-19 11:11             ` BALATON Zoltan via
2020-10-19 14:00               ` Markus Armbruster
2020-10-19 14:38                 ` Mark Cave-Ayland
2020-10-19 16:17                   ` BALATON Zoltan via
2020-10-20  5:30                   ` Markus Armbruster
2020-10-20 11:37                     ` BALATON Zoltan via
2020-10-21  3:31                       ` Markus Armbruster
2020-10-21 10:21                         ` BALATON Zoltan via
2020-10-12  9:23 ` Mark Cave-Ayland
2020-10-12 12:01   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201011190332.3189611-1-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.