From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20358C433E7 for ; Mon, 12 Oct 2020 00:12:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF9872173E for ; Mon, 12 Oct 2020 00:12:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602461562; bh=7mB11WGz2b7XbnZ+rHX5lvSu70OQ/30FveyKPnDiIso=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=WaIb1XZ+IHMCwWL7lemRyZiFT1t9Yr1hbECwlef6RFRgHcp2CDal/IdPSwCzFCu2k VDvv3gk2sXAQtQgT8rIvrDzMMsvSwNBBFXzIGzGciXHzolRkAk7EO3iqDTNkhW87+a VrPX1+/ECREA+690ECejIowQExIfBe1WF+4fBITc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726477AbgJLAMl (ORCPT ); Sun, 11 Oct 2020 20:12:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:55592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725962AbgJLAMl (ORCPT ); Sun, 11 Oct 2020 20:12:41 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE4E1208B6; Mon, 12 Oct 2020 00:12:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602461561; bh=7mB11WGz2b7XbnZ+rHX5lvSu70OQ/30FveyKPnDiIso=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F2ykPiMNJIBmld1WIg/uIRvr0/jM2kOR2K48RHpJzhXwkFNwRyrhI1/SWSxIvsySX ZQ70luDghF8V0pTs1zDr/krXWv1ETORhH34YTJvRjCDjhnPoal8VIgDEzGlTtfPh3P fTjQZA/YGFKaaWHdzzlNp8VFsJnTVgiIORcU4z4M= Date: Mon, 12 Oct 2020 09:12:36 +0900 From: Masami Hiramatsu To: Josh Poimboeuf Cc: Borislav Petkov , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org, Martin Schwidefsky , Vasily Gorbik , Masami Hiramatsu , x86 Subject: Re: [tip: objtool/core] x86/insn: Support big endian cross-compiles Message-Id: <20201012091236.0f9a64bfedb8825732b65ea5@kernel.org> In-Reply-To: <20201010174415.zwopoy6vpficoqlr@treble> References: <160208761921.7002.1321765913567405137.tip-bot2@tip-bot2> <20201009203822.GA2974@worktop.programming.kicks-ass.net> <20201009204921.GB21731@zn.tnic> <20201010174415.zwopoy6vpficoqlr@treble> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 10 Oct 2020 12:44:15 -0500 Josh Poimboeuf wrote: > On Fri, Oct 09, 2020 at 10:49:21PM +0200, Borislav Petkov wrote: > > On Fri, Oct 09, 2020 at 10:38:22PM +0200, Peter Zijlstra wrote: > > > On Wed, Oct 07, 2020 at 04:20:19PM -0000, tip-bot2 for Martin Schwidefsky wrote: > > > > The following commit has been merged into the objtool/core branch of tip: > > > > > > > > Commit-ID: 2a522b53c47051d3bf98748418f4f8e5f20d2c04 > > > > Gitweb: https://git.kernel.org/tip/2a522b53c47051d3bf98748418f4f8e5f20d2c04 > > > > Author: Martin Schwidefsky > > > > AuthorDate: Mon, 05 Oct 2020 17:50:31 +02:00 > > > > Committer: Josh Poimboeuf > > > > CommitterDate: Tue, 06 Oct 2020 09:32:29 -05:00 > > > > > > > > x86/insn: Support big endian cross-compiles > > > > > > > > x86 instruction decoder code is shared across the kernel source and the > > > > tools. Currently objtool seems to be the only tool from build tools needed > > > > which breaks x86 cross compilation on big endian systems. Make the x86 > > > > instruction decoder build host endianness agnostic to support x86 cross > > > > compilation and enable objtool to implement endianness awareness for > > > > big endian architectures support. > > > > > > > > Signed-off-by: Martin Schwidefsky > > > > Co-developed-by: Vasily Gorbik > > > > Signed-off-by: Vasily Gorbik > > > > Acked-by: Masami Hiramatsu > > > > Signed-off-by: Josh Poimboeuf > > > > > > This commit breaks the x86 build with CONFIG_X86_DECODER_SELFTEST=y. > > > > > > I've asked Boris to truncate tip/objtool/core. > > > > Yeah, top 4 are gone until this is resolved. > > Masami, I wonder if we even need these selftests anymore? Objtool > already decodes the entire kernel. No, they have different roles. The selftest checks if the decoder works correctly by comparing with the output of objdump. As far as I can see, the objtool relies on the sanity of the decoder (it trusts the output of the decoder). Thank you, -- Masami Hiramatsu