All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Jonathan Corbet <corbet@lwn.net>, Huacai Chen <chenhc@lemote.com>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH v2 1/4 RESEND] MIPS: Loongson64: Select SMP in Kconfig to avoid build error
Date: Mon, 12 Oct 2020 12:34:47 +0200	[thread overview]
Message-ID: <20201012103447.GA7953@alpha.franken.de> (raw)
In-Reply-To: <1602373674-4579-2-git-send-email-yangtiezhu@loongson.cn>

On Sun, Oct 11, 2020 at 07:47:51AM +0800, Tiezhu Yang wrote:
> In the current code, CONFIG_SMP can be set as N by user on the Loongson
> platform, then there exists the following build error under !CONFIG_SMP:
> 
>   CC      arch/mips/kernel/asm-offsets.s
> In file included from ./include/linux/gfp.h:9:0,
>                  from ./include/linux/xarray.h:14,
>                  from ./include/linux/radix-tree.h:18,
>                  from ./include/linux/fs.h:15,
>                  from ./include/linux/compat.h:17,
>                  from arch/mips/kernel/asm-offsets.c:12:
> ./include/linux/topology.h: In function 'numa_node_id':
> ./include/linux/topology.h:119:2: error: implicit declaration of function 'cpu_logical_map' [-Werror=implicit-function-declaration]
>   return cpu_to_node(raw_smp_processor_id());
>   ^
> cc1: some warnings being treated as errors
> scripts/Makefile.build:117: recipe for target 'arch/mips/kernel/asm-offsets.s' failed
> make[1]: *** [arch/mips/kernel/asm-offsets.s] Error 1
> 
> Select SMP in Kconfig to avoid the above build error and then remove
> CONFIG_SMP=y in loongson3_defconfig.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> 
> v2: no changes
> 
>  arch/mips/Kconfig                     | 1 +
>  arch/mips/configs/loongson3_defconfig | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

  reply	other threads:[~2020-10-12 10:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-10 23:47 [PATCH v2 0/4 RESEND] Avoid build error, clean up numa.c and add /proc/boardinfo Tiezhu Yang
2020-10-10 23:47 ` [PATCH v2 1/4 RESEND] MIPS: Loongson64: Select SMP in Kconfig to avoid build error Tiezhu Yang
2020-10-12 10:34   ` Thomas Bogendoerfer [this message]
2020-10-10 23:47 ` [PATCH v2 2/4 RESEND] MIPS: Loongson64: Clean up numa.c Tiezhu Yang
2020-10-12 10:35   ` Thomas Bogendoerfer
2020-10-10 23:47 ` [PATCH v2 3/4 RESEND] MIPS: Loongson64: Add /proc/boardinfo Tiezhu Yang
2020-10-12 10:38   ` Thomas Bogendoerfer
2020-10-12 12:02     ` Tiezhu Yang
2020-10-13  0:15       ` Jiaxun Yang
2020-10-13  4:36         ` Tiezhu Yang
2020-10-10 23:47 ` [PATCH v2 4/4 RESEND] docs: fs: proc.rst: Add boardinfo description for Loongson64 Tiezhu Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201012103447.GA7953@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=chenhc@lemote.com \
    --cc=corbet@lwn.net \
    --cc=jiaxun.yang@flygoat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=lixuefeng@loongson.cn \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.