From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B3DFC433DF for ; Mon, 12 Oct 2020 13:39:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2A0822228 for ; Mon, 12 Oct 2020 13:39:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602509973; bh=GkOMpC5CUxYJCOqEkfVRc5sXMlNtcpjKJbB0wcH/COY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ePYX+bZfXR/w9hNg1jkg6+l43J+7qjwMS3zJWKBLqr7Ya4dbVjW3ak/VyRN29G4lC bvtaxchNkPLEwniuQSL5DvSKIMnSvlZcNaQVX5bPpuq+zi683b6lfQlxJJgQsOqEWY jVXbfIF4A4+nTsAIRsgHiF3jyQZyTQCf9pRDT/nA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731396AbgJLNjc (ORCPT ); Mon, 12 Oct 2020 09:39:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:40186 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731248AbgJLNio (ORCPT ); Mon, 12 Oct 2020 09:38:44 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E563222251; Mon, 12 Oct 2020 13:38:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602509919; bh=GkOMpC5CUxYJCOqEkfVRc5sXMlNtcpjKJbB0wcH/COY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JXN7oU9luvbbxEiT2gOSld/Ea9LDJm7wssv4xp+g18ql2Aof/H0OyTfsf3AY5n+4a wxJfmkktiZmgpCbNpmVQnvg3AIi8aNncg9mRviYNspoEarBXvpqYRY+waD3J10S80k yclwtHu0YALZuGNuTtRmVA18A+fXHD5iHfnKh82A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miquel Raynal , Nobuhiro Iwamatsu Subject: [PATCH 4.19 15/49] mtd: rawnand: sunxi: Fix the probe error path Date: Mon, 12 Oct 2020 15:27:01 +0200 Message-Id: <20201012132630.145283046@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201012132629.469542486@linuxfoundation.org> References: <20201012132629.469542486@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miquel Raynal commit 3d84515ffd8fb657e10fa5b1215e9f095fa7efca upstream. nand_release() is supposed be called after MTD device registration. Here, only nand_scan() happened, so use nand_cleanup() instead. Fixes: 1fef62c1423b ("mtd: nand: add sunxi NAND flash controller support") Signed-off-by: Miquel Raynal Cc: stable@vger.kernel.org Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-54-miquel.raynal@bootlin.com Signed-off-by: Nobuhiro Iwamatsu Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/nand/raw/sunxi_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mtd/nand/raw/sunxi_nand.c +++ b/drivers/mtd/nand/raw/sunxi_nand.c @@ -1947,7 +1947,7 @@ static int sunxi_nand_chip_init(struct d ret = mtd_device_register(mtd, NULL, 0); if (ret) { dev_err(dev, "failed to register mtd device: %d\n", ret); - nand_release(nand); + nand_cleanup(nand); return ret; }