From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AFA4C43457 for ; Mon, 12 Oct 2020 13:39:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 117B521BE5 for ; Mon, 12 Oct 2020 13:39:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602509957; bh=rvnjSrMEECJgoM3x7gvKWcniaay8WsK1fAvGitthpDk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lo5CSD/DjxiLxi+xvzI+3ny10owUUZcfjlpbR5esKNNXBcDOS/UKNtMxUUXfCbnqD YuaFAiDMPdSfkz2shvNclzMoi/kzsR2+TZINorHjcDMymRxX7m6pHBPdEBJaLVOJwQ GUUE98wIQhKRSpn7UnVbAGWQQRsWKoBbfXqNHbfM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731358AbgJLNjQ (ORCPT ); Mon, 12 Oct 2020 09:39:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:42522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731286AbgJLNiy (ORCPT ); Mon, 12 Oct 2020 09:38:54 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DFDBD206D9; Mon, 12 Oct 2020 13:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602509933; bh=rvnjSrMEECJgoM3x7gvKWcniaay8WsK1fAvGitthpDk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NOvoUwGVWQM1PfypclrAMefm6RuWcVKVqCIOlCd7kcb+OOrOwTGrSpCxg3Bg6o/+t T/siM4uVaTBMOU8ojhZBZn4ZYyIStZgDImWnNUOfQR4tVuaFAD3bXVQwgZOgtZycRF Kwfppg57QNPfe/4thep1gB1H0fnP8bkPdrM3Vpu4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xiumei Mu , Sabrina Dubroca , Steffen Klassert Subject: [PATCH 4.19 20/49] xfrmi: drop ignore_df check before updating pmtu Date: Mon, 12 Oct 2020 15:27:06 +0200 Message-Id: <20201012132630.392304657@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201012132629.469542486@linuxfoundation.org> References: <20201012132629.469542486@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sabrina Dubroca commit 45a36a18d01907710bad5258d81f76c18882ad88 upstream. xfrm interfaces currently test for !skb->ignore_df when deciding whether to update the pmtu on the skb's dst. Because of this, no pmtu exception is created when we do something like: ping -s 1438 By dropping this check, the pmtu exception will be created and the next ping attempt will work. Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces") Reported-by: Xiumei Mu Signed-off-by: Sabrina Dubroca Signed-off-by: Steffen Klassert Signed-off-by: Greg Kroah-Hartman --- net/xfrm/xfrm_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/xfrm/xfrm_interface.c +++ b/net/xfrm/xfrm_interface.c @@ -293,7 +293,7 @@ xfrmi_xmit2(struct sk_buff *skb, struct } mtu = dst_mtu(dst); - if (!skb->ignore_df && skb->len > mtu) { + if (skb->len > mtu) { skb_dst_update_pmtu_no_confirm(skb, mtu); if (skb->protocol == htons(ETH_P_IPV6)) {