From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66CEAC433E7 for ; Mon, 12 Oct 2020 14:04:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B307206F4 for ; Mon, 12 Oct 2020 14:04:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602511442; bh=OPa5yQLzYJHvajpXaufU2Bxo/HPPfAOXikCA6XAhZNY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=XCGP07okn9JrLlXQk1F6PnpgFMqArPlEBw2vreN7W1MBXk8CEZjd8cgdQm7r/3X3d oDhu4DHia6GCR6PjppRr051UFFAXARA02/kahAtDz1U/WFGRu+NuTMRpLCfcEgabw0 xKN1HJljYPP6/p9eRtLWsVF4zbS0n0XnXuZoZQRg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390879AbgJLOEA (ORCPT ); Mon, 12 Oct 2020 10:04:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:39132 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730496AbgJLNg0 (ORCPT ); Mon, 12 Oct 2020 09:36:26 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 124CB2074F; Mon, 12 Oct 2020 13:36:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602509785; bh=OPa5yQLzYJHvajpXaufU2Bxo/HPPfAOXikCA6XAhZNY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U3mpRK4Vo3fhNNFqCP4iwZVmYWI3vVi4GIQzIwlvzSJu8ESx+axOfQSQz9WhDwmQQ On9DTqwXXxNKoMP/qd00z0F7DquTAo6exrbNo203x5PlfJajFeoFhDTLJ1EMTZNnQB hSLN9yT6wvCGlID57mrNvsOaPSHdUWvRP6O6EZJc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Al Viro Subject: [PATCH 4.14 29/70] ep_create_wakeup_source(): dentry name can change under you... Date: Mon, 12 Oct 2020 15:26:45 +0200 Message-Id: <20201012132631.595858190@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201012132630.201442517@linuxfoundation.org> References: <20201012132630.201442517@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Al Viro commit 3701cb59d892b88d569427586f01491552f377b1 upstream. or get freed, for that matter, if it's a long (separately stored) name. Signed-off-by: Al Viro Signed-off-by: Greg Kroah-Hartman --- fs/eventpoll.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -1389,7 +1389,7 @@ static int reverse_path_check(void) static int ep_create_wakeup_source(struct epitem *epi) { - const char *name; + struct name_snapshot n; struct wakeup_source *ws; if (!epi->ep->ws) { @@ -1398,8 +1398,9 @@ static int ep_create_wakeup_source(struc return -ENOMEM; } - name = epi->ffd.file->f_path.dentry->d_name.name; - ws = wakeup_source_register(name); + take_dentry_name_snapshot(&n, epi->ffd.file->f_path.dentry); + ws = wakeup_source_register(n.name); + release_dentry_name_snapshot(&n); if (!ws) return -ENOMEM;