From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7324FC43467 for ; Mon, 12 Oct 2020 13:47:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FC1E2227E for ; Mon, 12 Oct 2020 13:47:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602510477; bh=tJmT2y/FrIAr0MGCssRr4tjanVeOY5jttuPUMfr1Ado=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=T4aBsuYktjXjN7V14Wmxk7vhrM3qygOdE5fi/8Vt0fuvHKg+Vvn9yU5dTfbWTJn5b 4V5FfJ5CHZISZFSJApggouJH4CpZ8gkGytwlQe3yxhBvTJ8g7SB1GN76WTpDVlfyyI VLxuEKvRTTNe3vnhVUsyd2oqRsG+pqubQ9PFNW6A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731751AbgJLNr4 (ORCPT ); Mon, 12 Oct 2020 09:47:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:46188 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389769AbgJLNpz (ORCPT ); Mon, 12 Oct 2020 09:45:55 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D1AFD208B8; Mon, 12 Oct 2020 13:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602510343; bh=tJmT2y/FrIAr0MGCssRr4tjanVeOY5jttuPUMfr1Ado=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lnMgo8AzlhTxO3SpBfjS2yPP7VP8ii9+XF10qs6lV+7nsF/DwtdmuQnrkgqh70JWd nLN7/3UUsdgUpk6M6ndjdSyEveR9LofsfyRGzzeau/QgG12o5xAXj2uUSMpVLi2ovq LM/WLFx/Cz71CMKPmy2qHjHkVVcaYdGV2orsnAEI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Necip Fazil Yildiran , Hans de Goede , mark gross , Andy Shevchenko , Sasha Levin Subject: [PATCH 5.8 059/124] platform/x86: fix kconfig dependency warning for LG_LAPTOP Date: Mon, 12 Oct 2020 15:31:03 +0200 Message-Id: <20201012133149.717102975@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201012133146.834528783@linuxfoundation.org> References: <20201012133146.834528783@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Necip Fazil Yildiran [ Upstream commit 8f0c01e666685c4d2e1a233e6f4d7ab16c9f8b2a ] When LG_LAPTOP is enabled and NEW_LEDS is disabled, it results in the following Kbuild warning: WARNING: unmet direct dependencies detected for LEDS_CLASS Depends on [n]: NEW_LEDS [=n] Selected by [y]: - LG_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && ACPI_WMI [=y] && INPUT [=y] The reason is that LG_LAPTOP selects LEDS_CLASS without depending on or selecting NEW_LEDS while LEDS_CLASS is subordinate to NEW_LEDS. Honor the kconfig menu hierarchy to remove kconfig dependency warnings. Fixes: dbf0c5a6b1f8 ("platform/x86: Add LG Gram laptop special features driver") Signed-off-by: Necip Fazil Yildiran Reviewed-by: Hans de Goede Acked-by: mark gross Signed-off-by: Andy Shevchenko Signed-off-by: Sasha Levin --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 0581a54cf562f..e1668a9538c8f 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1091,6 +1091,7 @@ config LG_LAPTOP depends on ACPI_WMI depends on INPUT select INPUT_SPARSEKMAP + select NEW_LEDS select LEDS_CLASS help This driver adds support for hotkeys as well as control of keyboard -- 2.25.1