From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 787FAC433DF for ; Mon, 12 Oct 2020 13:49:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 294CA20678 for ; Mon, 12 Oct 2020 13:49:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602510577; bh=ByvkiNcjRBSEt3jkPzxUI6DAEmvBmxBKc8xsQN8Qfh0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Ghn+1l447v/kaVGa/lTll7ONg8/YcS/e5RDuFcpZljF1UFrjyl1vRs5uO+2Dpvw2w yyyVJg8wVOo3g1OPv1x/cKCdJ2/AeggWXO9fxDXT+rLLR7MZ5KKl6ispIwso7xwed1 gbCLRuswT3TI3/0I7SA6msPIJkpyYqlfgnGZVA5A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730802AbgJLNtg (ORCPT ); Mon, 12 Oct 2020 09:49:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:55744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731919AbgJLNsT (ORCPT ); Mon, 12 Oct 2020 09:48:19 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F24A922266; Mon, 12 Oct 2020 13:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602510466; bh=ByvkiNcjRBSEt3jkPzxUI6DAEmvBmxBKc8xsQN8Qfh0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IW0/2IhpfD+toxywF60fSKQU0RIfMmiK89a4f0WmyqhllU9QrlTiILOe5OtLwVWxB MPEklbRubLpNajVtd7tP2XyTZIwqIqqioN5sECx5FDmQemp6lSGsP89pJvU0uwGf6K QPuZFzVQqYBaOyx9LKrXeCClc1aLE4l2HgmTSGF4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Minchan Kim , Andrew Morton , Jeff Layton , Jan Kara , Andres Freund , Matthew Wilcox , Al Viro , Christoph Hellwig , Dave Chinner , David Howells , Linus Torvalds Subject: [PATCH 5.8 111/124] mm: validate inode in mapping_set_error() Date: Mon, 12 Oct 2020 15:31:55 +0200 Message-Id: <20201012133152.226106025@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201012133146.834528783@linuxfoundation.org> References: <20201012133146.834528783@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Minchan Kim commit 8b7b2eb131d3476062ffd34358785b44be25172f upstream. The swap address_space doesn't have host. Thus, it makes kernel crash once swap write meets error. Fix it. Fixes: 735e4ae5ba28 ("vfs: track per-sb writeback errors and report them to syncfs") Signed-off-by: Minchan Kim Signed-off-by: Andrew Morton Acked-by: Jeff Layton Cc: Jan Kara Cc: Andres Freund Cc: Matthew Wilcox Cc: Al Viro Cc: Christoph Hellwig Cc: Dave Chinner Cc: David Howells Cc: Link: https://lkml.kernel.org/r/20201010000650.750063-1-minchan@kernel.org Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- include/linux/pagemap.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -54,7 +54,8 @@ static inline void mapping_set_error(str __filemap_set_wb_err(mapping, error); /* Record it in superblock */ - errseq_set(&mapping->host->i_sb->s_wb_err, error); + if (mapping->host) + errseq_set(&mapping->host->i_sb->s_wb_err, error); /* Record it in flags for now, for legacy callers */ if (error == -ENOSPC)