All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kent Gibson <warthog618@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2] gpiolib: Switch to use compat_need_64bit_alignment_fixup() helper
Date: Mon, 12 Oct 2020 17:00:59 +0300	[thread overview]
Message-ID: <20201012140059.GY4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201012130741.GA58711@sol>

On Mon, Oct 12, 2020 at 09:07:41PM +0800, Kent Gibson wrote:
> On Thu, Oct 08, 2020 at 04:41:05PM +0300, Andy Shevchenko wrote:
> > The new compat_need_64bit_alignment_fixup() helper allows to avoid
> > ugly ifdeffery in IOCTL compatible code. Use it in GPIO cdev code.

> I'd re-arrange that checkin comment to
> 
> "Use the new compat_need_64bit_alignment_fixup() helper to avoid
> ugly ifdeffery in IOCTL compatibility code."

OK!

> but otherwise all good.
> 
> +1 on the deuglification, and it still works too.
> 
> Tested-by: Kent Gibson <warthog618@gmail.com>

Thanks.

> > Depends-on: 527c412519eb ("compat: add a compat_need_64bit_alignment_fixup() helper")

> > Depends-on: cc7886d25bca ("compat: lift compat_s64 and compat_u64 to <asm-generic/compat.h>")

I'll also drop this one, since former is dependent on latter.

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2020-10-12 14:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08 13:41 [PATCH v2] gpiolib: Switch to use compat_need_64bit_alignment_fixup() helper Andy Shevchenko
2020-10-12  4:20 ` Kent Gibson
2020-10-12 10:03   ` Andy Shevchenko
2020-10-12 13:07 ` Kent Gibson
2020-10-12 14:00   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201012140059.GY4077@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=warthog618@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.